* [Intel-wired-lan] [PATCH 1/1] idpf: Add missing dependencies @ 2025-07-11 6:47 Malin Jonsson 2025-07-11 10:25 ` Przemek Kitszel 0 siblings, 1 reply; 6+ messages in thread From: Malin Jonsson @ 2025-07-11 6:47 UTC (permalink / raw) To: intel-wired-lan; +Cc: yong.g.gu, roland.kovacs The idpf driver depends on both AUXILIARY_BUS and NET_DEVLINK, but they're not selected by the Kconfig. Let's fix this so idpf builds even with a stripped config. Reported-by: Yong Gu <yong.g.gu@ericsson.com> Signed-off-by: Malin Jonsson <malin.jonsson@est.tech> --- drivers/net/ethernet/intel/idpf/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/intel/idpf/Kconfig b/drivers/net/ethernet/intel/idpf/Kconfig index 1f893221e2c99..5c7ce626aae16 100644 --- a/drivers/net/ethernet/intel/idpf/Kconfig +++ b/drivers/net/ethernet/intel/idpf/Kconfig @@ -8,6 +8,8 @@ config IDPF select LIBETH select LIBETH_CP select LIBETH_IRQ + select AUXILIARY_BUS + select NET_DEVLINK help This driver supports Intel(R) Infrastructure Data Path Function devices. -- 2.34.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Intel-wired-lan] [PATCH 1/1] idpf: Add missing dependencies 2025-07-11 6:47 [Intel-wired-lan] [PATCH 1/1] idpf: Add missing dependencies Malin Jonsson @ 2025-07-11 10:25 ` Przemek Kitszel 2025-07-11 11:22 ` Malin Jonsson 2025-07-14 14:32 ` Alexander Lobakin 0 siblings, 2 replies; 6+ messages in thread From: Przemek Kitszel @ 2025-07-11 10:25 UTC (permalink / raw) To: Malin Jonsson; +Cc: yong.g.gu, roland.kovacs, intel-wired-lan On 7/11/25 08:47, Malin Jonsson wrote: > The idpf driver depends on both AUXILIARY_BUS and NET_DEVLINK, but > they're not selected by the Kconfig. Let's fix this so idpf builds even > with a stripped config. > > Reported-by: Yong Gu <yong.g.gu@ericsson.com> > Signed-off-by: Malin Jonsson <malin.jonsson@est.tech> Thank you for the fix! if you have a Link to the public report, please add it as a Closes: tag Would be also great to add a Fixes: tag with the commit that introduces the need for given dependency/ies (there should be one tag only (per your commit), if both deps were introduced by the very same pull request, just use the earlier commit) > --- > drivers/net/ethernet/intel/idpf/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/intel/idpf/Kconfig b/drivers/net/ethernet/intel/idpf/Kconfig > index 1f893221e2c99..5c7ce626aae16 100644 > --- a/drivers/net/ethernet/intel/idpf/Kconfig > +++ b/drivers/net/ethernet/intel/idpf/Kconfig > @@ -8,6 +8,8 @@ config IDPF > select LIBETH > select LIBETH_CP > select LIBETH_IRQ > + select AUXILIARY_BUS > + select NET_DEVLINK looks good, but please notice that we keep this list sorted > help > This driver supports Intel(R) Infrastructure Data Path Function > devices. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-wired-lan] [PATCH 1/1] idpf: Add missing dependencies 2025-07-11 10:25 ` Przemek Kitszel @ 2025-07-11 11:22 ` Malin Jonsson 2025-07-11 13:53 ` Malin Jonsson 2025-07-14 14:32 ` Alexander Lobakin 1 sibling, 1 reply; 6+ messages in thread From: Malin Jonsson @ 2025-07-11 11:22 UTC (permalink / raw) To: Przemek Kitszel; +Cc: yong.g.gu, roland.kovacs, intel-wired-lan On fre, 11 jul 2025, Przemek Kitszel wrote: > On 7/11/25 08:47, Malin Jonsson wrote: > > The idpf driver depends on both AUXILIARY_BUS and NET_DEVLINK, but > > they're not selected by the Kconfig. Let's fix this so idpf builds even > > with a stripped config. > > > > Reported-by: Yong Gu <yong.g.gu@ericsson.com> > > Signed-off-by: Malin Jonsson <malin.jonsson@est.tech> > > Thank you for the fix! My pleasure! > if you have a Link to the public report, please add it as a Closes: tag There is no public report that I'm aware of. > > Would be also great to add a Fixes: tag with the commit that introduces > the need for given dependency/ies I can do that. > (there should be one tag only (per your commit), if both deps were > introduced by the very same pull request, just use the earlier commit) > > > --- > > drivers/net/ethernet/intel/idpf/Kconfig | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/net/ethernet/intel/idpf/Kconfig b/drivers/net/ethernet/intel/idpf/Kconfig > > index 1f893221e2c99..5c7ce626aae16 100644 > > --- a/drivers/net/ethernet/intel/idpf/Kconfig > > +++ b/drivers/net/ethernet/intel/idpf/Kconfig > > @@ -8,6 +8,8 @@ config IDPF > > select LIBETH > > select LIBETH_CP > > select LIBETH_IRQ > > + select AUXILIARY_BUS > > + select NET_DEVLINK > > looks good, but please notice that we keep this list sorted Thanks! I will fix this and resubmit. > > > help > > This driver supports Intel(R) Infrastructure Data Path Function > > devices. > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-wired-lan] [PATCH 1/1] idpf: Add missing dependencies 2025-07-11 11:22 ` Malin Jonsson @ 2025-07-11 13:53 ` Malin Jonsson 0 siblings, 0 replies; 6+ messages in thread From: Malin Jonsson @ 2025-07-11 13:53 UTC (permalink / raw) To: Przemek Kitszel; +Cc: yong.g.gu, roland.kovacs, intel-wired-lan, john.jacques On fre, 11 jul 2025, Malin Jonsson wrote: > On fre, 11 jul 2025, Przemek Kitszel wrote: > > > On 7/11/25 08:47, Malin Jonsson wrote: > > > The idpf driver depends on both AUXILIARY_BUS and NET_DEVLINK, but > > > they're not selected by the Kconfig. Let's fix this so idpf builds even > > > with a stripped config. > > > > > > Reported-by: Yong Gu <yong.g.gu@ericsson.com> > > > Signed-off-by: Malin Jonsson <malin.jonsson@est.tech> > > > > Thank you for the fix! > > My pleasure! > > > if you have a Link to the public report, please add it as a Closes: tag > > There is no public report that I'm aware of. > > > > > Would be also great to add a Fixes: tag with the commit that introduces > > the need for given dependency/ies > > I can do that. > > > (there should be one tag only (per your commit), if both deps were > > introduced by the very same pull request, just use the earlier commit) > > > > > --- > > > drivers/net/ethernet/intel/idpf/Kconfig | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/net/ethernet/intel/idpf/Kconfig b/drivers/net/ethernet/intel/idpf/Kconfig > > > index 1f893221e2c99..5c7ce626aae16 100644 > > > --- a/drivers/net/ethernet/intel/idpf/Kconfig > > > +++ b/drivers/net/ethernet/intel/idpf/Kconfig > > > @@ -8,6 +8,8 @@ config IDPF > > > select LIBETH > > > select LIBETH_CP > > > select LIBETH_IRQ > > > + select AUXILIARY_BUS > > > + select NET_DEVLINK > > > > looks good, but please notice that we keep this list sorted > > Thanks! I will fix this and resubmit. > > > > > help > > > This driver supports Intel(R) Infrastructure Data Path Function > > > devices. > > > > > > Apologies Przemek, I did not do my due diligence before I submitted this fix: I maintain a custom kernel for an Intel chip that's still under development (PMR), and we receive patches before submission to go with early releases of the PMR simulator. The patches that introduce the dependencies are not on the list yet. Thank you for your prompt and kind response, and your time! Cheers //malin ~ ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-wired-lan] [PATCH 1/1] idpf: Add missing dependencies 2025-07-11 10:25 ` Przemek Kitszel 2025-07-11 11:22 ` Malin Jonsson @ 2025-07-14 14:32 ` Alexander Lobakin 2025-07-15 11:37 ` Malin Jonsson 1 sibling, 1 reply; 6+ messages in thread From: Alexander Lobakin @ 2025-07-14 14:32 UTC (permalink / raw) To: Malin Jonsson; +Cc: Przemek Kitszel, yong.g.gu, roland.kovacs, intel-wired-lan From: Przemek Kitszel <przemyslaw.kitszel@intel.com> Date: Fri, 11 Jul 2025 12:25:09 +0200 > On 7/11/25 08:47, Malin Jonsson wrote: >> The idpf driver depends on both AUXILIARY_BUS and NET_DEVLINK, but >> they're not selected by the Kconfig. Let's fix this so idpf builds even >> with a stripped config. >> >> Reported-by: Yong Gu <yong.g.gu@ericsson.com> >> Signed-off-by: Malin Jonsson <malin.jonsson@est.tech> > > Thank you for the fix! > if you have a Link to the public report, please add it as a Closes: tag > > Would be also great to add a Fixes: tag with the commit that introduces > the need for given dependency/ies > (there should be one tag only (per your commit), if both deps were > introduced by the very same pull request, just use the earlier commit) > >> --- >> drivers/net/ethernet/intel/idpf/Kconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/net/ethernet/intel/idpf/Kconfig b/drivers/net/ >> ethernet/intel/idpf/Kconfig >> index 1f893221e2c99..5c7ce626aae16 100644 >> --- a/drivers/net/ethernet/intel/idpf/Kconfig >> +++ b/drivers/net/ethernet/intel/idpf/Kconfig >> @@ -8,6 +8,8 @@ config IDPF >> select LIBETH >> select LIBETH_CP >> select LIBETH_IRQ >> + select AUXILIARY_BUS >> + select NET_DEVLINK Uhm, idpf currently uses neither of those... Could you give a real output with the linker being unable to resolve auxbus and/or devlink symbols for idpf.ko? > > looks good, but please notice that we keep this list sorted > >> help >> This driver supports Intel(R) Infrastructure Data Path Function >> devices. Thanks, Olek ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-wired-lan] [PATCH 1/1] idpf: Add missing dependencies 2025-07-14 14:32 ` Alexander Lobakin @ 2025-07-15 11:37 ` Malin Jonsson 0 siblings, 0 replies; 6+ messages in thread From: Malin Jonsson @ 2025-07-15 11:37 UTC (permalink / raw) To: Alexander Lobakin Cc: Przemek Kitszel, yong.g.gu, roland.kovacs, intel-wired-lan On mån, 14 jul 2025, Alexander Lobakin wrote: > From: Przemek Kitszel <przemyslaw.kitszel@intel.com> > Date: Fri, 11 Jul 2025 12:25:09 +0200 > > > On 7/11/25 08:47, Malin Jonsson wrote: > >> The idpf driver depends on both AUXILIARY_BUS and NET_DEVLINK, but > >> they're not selected by the Kconfig. Let's fix this so idpf builds even > >> with a stripped config. > >> > >> Reported-by: Yong Gu <yong.g.gu@ericsson.com> > >> Signed-off-by: Malin Jonsson <malin.jonsson@est.tech> > > > > Thank you for the fix! > > if you have a Link to the public report, please add it as a Closes: tag > > > > Would be also great to add a Fixes: tag with the commit that introduces > > the need for given dependency/ies > > (there should be one tag only (per your commit), if both deps were > > introduced by the very same pull request, just use the earlier commit) > > > >> --- > >> drivers/net/ethernet/intel/idpf/Kconfig | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/drivers/net/ethernet/intel/idpf/Kconfig b/drivers/net/ > >> ethernet/intel/idpf/Kconfig > >> index 1f893221e2c99..5c7ce626aae16 100644 > >> --- a/drivers/net/ethernet/intel/idpf/Kconfig > >> +++ b/drivers/net/ethernet/intel/idpf/Kconfig > >> @@ -8,6 +8,8 @@ config IDPF > >> select LIBETH > >> select LIBETH_CP > >> select LIBETH_IRQ > >> + select AUXILIARY_BUS > >> + select NET_DEVLINK > > Uhm, idpf currently uses neither of those... Correct, I didn't do my due diligence before I submitted the fix: I maintain a custom kernel for an Intel chip that's still under development (PMR), and we receive patches before submission to go with early releases of the PMR simulator. The patches that introduce the dependencies are not on the list yet - I only realised this when I started searching the list for the commits in question. > > Could you give a real output with the linker being unable to resolve > auxbus and/or devlink symbols for idpf.ko? This information doesn't apply to the upstream driver of course, but for completeness' sake: ERROR: modpost: "devlink_info_version_running_put" [drivers/net/ethernet/intel/idpf/idpf.ko] undefined! ERROR: modpost: "auxiliary_driver_unregister" [drivers/net/ethernet/intel/idpf/idpf.ko] undefined! ERROR: modpost: "priv_to_devlink" [drivers/net/ethernet/intel/idpf/idpf.ko] undefined! ERROR: modpost: "devl_nested_devlink_set" [drivers/net/ethernet/intel/idpf/idpf.ko] undefined! ERROR: modpost: "__auxiliary_device_add" [drivers/net/ethernet/intel/idpf/idpf.ko] undefined! ERROR: modpost: "devl_port_register_with_ops" [drivers/net/ethernet/intel/idpf/idpf.ko] undefined! ERROR: modpost: "devlink_info_serial_number_put" [drivers/net/ethernet/intel/idpf/idpf.ko] undefined! ERROR: modpost: "devl_unlock" [drivers/net/ethernet/intel/idpf/idpf.ko] undefined! ERROR: modpost: "devl_port_unregister" [drivers/net/ethernet/intel/idpf/idpf.ko] undefined! ERROR: modpost: "devlink_priv" [drivers/net/ethernet/intel/idpf/idpf.ko] undefined! WARNING: modpost: suppressed 10 unresolved symbol warnings because there were too many) make[2]: *** [scripts/Makefile.modpost:147: Module.symvers] Error 1 make[1]: *** [/repo/malin/elin/linux/Makefile:1956: modpost] Error 2 > > > > > looks good, but please notice that we keep this list sorted > > > >> help > >> This driver supports Intel(R) Infrastructure Data Path Function > >> devices. > > Thanks, > Olek Cheers //malin ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-07-15 11:37 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-07-11 6:47 [Intel-wired-lan] [PATCH 1/1] idpf: Add missing dependencies Malin Jonsson 2025-07-11 10:25 ` Przemek Kitszel 2025-07-11 11:22 ` Malin Jonsson 2025-07-11 13:53 ` Malin Jonsson 2025-07-14 14:32 ` Alexander Lobakin 2025-07-15 11:37 ` Malin Jonsson
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.