* [PATCH] i386: Build SEV only for 64-bit target
@ 2025-07-16 7:15 Cédric Le Goater
2025-07-16 9:28 ` Daniel P. Berrangé
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Cédric Le Goater @ 2025-07-16 7:15 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Cédric Le Goater
Recent changes broke build on 32-bit host. Since there is no 32-bit
support, restrict SEV to 64-bit.
Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
hw/i386/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
index 14d23e27b580b2d5ea3aa4c07ba066f21a62e348..5139d2308777114e76a789c4f850fa20f3fa754f 100644
--- a/hw/i386/Kconfig
+++ b/hw/i386/Kconfig
@@ -4,7 +4,7 @@ config X86_FW_OVMF
config SEV
bool
select X86_FW_OVMF
- depends on KVM
+ depends on KVM && X86_64
config SGX
bool
--
2.50.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] i386: Build SEV only for 64-bit target
2025-07-16 7:15 [PATCH] i386: Build SEV only for 64-bit target Cédric Le Goater
@ 2025-07-16 9:28 ` Daniel P. Berrangé
2025-07-16 9:36 ` Cédric Le Goater
2025-07-17 5:23 ` Xiaoyao Li
2025-07-28 17:25 ` Cédric Le Goater
2 siblings, 1 reply; 6+ messages in thread
From: Daniel P. Berrangé @ 2025-07-16 9:28 UTC (permalink / raw)
To: Cédric Le Goater; +Cc: qemu-devel, Paolo Bonzini
On Wed, Jul 16, 2025 at 09:15:54AM +0200, Cédric Le Goater wrote:
> Recent changes broke build on 32-bit host. Since there is no 32-bit
> support, restrict SEV to 64-bit.
>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
> hw/i386/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Matches what we just did for TDX too.
>
> diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
> index 14d23e27b580b2d5ea3aa4c07ba066f21a62e348..5139d2308777114e76a789c4f850fa20f3fa754f 100644
> --- a/hw/i386/Kconfig
> +++ b/hw/i386/Kconfig
> @@ -4,7 +4,7 @@ config X86_FW_OVMF
> config SEV
> bool
> select X86_FW_OVMF
> - depends on KVM
> + depends on KVM && X86_64
>
> config SGX
> bool
> --
> 2.50.1
>
>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i386: Build SEV only for 64-bit target
2025-07-16 9:28 ` Daniel P. Berrangé
@ 2025-07-16 9:36 ` Cédric Le Goater
2025-07-16 9:56 ` Daniel P. Berrangé
0 siblings, 1 reply; 6+ messages in thread
From: Cédric Le Goater @ 2025-07-16 9:36 UTC (permalink / raw)
To: Daniel P. Berrangé; +Cc: qemu-devel, Paolo Bonzini
On 7/16/25 11:28, Daniel P. Berrangé wrote:
> On Wed, Jul 16, 2025 at 09:15:54AM +0200, Cédric Le Goater wrote:
>> Recent changes broke build on 32-bit host. Since there is no 32-bit
>> support, restrict SEV to 64-bit.
>>
>> Signed-off-by: Cédric Le Goater <clg@redhat.com>
>> ---
>> hw/i386/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>
> Matches what we just did for TDX too.
What about SGX ?
Thanks,
C.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i386: Build SEV only for 64-bit target
2025-07-16 9:36 ` Cédric Le Goater
@ 2025-07-16 9:56 ` Daniel P. Berrangé
0 siblings, 0 replies; 6+ messages in thread
From: Daniel P. Berrangé @ 2025-07-16 9:56 UTC (permalink / raw)
To: Cédric Le Goater; +Cc: qemu-devel, Paolo Bonzini
On Wed, Jul 16, 2025 at 11:36:48AM +0200, Cédric Le Goater wrote:
> On 7/16/25 11:28, Daniel P. Berrangé wrote:
> > On Wed, Jul 16, 2025 at 09:15:54AM +0200, Cédric Le Goater wrote:
> > > Recent changes broke build on 32-bit host. Since there is no 32-bit
> > > support, restrict SEV to 64-bit.
> > >
> > > Signed-off-by: Cédric Le Goater <clg@redhat.com>
> > > ---
> > > hw/i386/Kconfig | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> >
> > Matches what we just did for TDX too.
>
> What about SGX ?
Our SGX features only require kernel support.
The SGX userspace SDK can build for 32 & 64 bit, though in Fedora/RHEL I
will only build it for 64-bit, but that's not relevant for QEMU's needs
anyway.
Ultimately we're dropping 32-bit host support for QEMU in general at the
end of this year, so we don't need to go out of our way to selectively
drop things before then unless they're giving us trouble today.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i386: Build SEV only for 64-bit target
2025-07-16 7:15 [PATCH] i386: Build SEV only for 64-bit target Cédric Le Goater
2025-07-16 9:28 ` Daniel P. Berrangé
@ 2025-07-17 5:23 ` Xiaoyao Li
2025-07-28 17:25 ` Cédric Le Goater
2 siblings, 0 replies; 6+ messages in thread
From: Xiaoyao Li @ 2025-07-17 5:23 UTC (permalink / raw)
To: Cédric Le Goater, qemu-devel; +Cc: Paolo Bonzini
On 7/16/2025 3:15 PM, Cédric Le Goater wrote:
> Recent changes broke build on 32-bit host. Since there is no 32-bit
> support, restrict SEV to 64-bit.
>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Xiaoyao Li <xiaoyao.li@intel.com>
> ---
> hw/i386/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
> index 14d23e27b580b2d5ea3aa4c07ba066f21a62e348..5139d2308777114e76a789c4f850fa20f3fa754f 100644
> --- a/hw/i386/Kconfig
> +++ b/hw/i386/Kconfig
> @@ -4,7 +4,7 @@ config X86_FW_OVMF
> config SEV
> bool
> select X86_FW_OVMF
> - depends on KVM
> + depends on KVM && X86_64
>
> config SGX
> bool
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i386: Build SEV only for 64-bit target
2025-07-16 7:15 [PATCH] i386: Build SEV only for 64-bit target Cédric Le Goater
2025-07-16 9:28 ` Daniel P. Berrangé
2025-07-17 5:23 ` Xiaoyao Li
@ 2025-07-28 17:25 ` Cédric Le Goater
2 siblings, 0 replies; 6+ messages in thread
From: Cédric Le Goater @ 2025-07-28 17:25 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini
On 7/16/25 09:15, Cédric Le Goater wrote:
> Recent changes broke build on 32-bit host. Since there is no 32-bit
> support, restrict SEV to 64-bit.
>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
> hw/i386/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
> index 14d23e27b580b2d5ea3aa4c07ba066f21a62e348..5139d2308777114e76a789c4f850fa20f3fa754f 100644
> --- a/hw/i386/Kconfig
> +++ b/hw/i386/Kconfig
> @@ -4,7 +4,7 @@ config X86_FW_OVMF
> config SEV
> bool
> select X86_FW_OVMF
> - depends on KVM
> + depends on KVM && X86_64
>
> config SGX
> bool
Applied to vfio-next.
Thanks,
C.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-07-28 17:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-16 7:15 [PATCH] i386: Build SEV only for 64-bit target Cédric Le Goater
2025-07-16 9:28 ` Daniel P. Berrangé
2025-07-16 9:36 ` Cédric Le Goater
2025-07-16 9:56 ` Daniel P. Berrangé
2025-07-17 5:23 ` Xiaoyao Li
2025-07-28 17:25 ` Cédric Le Goater
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.