* [PATCH] dom0less: Fix LLC coloring when mixing colored and non-colored domains
@ 2025-07-16 15:35 Alejandro Vallejo
2025-07-16 18:58 ` dmkhn
0 siblings, 1 reply; 3+ messages in thread
From: Alejandro Vallejo @ 2025-07-16 15:35 UTC (permalink / raw)
To: xen-devel
Cc: Alejandro Vallejo, Stefano Stabellini, Julien Grall,
Bertrand Marquis, Michal Orzel
llc_colors_str being outside the main loop makes domains without
explicit coloring inherit the colors of the last colored domain parsed.
Move it inside so that's no longer the case.
Fixes: 5948dc16759c("xen/arm: add support for cache coloring...")
Signed-off-by: Alejandro Vallejo <alejandro.garciavallejo@amd.com>
---
pipeline: https://gitlab.com/xen-project/people/agvallejo/xen/-/pipelines/1930276681
---
xen/common/device-tree/dom0less-build.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/common/device-tree/dom0less-build.c b/xen/common/device-tree/dom0less-build.c
index 221b875a2f..87828d4d9d 100644
--- a/xen/common/device-tree/dom0less-build.c
+++ b/xen/common/device-tree/dom0less-build.c
@@ -829,11 +829,11 @@ void __init create_domUs(void)
bool iommu = false;
const struct dt_device_node *cpupool_node,
*chosen = dt_find_node_by_path("/chosen");
- const char *llc_colors_str = NULL;
BUG_ON(chosen == NULL);
dt_for_each_child_node(chosen, node)
{
+ const char *llc_colors_str = NULL;
struct domain *d;
struct xen_domctl_createdomain d_cfg = {0};
unsigned int flags = 0U;
base-commit: dff462313fe0bfa273c54ffc9bff71f054c365af
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dom0less: Fix LLC coloring when mixing colored and non-colored domains
2025-07-16 15:35 [PATCH] dom0less: Fix LLC coloring when mixing colored and non-colored domains Alejandro Vallejo
@ 2025-07-16 18:58 ` dmkhn
2025-07-17 1:06 ` Stefano Stabellini
0 siblings, 1 reply; 3+ messages in thread
From: dmkhn @ 2025-07-16 18:58 UTC (permalink / raw)
To: Alejandro Vallejo
Cc: xen-devel, Stefano Stabellini, Julien Grall, Bertrand Marquis,
Michal Orzel
On Wed, Jul 16, 2025 at 05:35:03PM +0200, Alejandro Vallejo wrote:
> llc_colors_str being outside the main loop makes domains without
> explicit coloring inherit the colors of the last colored domain parsed.
>
> Move it inside so that's no longer the case.
>
> Fixes: 5948dc16759c("xen/arm: add support for cache coloring...")
> Signed-off-by: Alejandro Vallejo <alejandro.garciavallejo@amd.com>
Reviewed-by: Denis Mukhin <dmukhin@ford.com>
> ---
> pipeline: https://gitlab.com/xen-project/people/agvallejo/xen/-/pipelines/1930276681
> ---
> xen/common/device-tree/dom0less-build.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/common/device-tree/dom0less-build.c b/xen/common/device-tree/dom0less-build.c
> index 221b875a2f..87828d4d9d 100644
> --- a/xen/common/device-tree/dom0less-build.c
> +++ b/xen/common/device-tree/dom0less-build.c
> @@ -829,11 +829,11 @@ void __init create_domUs(void)
> bool iommu = false;
> const struct dt_device_node *cpupool_node,
> *chosen = dt_find_node_by_path("/chosen");
> - const char *llc_colors_str = NULL;
>
> BUG_ON(chosen == NULL);
> dt_for_each_child_node(chosen, node)
> {
> + const char *llc_colors_str = NULL;
> struct domain *d;
> struct xen_domctl_createdomain d_cfg = {0};
> unsigned int flags = 0U;
>
> base-commit: dff462313fe0bfa273c54ffc9bff71f054c365af
> --
> 2.43.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dom0less: Fix LLC coloring when mixing colored and non-colored domains
2025-07-16 18:58 ` dmkhn
@ 2025-07-17 1:06 ` Stefano Stabellini
0 siblings, 0 replies; 3+ messages in thread
From: Stefano Stabellini @ 2025-07-17 1:06 UTC (permalink / raw)
To: dmkhn
Cc: Alejandro Vallejo, xen-devel, Stefano Stabellini, Julien Grall,
Bertrand Marquis, Michal Orzel
On Wed, 16 Jul 2025, dmkhn@proton.me wrote:
> On Wed, Jul 16, 2025 at 05:35:03PM +0200, Alejandro Vallejo wrote:
> > llc_colors_str being outside the main loop makes domains without
> > explicit coloring inherit the colors of the last colored domain parsed.
> >
> > Move it inside so that's no longer the case.
> >
> > Fixes: 5948dc16759c("xen/arm: add support for cache coloring...")
> > Signed-off-by: Alejandro Vallejo <alejandro.garciavallejo@amd.com>
>
> Reviewed-by: Denis Mukhin <dmukhin@ford.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> > ---
> > pipeline: https://gitlab.com/xen-project/people/agvallejo/xen/-/pipelines/1930276681
> > ---
> > xen/common/device-tree/dom0less-build.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/xen/common/device-tree/dom0less-build.c b/xen/common/device-tree/dom0less-build.c
> > index 221b875a2f..87828d4d9d 100644
> > --- a/xen/common/device-tree/dom0less-build.c
> > +++ b/xen/common/device-tree/dom0less-build.c
> > @@ -829,11 +829,11 @@ void __init create_domUs(void)
> > bool iommu = false;
> > const struct dt_device_node *cpupool_node,
> > *chosen = dt_find_node_by_path("/chosen");
> > - const char *llc_colors_str = NULL;
> >
> > BUG_ON(chosen == NULL);
> > dt_for_each_child_node(chosen, node)
> > {
> > + const char *llc_colors_str = NULL;
> > struct domain *d;
> > struct xen_domctl_createdomain d_cfg = {0};
> > unsigned int flags = 0U;
> >
> > base-commit: dff462313fe0bfa273c54ffc9bff71f054c365af
> > --
> > 2.43.0
> >
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-17 1:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-16 15:35 [PATCH] dom0less: Fix LLC coloring when mixing colored and non-colored domains Alejandro Vallejo
2025-07-16 18:58 ` dmkhn
2025-07-17 1:06 ` Stefano Stabellini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.