* [PATCH] i386/cpu: Cleanup host_cpu_max_instance_init()
@ 2025-07-16 6:31 Xiaoyao Li
2025-07-16 6:43 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Xiaoyao Li @ 2025-07-16 6:31 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Zhao Liu, Xiaoyao Li, qemu-devel
The implementation of host_cpu_max_instance_init() was merged into
host_cpu_instance_init() by commit 29f1ba338baf ("target/i386: merge
host_cpu_instance_init() and host_cpu_max_instance_init()"), while the
declaration of it remains in host-cpu.h.
Clean it up.
Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
---
target/i386/host-cpu.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/target/i386/host-cpu.h b/target/i386/host-cpu.h
index 10df4b3a3a74..ee6532422548 100644
--- a/target/i386/host-cpu.h
+++ b/target/i386/host-cpu.h
@@ -12,7 +12,6 @@
uint32_t host_cpu_phys_bits(void);
void host_cpu_instance_init(X86CPU *cpu);
-void host_cpu_max_instance_init(X86CPU *cpu);
bool host_cpu_realizefn(CPUState *cs, Error **errp);
void host_cpu_vendor_fms(char *vendor, int *family, int *model, int *stepping);
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] i386/cpu: Cleanup host_cpu_max_instance_init()
2025-07-16 6:31 [PATCH] i386/cpu: Cleanup host_cpu_max_instance_init() Xiaoyao Li
@ 2025-07-16 6:43 ` Philippe Mathieu-Daudé
2025-07-17 8:41 ` Zhao Liu
2025-07-17 13:52 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-07-16 6:43 UTC (permalink / raw)
To: Xiaoyao Li, Paolo Bonzini; +Cc: Zhao Liu, qemu-devel
On 16/7/25 08:31, Xiaoyao Li wrote:
> The implementation of host_cpu_max_instance_init() was merged into
> host_cpu_instance_init() by commit 29f1ba338baf ("target/i386: merge
> host_cpu_instance_init() and host_cpu_max_instance_init()"), while the
> declaration of it remains in host-cpu.h.
>
> Clean it up.
>
> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
> ---
> target/i386/host-cpu.h | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] i386/cpu: Cleanup host_cpu_max_instance_init()
2025-07-16 6:31 [PATCH] i386/cpu: Cleanup host_cpu_max_instance_init() Xiaoyao Li
2025-07-16 6:43 ` Philippe Mathieu-Daudé
@ 2025-07-17 8:41 ` Zhao Liu
2025-07-17 13:52 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Zhao Liu @ 2025-07-17 8:41 UTC (permalink / raw)
To: Xiaoyao Li; +Cc: Paolo Bonzini, qemu-devel
On Wed, Jul 16, 2025 at 02:31:16PM +0800, Xiaoyao Li wrote:
> Date: Wed, 16 Jul 2025 14:31:16 +0800
> From: Xiaoyao Li <xiaoyao.li@intel.com>
> Subject: [PATCH] i386/cpu: Cleanup host_cpu_max_instance_init()
> X-Mailer: git-send-email 2.43.0
>
> The implementation of host_cpu_max_instance_init() was merged into
> host_cpu_instance_init() by commit 29f1ba338baf ("target/i386: merge
> host_cpu_instance_init() and host_cpu_max_instance_init()"), while the
> declaration of it remains in host-cpu.h.
>
> Clean it up.
>
> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
> ---
> target/i386/host-cpu.h | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] i386/cpu: Cleanup host_cpu_max_instance_init()
2025-07-16 6:31 [PATCH] i386/cpu: Cleanup host_cpu_max_instance_init() Xiaoyao Li
2025-07-16 6:43 ` Philippe Mathieu-Daudé
2025-07-17 8:41 ` Zhao Liu
@ 2025-07-17 13:52 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2025-07-17 13:52 UTC (permalink / raw)
To: Xiaoyao Li; +Cc: Zhao Liu, qemu-devel
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-07-17 15:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-16 6:31 [PATCH] i386/cpu: Cleanup host_cpu_max_instance_init() Xiaoyao Li
2025-07-16 6:43 ` Philippe Mathieu-Daudé
2025-07-17 8:41 ` Zhao Liu
2025-07-17 13:52 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.