* [PATCH 1/1] perf build: Always disable stack protection for BPF skeleton objects
@ 2025-07-18 4:12 Federico Pellegrin
2025-07-23 0:37 ` Namhyung Kim
0 siblings, 1 reply; 2+ messages in thread
From: Federico Pellegrin @ 2025-07-18 4:12 UTC (permalink / raw)
To: peterz, mingo, acme, namhyung, mark.rutland, alexander.shishkin,
jolsa, irogers, adrian.hunter, kan.liang, linux-perf-users
Cc: Federico Pellegrin
When the clang toolchain has stack protection enabled, the bpf
skeletons build fails with:
error: A call to built-in function '__stack_chk_fail' is not supported.
Since stack-protector makes no sense for the BPF bits, just unconditionally
disable it.
See also similar case at 878625e1c7a10dfbb1fdaaaae2c4d2a58fbce627
Signed-off-by: Federico Pellegrin <fede@evolware.org>
---
tools/perf/Makefile.perf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index d4c7031b01a7..ca7dc65a3182 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -1251,7 +1251,7 @@ else
endif
$(SKEL_TMP_OUT)/%.bpf.o: util/bpf_skel/%.bpf.c $(LIBBPF) $(SKEL_OUT)/vmlinux.h | $(SKEL_TMP_OUT)
- $(QUIET_CLANG)$(CLANG) -g -O2 --target=bpf $(CLANG_OPTIONS) $(BPF_INCLUDE) $(TOOLS_UAPI_INCLUDE) \
+ $(QUIET_CLANG)$(CLANG) -g -O2 -fno-stack-protector --target=bpf $(CLANG_OPTIONS) $(BPF_INCLUDE) $(TOOLS_UAPI_INCLUDE) \
-c $(filter util/bpf_skel/%.bpf.c,$^) -o $@
$(SKEL_OUT)/%.skel.h: $(SKEL_TMP_OUT)/%.bpf.o | $(BPFTOOL)
--
2.50.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] perf build: Always disable stack protection for BPF skeleton objects
2025-07-18 4:12 [PATCH 1/1] perf build: Always disable stack protection for BPF skeleton objects Federico Pellegrin
@ 2025-07-23 0:37 ` Namhyung Kim
0 siblings, 0 replies; 2+ messages in thread
From: Namhyung Kim @ 2025-07-23 0:37 UTC (permalink / raw)
To: Federico Pellegrin
Cc: peterz, mingo, acme, mark.rutland, alexander.shishkin, jolsa,
irogers, adrian.hunter, kan.liang, linux-perf-users
Hello,
On Fri, Jul 18, 2025 at 06:12:24AM +0200, Federico Pellegrin wrote:
> When the clang toolchain has stack protection enabled, the bpf
> skeletons build fails with:
>
> error: A call to built-in function '__stack_chk_fail' is not supported.
>
> Since stack-protector makes no sense for the BPF bits, just unconditionally
> disable it.
>
> See also similar case at 878625e1c7a10dfbb1fdaaaae2c4d2a58fbce627
>
> Signed-off-by: Federico Pellegrin <fede@evolware.org>
Applied to perf-tools-next with minor updates.
Thanks,
Namhyung
> ---
> tools/perf/Makefile.perf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index d4c7031b01a7..ca7dc65a3182 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -1251,7 +1251,7 @@ else
> endif
>
> $(SKEL_TMP_OUT)/%.bpf.o: util/bpf_skel/%.bpf.c $(LIBBPF) $(SKEL_OUT)/vmlinux.h | $(SKEL_TMP_OUT)
> - $(QUIET_CLANG)$(CLANG) -g -O2 --target=bpf $(CLANG_OPTIONS) $(BPF_INCLUDE) $(TOOLS_UAPI_INCLUDE) \
> + $(QUIET_CLANG)$(CLANG) -g -O2 -fno-stack-protector --target=bpf $(CLANG_OPTIONS) $(BPF_INCLUDE) $(TOOLS_UAPI_INCLUDE) \
> -c $(filter util/bpf_skel/%.bpf.c,$^) -o $@
>
> $(SKEL_OUT)/%.skel.h: $(SKEL_TMP_OUT)/%.bpf.o | $(BPFTOOL)
> --
> 2.50.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-23 0:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-18 4:12 [PATCH 1/1] perf build: Always disable stack protection for BPF skeleton objects Federico Pellegrin
2025-07-23 0:37 ` Namhyung Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.