All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Update r7s72100 Genmai DTS to include NOR Flash pinctrl
@ 2025-06-28  8:26 Magnus Damm
  2025-07-05  7:08 ` Wolfram Sang
  0 siblings, 1 reply; 4+ messages in thread
From: Magnus Damm @ 2025-06-28  8:26 UTC (permalink / raw)
  To: geert+renesas; +Cc: linux-renesas-soc, Magnus Damm

From: Magnus Damm <damm@opensource.se>

Add pinctrl configuration to the Genmai board for the NOR Flash on CS0 and CS1.

Signed-off-by: Magnus Damm <damm@opensource.se>
---

 arch/arm/boot/dts/renesas/r7s72100-genmai.dts |   52 +++++++++++++++++++++++++
 1 file changed, 52 insertions(+)
 
--- 0001/arch/arm/boot/dts/renesas/r7s72100-genmai.dts
+++ work/arch/arm/boot/dts/renesas/r7s72100-genmai.dts	2025-06-28 17:10:55.537223414 +0900
@@ -99,6 +99,9 @@
 };
 
 &bsc {
+	pinctrl-names = "default";
+	pinctrl-0 = <&bsc_pins>;
+
 	flash@0 {
 		compatible = "cfi-flash";
 		reg = <0x00000000 0x04000000>;
@@ -211,6 +214,55 @@
 };
 
 &pinctrl {
+	bsc_pins: bsc {
+		/* Dual 16-bit Parallel NOR Flash in Serial on CS0 and CS1 */
+		pinmux = <RZA1_PINMUX(6, 0, 1)>, /* P6_0 = D0 */
+			 <RZA1_PINMUX(6, 1, 1)>, /* P6_1 = D1 */
+			 <RZA1_PINMUX(6, 2, 1)>, /* P6_2 = D2 */
+			 <RZA1_PINMUX(6, 3, 1)>, /* P6_3 = D3 */
+			 <RZA1_PINMUX(6, 4, 1)>, /* P6_4 = D4 */
+			 <RZA1_PINMUX(6, 5, 1)>, /* P6_5 = D5 */
+			 <RZA1_PINMUX(6, 6, 1)>, /* P6_6 = D6 */
+			 <RZA1_PINMUX(6, 7, 1)>, /* P6_7 = D7 */
+			 <RZA1_PINMUX(6, 8, 1)>, /* P6_8 = D8 */
+			 <RZA1_PINMUX(6, 9, 1)>, /* P6_9 = D9 */
+			 <RZA1_PINMUX(6, 10, 1)>, /* P6_10 = D10 */
+			 <RZA1_PINMUX(6, 11, 1)>, /* P6_11 = D11 */
+			 <RZA1_PINMUX(6, 12, 1)>, /* P6_12 = D12 */
+			 <RZA1_PINMUX(6, 13, 1)>, /* P6_13 = D13 */
+			 <RZA1_PINMUX(6, 14, 1)>, /* P6_14 = D14 */
+			 <RZA1_PINMUX(6, 15, 1)>, /* P6_15 = D15 */
+			 <RZA1_PINMUX(7, 9, 1)>, /* P7_9 = A1 */
+			 <RZA1_PINMUX(7, 10, 1)>, /* P7_10 = A2 */
+			 <RZA1_PINMUX(7, 11, 1)>, /* P7_11 = A3 */
+			 <RZA1_PINMUX(7, 12, 1)>, /* P7_12 = A4 */
+			 <RZA1_PINMUX(7, 13, 1)>, /* P7_13 = A5 */
+			 <RZA1_PINMUX(7, 14, 1)>, /* P7_14 = A6 */
+			 <RZA1_PINMUX(7, 15, 1)>, /* P7_15 = A7 */
+			 <RZA1_PINMUX(8, 0, 1)>, /* P8_0 = A8 */
+			 <RZA1_PINMUX(8, 1, 1)>, /* P8_1 = A9 */
+			 <RZA1_PINMUX(8, 2, 1)>, /* P8_2 = A10 */
+			 <RZA1_PINMUX(8, 3, 1)>, /* P8_3 = A11 */
+			 <RZA1_PINMUX(8, 4, 1)>, /* P8_4 = A12 */
+			 <RZA1_PINMUX(8, 5, 1)>, /* P8_5 = A13 */
+			 <RZA1_PINMUX(8, 6, 1)>, /* P8_6 = A14 */
+			 <RZA1_PINMUX(8, 7, 1)>, /* P8_7 = A15 */
+			 <RZA1_PINMUX(8, 8, 1)>, /* P8_8 = A16 */
+			 <RZA1_PINMUX(8, 9, 1)>, /* P8_9 = A17 */
+			 <RZA1_PINMUX(8, 10, 1)>, /* P8_10 = A18 */
+			 <RZA1_PINMUX(8, 11, 1)>, /* P8_11 = A19 */
+			 <RZA1_PINMUX(8, 12, 1)>, /* P8_12 = A20 */
+			 <RZA1_PINMUX(8, 13, 1)>, /* P8_13 = A21 */
+			 <RZA1_PINMUX(8, 14, 1)>, /* P8_14 = A22 */
+			 <RZA1_PINMUX(8, 15, 1)>, /* P8_15 = A23 */
+			 <RZA1_PINMUX(9, 0, 1)>, /* P9_0 = A24 */
+			 <RZA1_PINMUX(9, 1, 1)>, /* P9_1 = A25 */
+			 <RZA1_PINMUX(7, 6, 1)>, /* P7_6 = WE0/DQMLL */
+			 <RZA1_PINMUX(7, 8, 1)>, /* P7_8 = RD */
+			 <RZA1_PINMUX(7, 0, 1)>, /* P7_0 = CS0 */
+			 <RZA1_PINMUX(3, 7, 7)>; /* P7_8 = CS1 */
+	};
+
 	ether_pins: ether {
 		/* Ethernet on Ports 1,2,3,5 */
 		pinmux = <RZA1_PINMUX(1, 14, 4)>,/* P1_14 = ET_COL  */

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Update r7s72100 Genmai DTS to include NOR Flash pinctrl
  2025-06-28  8:26 [PATCH] Update r7s72100 Genmai DTS to include NOR Flash pinctrl Magnus Damm
@ 2025-07-05  7:08 ` Wolfram Sang
  2025-07-12 15:30   ` Magnus Damm
  0 siblings, 1 reply; 4+ messages in thread
From: Wolfram Sang @ 2025-07-05  7:08 UTC (permalink / raw)
  To: Magnus Damm; +Cc: geert+renesas, linux-renesas-soc

[-- Attachment #1: Type: text/plain, Size: 541 bytes --]

Wow, Magnus!

On Sat, Jun 28, 2025 at 10:26:24AM +0200, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
> 
> Add pinctrl configuration to the Genmai board for the NOR Flash on CS0 and CS1.

Very glad to see you again! Took a while to get my Genmai out of a far
away drawer, but now I set it up again.

My board won't boot with this patch, though. I assume this is because
the address and data lines are shared with SDRAM and playing with those
while using them is not going to work?

All the best,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Update r7s72100 Genmai DTS to include NOR Flash pinctrl
  2025-07-05  7:08 ` Wolfram Sang
@ 2025-07-12 15:30   ` Magnus Damm
  2025-07-23  7:03     ` Wolfram Sang
  0 siblings, 1 reply; 4+ messages in thread
From: Magnus Damm @ 2025-07-12 15:30 UTC (permalink / raw)
  To: Wolfram Sang, Magnus Damm, geert+renesas, linux-renesas-soc

Hi Wolfram,

On Sat, Jul 5, 2025 at 9:15 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> Wow, Magnus!
>
> On Sat, Jun 28, 2025 at 10:26:24AM +0200, Magnus Damm wrote:
> > From: Magnus Damm <damm@opensource.se>
> >
> > Add pinctrl configuration to the Genmai board for the NOR Flash on CS0 and CS1.
>
> Very glad to see you again! Took a while to get my Genmai out of a far
> away drawer, but now I set it up again.

Thank you.

> My board won't boot with this patch, though. I assume this is because
> the address and data lines are shared with SDRAM and playing with those
> while using them is not going to work?

Yes, I think you are right. Before sending out I made the mistake to
only test with the pinctrl driver in U-Boot, sorry.

I've now written some code for the Linux pinctrl driver that makes the
DT modifications in this patch to start working. Please search for:
[PATCH] pinctrl: renesas: rza1: Check pin state before configuring

Cheers,

Magnus

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Update r7s72100 Genmai DTS to include NOR Flash pinctrl
  2025-07-12 15:30   ` Magnus Damm
@ 2025-07-23  7:03     ` Wolfram Sang
  0 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2025-07-23  7:03 UTC (permalink / raw)
  To: Magnus Damm; +Cc: Magnus Damm, geert+renesas, linux-renesas-soc

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]


> I've now written some code for the Linux pinctrl driver that makes the
> DT modifications in this patch to start working. Please search for:
> [PATCH] pinctrl: renesas: rza1: Check pin state before configuring

Done now.

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-07-23  7:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-28  8:26 [PATCH] Update r7s72100 Genmai DTS to include NOR Flash pinctrl Magnus Damm
2025-07-05  7:08 ` Wolfram Sang
2025-07-12 15:30   ` Magnus Damm
2025-07-23  7:03     ` Wolfram Sang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.