All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/1] cdrom: patch for inclusion
@ 2025-07-22 23:18 Phillip Potter
  2025-07-22 23:19 ` [PATCH 1/1] cdrom: Call cdrom_mrw_exit from cdrom_release function Phillip Potter
                   ` (2 more replies)
  0 siblings, 3 replies; 14+ messages in thread
From: Phillip Potter @ 2025-07-22 23:18 UTC (permalink / raw)
  To: axboe; +Cc: senozhatsky, linux-block

Hi Jens,

Please apply the following patch, suggested by yourself and credited as
such. I have tested that this call does not make things actively worse,
and indeed that optical drive functionality (and in particular release)
still works as expected.

That said, I've been unable to replicate the issue seen in the report
thus far. I have tried a variety of approaches including just yanking
the cable out several times, and in all cases, my kernel does crash or
post a BUG, and properly unloads the driver - this is both on the latest
6.16-rc7 and also on 6.6.98 LTS, and including when I am specifically
inside cdrom_mrw_exit. I plan to do more digging regarding this, hopefully
this weekend when I have some free time, as I'd really love to replicate
the original crash.

I still think this patch makes sense though and should be applied
anyway. I've also patched the unused exit field out in the documentation
file, and used the 'Closes' tag as suggested by checkpatch.
Many thanks in advance.

Regards,
Phil

Phillip Potter (1):
  cdrom: Call cdrom_mrw_exit from cdrom_release function

 Documentation/cdrom/cdrom-standard.rst | 1 -
 drivers/cdrom/cdrom.c                  | 8 ++------
 include/linux/cdrom.h                  | 1 -
 3 files changed, 2 insertions(+), 8 deletions(-)

-- 
2.50.1


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [PATCH 0/1] cdrom: patch for inclusion
@ 2025-05-14 22:33 Phillip Potter
  0 siblings, 0 replies; 14+ messages in thread
From: Phillip Potter @ 2025-05-14 22:33 UTC (permalink / raw)
  To: axboe; +Cc: phil, linux-block

Hi Jens,

I hope you are well :-)

Please accept the following patch from Chen Ni that removes an
unnecessary NULL check in cdrom_sysctl_unregister. I have verified the
necessary check is being done inside unregister_sysctl_table myself, and
indeed a number of other module_exit routines take this same approach.

Many thanks in advance.

Regards,
Phil

Chen Ni (1):
  cdrom: Remove unnecessary NULL check before unregister_sysctl_table()

 drivers/cdrom/cdrom.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

-- 
2.49.0


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [PATCH 0/1] cdrom: patch for inclusion
@ 2024-06-01 22:18 Phillip Potter
  0 siblings, 0 replies; 14+ messages in thread
From: Phillip Potter @ 2024-06-01 22:18 UTC (permalink / raw)
  To: axboe; +Cc: linux-block

Hi Jens,

Please apply the following patch from Jeff Johnson, that adds a missing
MODULE_DESCRIPTION() invocation to drivers/cdrom/cdrom.c, to prevent a
build warning regarding its absence.

Many thanks in advance.

Regards,
Phil

Jeff Johnson (1):
  cdrom: Add missing MODULE_DESCRIPTION()

 drivers/cdrom/cdrom.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.45.1


^ permalink raw reply	[flat|nested] 14+ messages in thread
* [PATCH 0/1] cdrom: patch for inclusion
@ 2023-10-02 22:02 Phillip Potter
  2023-10-03  2:05 ` Jens Axboe
  0 siblings, 1 reply; 14+ messages in thread
From: Phillip Potter @ 2023-10-02 22:02 UTC (permalink / raw)
  To: axboe; +Cc: linux-block

Hi Jens,

Please include Joel's patch below, reviewed and signed off by myself.
Many thanks.

Regards,
Phil

Joel Granados (1):
  cdrom: Remove now superfluous sentinel element from ctl_table array

 drivers/cdrom/cdrom.c | 1 -
 1 file changed, 1 deletion(-)

-- 
2.41.0


^ permalink raw reply	[flat|nested] 14+ messages in thread
end of thread, other threads:[~2025-07-25  7:47 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-22 23:18 [PATCH 0/1] cdrom: patch for inclusion Phillip Potter
2025-07-22 23:19 ` [PATCH 1/1] cdrom: Call cdrom_mrw_exit from cdrom_release function Phillip Potter
2025-07-24  3:55   ` Sergey Senozhatsky
2025-07-23  1:10 ` [PATCH 0/1] cdrom: patch for inclusion Jens Axboe
2025-07-23  1:14 ` Sergey Senozhatsky
2025-07-23  8:02   ` Phillip Potter
2025-07-24  3:54     ` Sergey Senozhatsky
2025-07-24  7:51       ` Sergey Senozhatsky
2025-07-25  7:40         ` Phillip Potter
2025-07-25  7:47           ` Sergey Senozhatsky
  -- strict thread matches above, loose matches on Subject: below --
2025-05-14 22:33 Phillip Potter
2024-06-01 22:18 Phillip Potter
2023-10-02 22:02 Phillip Potter
2023-10-03  2:05 ` Jens Axboe

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.