Re: [PATCH v4 0/4] i3c: add support for the Renesas controller

From: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, Frank Li <Frank.Li@nxp.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Kees Cook <kees@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	linux-hardening@vger.kernel.org, linux-i3c@lists.infradead.org,
	Magnus Damm <magnus.damm@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v4 0/4] i3c: add support for the Renesas controller
Date: Wed, 23 Jul 2025 11:35:44 +0200	[thread overview]
Message-ID: <aICs8JmAUbxFxizc@tom-desktop> (raw)
In-Reply-To: <20250722190749.6264-1-wsa+renesas@sang-engineering.com>

Hi Wolfram,
Thanks for your series!

On Tue, Jul 22, 2025 at 09:07:42PM +0200, Wolfram Sang wrote:
> Detailed changes since v3 are described in the individual patches. A
> branch with enablement patches for RZ/G3S+G3E can be found here:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/g3s/i3c
> 
> Old coverletter:
> 
> Here is a basic driver for the I3C IP found in various Renesas SoCs like
> RZ/G3S and G3E. Missing features to be added incrementally are IBI,
> HotJoin and maybe target support. Other than that, this driver has been
> tested with I3C pure busses (2 targets) and mixed busses (2 I3C +
> various I2C targets). DAA and reading/writing to the temperature sensors
> worked reliably at different speeds. Scoping the bus, the output from
> the protocol analyzer seems reasonable, too. It was created by merging
> two versions of it from two different BSPs. Then, improved according to
> code analyzers, cleaned up with regard to coding style, and then
> refactored to hopefully match I3C subsystem standards.
> 
> Looking forward to comments,
> 
>    Wolfram
> 
> 
> Tommaso Merciai (1):
>   dt-bindings: i3c: Add Renesas I3C controller
> 
> Wolfram Sang (3):
>   i3c: Standardize defines for specification parameters
>   i3c: Add more parameters for controllers to the header
>   i3c: master: Add basic driver for the Renesas I3C controller

Tested this series on top of [1], using RZ/G3E SMARC EVK board +
SMARC BREAKOUT board connected to P3T1085UK-ARD, using i3c pure bus and
I'm able to read the i3c temperature sensor:

root@smarc-rzg3e:~# cat /sys/class/hwmon/*/temp1_input
25875

For all the series:

Tested-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>

[1] https://lkml.org/lkml/2025/6/24/581

Thanks & Regards,
Tommaso

> 
>  .../devicetree/bindings/i3c/renesas,i3c.yaml  |  179 +++
>  MAINTAINERS                                   |    7 +
>  drivers/i3c/master.c                          |   12 +-
>  drivers/i3c/master/Kconfig                    |   10 +
>  drivers/i3c/master/Makefile                   |    1 +
>  drivers/i3c/master/dw-i3c-master.c            |    4 +-
>  drivers/i3c/master/renesas-i3c.c              | 1404 +++++++++++++++++
>  include/linux/i3c/master.h                    |   16 +-
>  8 files changed, 1621 insertions(+), 12 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/i3c/renesas,i3c.yaml
>  create mode 100644 drivers/i3c/master/renesas-i3c.c
> 
> -- 
> 2.47.2
> 