From: Drew Fustini <fustini@kernel.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: "Albert Ou" <aou@eecs.berkeley.edu>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Alexandre Ghiti" <alex@ghiti.fr>,
"Alice Ryhl" <aliceryhl@google.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Benno Lossin" <lossin@kernel.org>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Danilo Krummrich" <dakr@kernel.org>,
"Drew Fustini" <drew@pdp7.com>, "Fu Wei" <wefu@redhat.com>,
"Gary Guo" <gary@garyguo.net>, "Guo Ren" <guoren@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Michal Wilczynski" <m.wilczynski@samsung.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Rob Herring" <robh@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
rust-for-linux@vger.kernel.org, linux-riscv@lists.infradead.org,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v5 8/9] riscv: dts: thead: Add PVT node
Date: Sat, 26 Jul 2025 09:56:43 -0700 [thread overview]
Message-ID: <aIUIy5ykeZi+BNXA@x1> (raw)
In-Reply-To: <175340623531.3513.5896709502242556676@lazor>
On Thu, Jul 24, 2025 at 06:17:15PM -0700, Stephen Boyd wrote:
> Quoting Michal Wilczynski (2025-06-23 11:08:56)
> > Add PVT DT node for thermal sensor.
> >
> > Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>
> > ---
> > arch/riscv/boot/dts/thead/th1520.dtsi | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi
> > index 26996422e1efe5d2dde68819c2cec1c3fa782a23..bef30780034e06b07aa29b27b0225ea891a4b531 100644
> > --- a/arch/riscv/boot/dts/thead/th1520.dtsi
> > +++ b/arch/riscv/boot/dts/thead/th1520.dtsi
> > @@ -669,6 +669,17 @@ padctrl_aosys: pinctrl@fffff4a000 {
> > thead,pad-group = <1>;
> > };
> >
> > + pvt: pvt@fffff4e000 {
>
> Node name should probably be 'thermal-sensor@fffff4e000' then.
Thanks for pointing this out. It does seem like 'pvt@' is unusual:
$ git grep -l 'thermal-sensor@' arch/*/boot/dts | wc -l
57
$ git grep -l 'pvt@' arch/*/boot/dts | wc -l
1
$ git grep -l 'thermal-sensor@' Documentation/devicetree/bindings/ | wc -l
14
$ git grep -l 'pvt@' Documentation/devicetree/bindings/ | wc -l
2
The 6.17 PR for dts has already happened, so I'll do a fix once I can
update my thead-dt-fixes branch to 6.17-rc1.
thanks,
drew
WARNING: multiple messages have this Message-ID (diff)
From: Drew Fustini <fustini@kernel.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: "Albert Ou" <aou@eecs.berkeley.edu>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Alexandre Ghiti" <alex@ghiti.fr>,
"Alice Ryhl" <aliceryhl@google.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Benno Lossin" <lossin@kernel.org>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Danilo Krummrich" <dakr@kernel.org>,
"Drew Fustini" <drew@pdp7.com>, "Fu Wei" <wefu@redhat.com>,
"Gary Guo" <gary@garyguo.net>, "Guo Ren" <guoren@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Michal Wilczynski" <m.wilczynski@samsung.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Rob Herring" <robh@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
rust-for-linux@vger.kernel.org, linux-riscv@lists.infradead.org,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v5 8/9] riscv: dts: thead: Add PVT node
Date: Sat, 26 Jul 2025 09:56:43 -0700 [thread overview]
Message-ID: <aIUIy5ykeZi+BNXA@x1> (raw)
In-Reply-To: <175340623531.3513.5896709502242556676@lazor>
On Thu, Jul 24, 2025 at 06:17:15PM -0700, Stephen Boyd wrote:
> Quoting Michal Wilczynski (2025-06-23 11:08:56)
> > Add PVT DT node for thermal sensor.
> >
> > Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>
> > ---
> > arch/riscv/boot/dts/thead/th1520.dtsi | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi
> > index 26996422e1efe5d2dde68819c2cec1c3fa782a23..bef30780034e06b07aa29b27b0225ea891a4b531 100644
> > --- a/arch/riscv/boot/dts/thead/th1520.dtsi
> > +++ b/arch/riscv/boot/dts/thead/th1520.dtsi
> > @@ -669,6 +669,17 @@ padctrl_aosys: pinctrl@fffff4a000 {
> > thead,pad-group = <1>;
> > };
> >
> > + pvt: pvt@fffff4e000 {
>
> Node name should probably be 'thermal-sensor@fffff4e000' then.
Thanks for pointing this out. It does seem like 'pvt@' is unusual:
$ git grep -l 'thermal-sensor@' arch/*/boot/dts | wc -l
57
$ git grep -l 'pvt@' arch/*/boot/dts | wc -l
1
$ git grep -l 'thermal-sensor@' Documentation/devicetree/bindings/ | wc -l
14
$ git grep -l 'pvt@' Documentation/devicetree/bindings/ | wc -l
2
The 6.17 PR for dts has already happened, so I'll do a fix once I can
update my thead-dt-fixes branch to 6.17-rc1.
thanks,
drew
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-07-26 16:56 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250623180857eucas1p2e3e9ddad89b5f055af801cb97dbfc7cc@eucas1p2.samsung.com>
2025-06-23 18:08 ` [PATCH v5 0/9] Rust Abstractions for PWM subsystem with TH1520 PWM driver Michal Wilczynski
2025-06-23 18:08 ` Michal Wilczynski
2025-06-23 18:08 ` [PATCH v5 1/9] rust: pwm: Add Kconfig and basic data structures Michal Wilczynski
2025-06-23 18:08 ` Michal Wilczynski
2025-06-27 15:10 ` Uwe Kleine-König
2025-06-27 15:10 ` Uwe Kleine-König
2025-06-27 15:37 ` Miguel Ojeda
2025-06-27 15:37 ` Miguel Ojeda
2025-06-28 14:38 ` Michal Wilczynski
2025-06-28 14:38 ` Michal Wilczynski
2025-06-28 19:47 ` Michal Wilczynski
2025-06-28 19:47 ` Michal Wilczynski
2025-06-29 10:29 ` Uwe Kleine-König
2025-06-29 10:29 ` Uwe Kleine-König
2025-07-01 8:24 ` Michal Wilczynski
2025-07-01 8:24 ` Michal Wilczynski
2025-07-01 13:47 ` Uwe Kleine-König
2025-07-01 13:47 ` Uwe Kleine-König
2025-06-29 9:23 ` Uwe Kleine-König
2025-06-29 9:23 ` Uwe Kleine-König
2025-07-01 8:52 ` Michal Wilczynski
2025-07-01 8:52 ` Michal Wilczynski
2025-06-23 18:08 ` [PATCH v5 2/9] rust: pwm: Add core 'Device' and 'Chip' object wrappers Michal Wilczynski
2025-06-23 18:08 ` Michal Wilczynski
2025-06-27 12:12 ` Danilo Krummrich
2025-06-27 12:12 ` Danilo Krummrich
2025-06-28 14:59 ` Michal Wilczynski
2025-06-28 14:59 ` Michal Wilczynski
2025-06-23 18:08 ` [PATCH v5 3/9] rust: pwm: Add driver operations trait and registration support Michal Wilczynski
2025-06-23 18:08 ` Michal Wilczynski
2025-06-27 18:51 ` Danilo Krummrich
2025-06-27 18:51 ` Danilo Krummrich
2025-06-23 18:08 ` [PATCH v5 4/9] pwm: Add Rust driver for T-HEAD TH1520 SoC Michal Wilczynski
2025-06-23 18:08 ` Michal Wilczynski
2025-06-27 15:28 ` Uwe Kleine-König
2025-06-27 15:28 ` Uwe Kleine-König
2025-06-28 18:14 ` Michal Wilczynski
2025-06-28 18:14 ` Michal Wilczynski
2025-06-29 9:08 ` Uwe Kleine-König
2025-06-29 9:08 ` Uwe Kleine-König
2025-06-23 18:08 ` [PATCH v5 5/9] clk: thead: Mark essential bus clocks as CLK_IGNORE_UNUSED Michal Wilczynski
2025-06-23 18:08 ` Michal Wilczynski
2025-06-23 18:08 ` [PATCH v5 6/9] dt-bindings: pwm: thead: Add T-HEAD TH1520 PWM controller Michal Wilczynski
2025-06-23 18:08 ` Michal Wilczynski
2025-06-23 18:08 ` [PATCH v5 7/9] riscv: dts: thead: Add PWM controller node Michal Wilczynski
2025-06-23 18:08 ` Michal Wilczynski
2025-06-23 18:08 ` [PATCH v5 8/9] riscv: dts: thead: Add PVT node Michal Wilczynski
2025-06-23 18:08 ` Michal Wilczynski
2025-06-30 20:27 ` Drew Fustini
2025-06-30 20:27 ` Drew Fustini
2025-07-25 1:17 ` Stephen Boyd
2025-07-25 1:17 ` Stephen Boyd
2025-07-26 16:56 ` Drew Fustini [this message]
2025-07-26 16:56 ` Drew Fustini
2025-06-23 18:08 ` [PATCH v5 9/9] riscv: dts: thead: Add PWM fan and thermal control Michal Wilczynski
2025-06-23 18:08 ` Michal Wilczynski
2025-06-27 8:25 ` [PATCH v5 0/9] Rust Abstractions for PWM subsystem with TH1520 PWM driver Michal Wilczynski
2025-06-27 8:25 ` Michal Wilczynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIUIy5ykeZi+BNXA@x1 \
--to=fustini@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=alex@ghiti.fr \
--cc=aliceryhl@google.com \
--cc=aou@eecs.berkeley.edu \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=conor+dt@kernel.org \
--cc=dakr@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=drew@pdp7.com \
--cc=gary@garyguo.net \
--cc=guoren@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lossin@kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=m.wilczynski@samsung.com \
--cc=mturquette@baylibre.com \
--cc=ojeda@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tmgross@umich.edu \
--cc=ukleinek@kernel.org \
--cc=wefu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.