From: Anthony PERARD <anthony@xenproject.org>
To: Penny Zheng <Penny.Zheng@amd.com>
Cc: xen-devel@lists.xenproject.org, ray.huang@amd.com,
Anthony PERARD <anthony.perard@vates.tech>,
Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v6 02/19] tools: drop "has_num" condition check for cppc mode
Date: Mon, 28 Jul 2025 14:53:31 +0200 [thread overview]
Message-ID: <aIdyy_8SLxwqgbmT@l14> (raw)
In-Reply-To: <20250711035106.2540522-3-Penny.Zheng@amd.com>
On Fri, Jul 11, 2025 at 11:50:49AM +0800, Penny Zheng wrote:
> In `xenpm get-cpufreq-para <cpuid>`, ->freq_num and ->cpu_num checking are
> tied together via variable "has_num", while ->freq_num only has non-zero value
> when cpufreq driver in legacy P-states mode.
>
> So we drop the "has_num" condition check, and mirror the ->gov_num check for
> both ->freq_num and ->cpu_num in xc_get_cpufreq_para().
>
> Signed-off-by: Penny Zheng <Penny.Zheng@amd.com>
Reviewed-by: Anthony PERARD <anthony.perard@vates.tech>
Thanks,
--
Anthony PERARD
next prev parent reply other threads:[~2025-07-28 12:53 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 3:50 [PATCH v6 00/19] amd-cppc CPU Performance Scaling Driver Penny Zheng
2025-07-11 3:50 ` [PATCH v6 01/19] xen/amd: introduce amd_process_freq() to get processor frequency Penny Zheng
2025-07-11 3:50 ` [PATCH v6 02/19] tools: drop "has_num" condition check for cppc mode Penny Zheng
2025-07-11 6:42 ` Jan Beulich
2025-07-28 12:53 ` Anthony PERARD [this message]
2025-07-11 3:50 ` [PATCH v6 03/19] tools: optimize cpufreq average freq print Penny Zheng
2025-07-16 14:43 ` Jan Beulich
2025-07-28 13:03 ` Anthony PERARD
2025-07-11 3:50 ` [PATCH v6 04/19] x86/cpufreq: continue looping other than -EBUSY or successful return Penny Zheng
2025-07-16 14:47 ` Jan Beulich
2025-07-11 3:50 ` [PATCH v6 05/19] xen/cpufreq: refactor cmdline "cpufreq=xxx" Penny Zheng
2025-07-16 15:00 ` Jan Beulich
2025-08-04 5:47 ` Penny, Zheng
2025-08-04 7:19 ` Jan Beulich
2025-08-04 6:04 ` Penny, Zheng
2025-08-04 7:17 ` Jan Beulich
2025-07-11 3:50 ` [PATCH v6 06/19] xen/cpufreq: make _PSD info common Penny Zheng
2025-07-16 15:07 ` Jan Beulich
2025-07-11 3:50 ` [PATCH v6 07/19] cpufreq: rename "xen_cppc_para" to "xen_get_cppc_para" Penny Zheng
2025-07-16 15:10 ` Jan Beulich
2025-07-28 13:09 ` Anthony PERARD
2025-07-11 3:50 ` [PATCH v6 08/19] xen/cpufreq: rename cppc preset name to "XEN_SYSCTL_CPPC_SET_PRESET_ONDEMAND" Penny Zheng
2025-07-16 15:18 ` Jan Beulich
2025-07-11 3:50 ` [PATCH v6 09/19] xen/cpufreq: neglect unsupported-mode request from DOM0 Penny Zheng
2025-07-16 15:19 ` Jan Beulich
2025-07-11 3:50 ` [PATCH v6 10/19] xen/cpufreq: introduce new sub-hypercall to propagate CPPC data Penny Zheng
2025-07-16 15:39 ` Jan Beulich
2025-08-04 6:47 ` Penny, Zheng
2025-08-04 7:25 ` Jan Beulich
2025-07-11 3:50 ` [PATCH v6 11/19] xen/x86: introduce "cpufreq=amd-cppc" xen cmdline and amd-cppc driver Penny Zheng
2025-07-16 15:59 ` Jan Beulich
2025-08-04 8:09 ` Penny, Zheng
2025-08-04 8:48 ` Jan Beulich
2025-08-05 6:31 ` Penny, Zheng
2025-08-05 7:42 ` Jan Beulich
2025-08-04 8:48 ` Jan Beulich
2025-07-11 3:50 ` [PATCH v6 12/19] xen/cpufreq: implement amd-cppc driver for CPPC in passive mode Penny Zheng
2025-07-17 12:55 ` Jan Beulich
2025-08-11 8:23 ` Penny, Zheng
2025-07-11 3:51 ` [PATCH v6 13/19] xen/x86: implement amd-cppc-epp driver for CPPC in active mode Penny Zheng
2025-07-17 13:35 ` Jan Beulich
2025-08-12 7:40 ` Penny, Zheng
2025-07-11 3:51 ` [PATCH v6 14/19] xen/cpufreq: get performance policy from governor set via xenpm Penny Zheng
2025-07-23 15:44 ` Jan Beulich
2025-07-11 3:51 ` [PATCH v6 15/19] tools/cpufreq: introduce helper to deal with CPPC-related parameters Penny Zheng
2025-07-23 15:56 ` Jan Beulich
2025-08-12 9:56 ` Penny, Zheng
2025-08-12 10:11 ` Penny, Zheng
2025-07-11 3:51 ` [PATCH v6 16/19] xen/cpufreq: introduce GET_CPUFREQ_CPPC sub-op Penny Zheng
2025-07-24 13:31 ` Jan Beulich
2025-07-24 14:17 ` Jason Andryuk
2025-07-24 14:47 ` Jan Beulich
2025-08-12 10:15 ` Penny, Zheng
2025-07-11 3:51 ` [PATCH v6 17/19] xen/cpufreq: introduce helper cpufreq_in_cppc_passive_mode() Penny Zheng
2025-07-24 13:57 ` Jan Beulich
2025-07-11 3:51 ` [PATCH v6 18/19] xen/cpufreq: bypass governor-related para for amd-cppc-epp Penny Zheng
2025-07-24 14:09 ` Jan Beulich
2025-08-13 6:57 ` Penny, Zheng
2025-07-24 22:36 ` Jason Andryuk
2025-07-11 3:51 ` [PATCH v6 19/19] xen/cpufreq: Adapt SET/GET_CPUFREQ_CPPC xen_sysctl_pm_op for amd-cppc driver Penny Zheng
2025-07-24 14:44 ` Jan Beulich
2025-08-14 3:13 ` Penny, Zheng
2025-08-14 6:40 ` Jan Beulich
2025-08-14 7:34 ` Penny, Zheng
2025-08-14 8:29 ` Jan Beulich
2025-08-14 8:32 ` Penny, Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIdyy_8SLxwqgbmT@l14 \
--to=anthony@xenproject.org \
--cc=Penny.Zheng@amd.com \
--cc=anthony.perard@vates.tech \
--cc=jgross@suse.com \
--cc=ray.huang@amd.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.