Re: [PATCH v6 06/19] xen/cpufreq: make _PSD info common

[Jan Beulich <jbeulich@suse.com>]

On 11.07.2025 05:50, Penny Zheng wrote:
> _PSD info, consisted of "shared_type" and "struct xen_psd_package", will not
> only be provided from px-specific "struct xen_processor_performance", but also
> in CPPC data.
> 
> Two new helper functions are introduced to deal with _PSD. They will later be
> re-used for handling the same data for CPPC.
> In the meantime, the following style corrections get applied at the same time:
> - add extra space before and after bracket of if()
> - remove redundant parenthesis
> - no need to put brace for printk() at a seperate line
> 
> Signed-off-by: Penny Zheng <Penny.Zheng@amd.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>
with one further remark:

> --- a/xen/drivers/cpufreq/cpufreq.c
> +++ b/xen/drivers/cpufreq/cpufreq.c
> @@ -226,9 +226,29 @@ int cpufreq_limit_change(unsigned int cpu)
>      return __cpufreq_set_policy(data, &policy);
>  }
>  
> -int cpufreq_add_cpu(unsigned int cpu)
> +static int get_psd_info(unsigned int cpu, uint32_t *shared_type,

Here any below I question the need to use a fixed-width type. "unsigned int"
will do fine here, I expect, and that's what ./CODING_STYLE also mandates in
such cases. I may take the liberty and change that while committing.

Jan