From: Andi Shyti <andi.shyti@linux.intel.com>
To: Krzysztof Karas <krzysztof.karas@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
Matthew Auld <matthew.auld@intel.com>,
Andi Shyti <andi.shyti@linux.intel.com>,
Sebastian Brzezinka <sebastian.brzezinka@intel.com>
Subject: Re: [PATCH v2 1/2] drm/i915/selftests: Do not overwrite error code after intel_context_migrate_clear() call
Date: Wed, 30 Jul 2025 13:07:57 +0200 [thread overview]
Message-ID: <aIn9Dc02LmU5dgFE@ashyti-mobl2.lan> (raw)
In-Reply-To: <c0348e052bcb2870acdc15d60f5389fbdf4ef886.1753859971.git.krzysztof.karas@intel.com>
Hi Krzysztof,
On Wed, Jul 30, 2025 at 07:39:23AM +0000, Krzysztof Karas wrote:
> Currently this function's error code is stored in err variable,
> which, if a i915_request is present, will be immediately
> overwritten by return from dma_resv_reserve_fences(). Call DMA
> functions only if intel_context_migrate_clear() succeeded.
>
> Suggested-by: Matthew Auld <matthew.auld@intel.com>
> Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Andi
next prev parent reply other threads:[~2025-07-30 11:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 7:38 [PATCH v2 0/2] drm/i915/selftests: Miscellaneous improvements in gem mman migration tests Krzysztof Karas
2025-07-30 7:39 ` [PATCH v2 1/2] drm/i915/selftests: Do not overwrite error code after intel_context_migrate_clear() call Krzysztof Karas
2025-07-30 11:07 ` Andi Shyti [this message]
2025-07-30 11:18 ` Sebastian Brzezinka
2025-07-30 7:40 ` [PATCH v2 2/2] drm/i915/selftests: Do not leak vm_area_struct on early return Krzysztof Karas
2025-07-31 11:50 ` Andi Shyti
2025-08-01 10:55 ` Krzysztof Karas
2025-07-30 12:39 ` ✓ i915.CI.BAT: success for drm/i915/selftests: Miscellaneous improvements in gem mman migration tests (rev2) Patchwork
2025-08-07 14:20 ` ✓ i915.CI.BAT: success for drm/i915/selftests: Miscellaneous improvements in gem mman migration tests (rev3) Patchwork
2025-08-07 20:18 ` ✓ i915.CI.Full: " Patchwork
2025-08-09 0:12 ` [PATCH v2 0/2] drm/i915/selftests: Miscellaneous improvements in gem mman migration tests Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIn9Dc02LmU5dgFE@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=krzysztof.karas@intel.com \
--cc=matthew.auld@intel.com \
--cc=sebastian.brzezinka@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.