[PATCH 1/1] Kconfig: typo restict

[PATCH 1/1] Kconfig: typo restict

[Heinrich Schuchardt]

%s/restict/restrict/

SPL and TPL have separate options (plural).

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Kconfig b/Kconfig
index c883f115459..22636da6444 100644
--- a/Kconfig
+++ b/Kconfig
@@ -552,7 +552,7 @@ config BOARD_SIZE_LIMIT
 	  Maximum size of the U-Boot image. When defined, the build system
 	  checks that the actual size does not exceed it.  This does not
 	  include SPL nor TPL, on platforms that use that functionality, they
-	  have a separate option to restict size.
+	  have separate options to restrict size.
 
 config SYS_CUSTOM_LDSCRIPT
 	bool "Use a custom location for the U-Boot linker script"
-- 
2.50.0

Re: [PATCH 1/1] Kconfig: typo restict

[Quentin Schulz]

Hi Heinrich,

On 7/30/25 2:54 PM, Heinrich Schuchardt wrote:
> %s/restict/restrict/
> 
> SPL and TPL have separate options (plural).
> 

Looks good to me.

Wondering if we couldn't add which options are to be used for TPL/SPL 
Would that be TPL_MAX_SIZE and SPL_MAX_SIZE maybe?

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks!
Quentin

Re: [PATCH 1/1] Kconfig: typo restict

[Heinrich Schuchardt]

On 30.07.25 14:58, Quentin Schulz wrote:
> Hi Heinrich,
> 
> On 7/30/25 2:54 PM, Heinrich Schuchardt wrote:
>> %s/restict/restrict/
>>
>> SPL and TPL have separate options (plural).
>>
> 
> Looks good to me.
> 
> Wondering if we couldn't add which options are to be used for TPL/SPL 
> Would that be TPL_MAX_SIZE and SPL_MAX_SIZE maybe?
> 
> Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
> 
> Thanks!
> Quentin

Thanks for reviewing.

With VPL_SIZE_LIMIT and a patch for UBOOT_WITH_SPL_SIZE_LIMIT pending 
things get even more involved.

We should think about a documentation page on size limits:

CONFIG_HAS_BOARD_SIZE_LIMIT
CONFIG_BOARD_SIZE_LIMIT
CONFIG_SPL_SIZE_LIMIT
CONFIG_SPL_SIZE_LIMIT_SUBTRACT_GD
CONFIG_SPL_SIZE_LIMIT_SUBTRACT_MALLOC
CONFIG_SPL_SIZE_LIMIT_PROVIDE_STACK
CONFIG_TPL_SIZE_LIMIT
CONFIG_VPL_SIZE_LIMIT

Best regards

Heinrich

Re: [PATCH 1/1] Kconfig: typo restict

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]

On Wed, Jul 30, 2025 at 03:05:59PM +0200, Heinrich Schuchardt wrote:
> On 30.07.25 14:58, Quentin Schulz wrote:
> > Hi Heinrich,
> > 
> > On 7/30/25 2:54 PM, Heinrich Schuchardt wrote:
> > > %s/restict/restrict/
> > > 
> > > SPL and TPL have separate options (plural).
> > > 
> > 
> > Looks good to me.
> > 
> > Wondering if we couldn't add which options are to be used for TPL/SPL
> > Would that be TPL_MAX_SIZE and SPL_MAX_SIZE maybe?
> > 
> > Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
> > 
> > Thanks!
> > Quentin
> 
> Thanks for reviewing.
> 
> With VPL_SIZE_LIMIT and a patch for UBOOT_WITH_SPL_SIZE_LIMIT pending things
> get even more involved.
> 
> We should think about a documentation page on size limits:
> 
> CONFIG_HAS_BOARD_SIZE_LIMIT
> CONFIG_BOARD_SIZE_LIMIT
> CONFIG_SPL_SIZE_LIMIT
> CONFIG_SPL_SIZE_LIMIT_SUBTRACT_GD
> CONFIG_SPL_SIZE_LIMIT_SUBTRACT_MALLOC
> CONFIG_SPL_SIZE_LIMIT_PROVIDE_STACK
> CONFIG_TPL_SIZE_LIMIT
> CONFIG_VPL_SIZE_LIMIT

As Philip has hit adding a new MIPS board and need for specific size
check, yes, better documentation (and then perhaps adjusting and
cleanup) of our various size checks is much needed and would be
appreciated.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 1/1] Kconfig: typo restict

[Philip Oberfichtner]

> > With VPL_SIZE_LIMIT and a patch for UBOOT_WITH_SPL_SIZE_LIMIT pending things
> > get even more involved.
> > 
> > We should think about a documentation page on size limits:
> > 
> > CONFIG_HAS_BOARD_SIZE_LIMIT
> > CONFIG_BOARD_SIZE_LIMIT
> > CONFIG_SPL_SIZE_LIMIT
> > CONFIG_SPL_SIZE_LIMIT_SUBTRACT_GD
> > CONFIG_SPL_SIZE_LIMIT_SUBTRACT_MALLOC
> > CONFIG_SPL_SIZE_LIMIT_PROVIDE_STACK
> > CONFIG_TPL_SIZE_LIMIT
> > CONFIG_VPL_SIZE_LIMIT
> 
> As Philip has hit adding a new MIPS board and need for specific size
> check, yes, better documentation (and then perhaps adjusting and
> cleanup) of our various size checks is much needed and would be
> appreciated.

Hi,

Just adding the reference to my current proposal on how to simplify the
Makefile:

https://lore.kernel.org/u-boot/20250730123833.249923-2-pro@denx.de/T/#u

Best regards,
Philip


> 
> -- 
> Tom



-- 
=====================================================================
DENX Software Engineering GmbH,
Managing Director: Johanna Denk, Tabea Lutz
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
=====================================================================

Re: [PATCH 1/1] Kconfig: typo restict

[Philip Oberfichtner]

On Wed, Jul 30, 2025 at 04:50:15PM +0200, Philip Oberfichtner wrote:
> > > With VPL_SIZE_LIMIT and a patch for UBOOT_WITH_SPL_SIZE_LIMIT pending things
> > > get even more involved.
> > > 
> > > We should think about a documentation page on size limits:
> > > 
> > > CONFIG_HAS_BOARD_SIZE_LIMIT
> > > CONFIG_BOARD_SIZE_LIMIT
> > > CONFIG_SPL_SIZE_LIMIT
> > > CONFIG_SPL_SIZE_LIMIT_SUBTRACT_GD
> > > CONFIG_SPL_SIZE_LIMIT_SUBTRACT_MALLOC
> > > CONFIG_SPL_SIZE_LIMIT_PROVIDE_STACK
> > > CONFIG_TPL_SIZE_LIMIT
> > > CONFIG_VPL_SIZE_LIMIT
> > 

Hi again,

> > As Philip has hit adding a new MIPS board and need for specific size
> > check, yes, better documentation (and then perhaps adjusting and
> > cleanup) of our various size checks is much needed and would be
> > appreciated.

I just posted an RFC on how we might want to start cleaning up the
current situation:

https://patchwork.ozlabs.org/project/uboot/list/?series=467406

Best,
Philip

Re: [PATCH 1/1] Kconfig: typo restict

[Tom Rini]

On Wed, 30 Jul 2025 14:54:27 +0200, Heinrich Schuchardt wrote:

> %s/restict/restrict/
> 
> SPL and TPL have separate options (plural).
> 
> 

Applied to u-boot/master, thanks!

[1/1] Kconfig: typo restict
      commit: c03d7a48018c8caefefc9b2cbd46f393798eece3
-- 
Tom