Re: [PATCH v2] qcom_defconfig: Add VID/PID to represent fastboot device

[Sumit Garg <sumit.garg@kernel.org>]

On Wed, Aug 13, 2025 at 03:50:21PM +0200, Casey Connolly wrote:
> Hi Sumit,
> 
> On 24/07/2025 13:19, Sumit Garg wrote:
> > From: Sumit Garg <sumit.garg@oss.qualcomm.com>
> > 
> > Currently fastboot mode is enumerated as VID/PID: 0000:0000 which is
> > not appropriate. On Qcom platforms, fastboot mode is rather enumerated
> > as VID/PID: 18d1:d00d in ABL or from fastboot.efi app. So lets use the
> > same VID/PID pair in U-Boot to represent fastboot mode.
> 
> Since we have different defconfigs going on for Qualcomm, I think it
> makes more sense to set defaults in drivers/usb/gadget/Kconfig like
> rockchip does, then we don't need to update all the defconfigs and we
> can just override them if desired. Would you mind respinning this? Sorry
> this is coming so late...

No worries, Kconfig option sounds reasonable to me. I can spin up a v3
with that.

-Sumit

> 
> Kind regards,>
> > Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
> > ---
> > 
> > Changes in v2:
> > - Rebased to tip of master since v1 didn't apply cleanly there.
> > 
> >  configs/qcom_defconfig | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/configs/qcom_defconfig b/configs/qcom_defconfig
> > index b9ba7a677d9..4e24a43b888 100644
> > --- a/configs/qcom_defconfig
> > +++ b/configs/qcom_defconfig
> > @@ -140,6 +140,8 @@ CONFIG_USB_XHCI_DWC3=y
> >  CONFIG_USB_DWC3=y
> >  CONFIG_USB_DWC3_GENERIC=y
> >  CONFIG_USB_GADGET=y
> > +CONFIG_USB_GADGET_VENDOR_NUM=0x18d1
> > +CONFIG_USB_GADGET_PRODUCT_NUM=0xd00d
> >  CONFIG_USB_FUNCTION_MASS_STORAGE=y
> >  CONFIG_UFS=y
> >  CONFIG_QCOM_UFS=y
> 
> -- 
> // Casey (she/her)
>