* [PATCH v2] qcom_defconfig: Add VID/PID to represent fastboot device
@ 2025-07-24 11:19 Sumit Garg
2025-07-24 11:42 ` neil.armstrong
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Sumit Garg @ 2025-07-24 11:19 UTC (permalink / raw)
To: u-boot-qcom
Cc: casey.connolly, neil.armstrong, trini, dmitry.baryshkov, u-boot,
Sumit Garg
From: Sumit Garg <sumit.garg@oss.qualcomm.com>
Currently fastboot mode is enumerated as VID/PID: 0000:0000 which is
not appropriate. On Qcom platforms, fastboot mode is rather enumerated
as VID/PID: 18d1:d00d in ABL or from fastboot.efi app. So lets use the
same VID/PID pair in U-Boot to represent fastboot mode.
Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
---
Changes in v2:
- Rebased to tip of master since v1 didn't apply cleanly there.
configs/qcom_defconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/configs/qcom_defconfig b/configs/qcom_defconfig
index b9ba7a677d9..4e24a43b888 100644
--- a/configs/qcom_defconfig
+++ b/configs/qcom_defconfig
@@ -140,6 +140,8 @@ CONFIG_USB_XHCI_DWC3=y
CONFIG_USB_DWC3=y
CONFIG_USB_DWC3_GENERIC=y
CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_VENDOR_NUM=0x18d1
+CONFIG_USB_GADGET_PRODUCT_NUM=0xd00d
CONFIG_USB_FUNCTION_MASS_STORAGE=y
CONFIG_UFS=y
CONFIG_QCOM_UFS=y
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] qcom_defconfig: Add VID/PID to represent fastboot device
2025-07-24 11:19 [PATCH v2] qcom_defconfig: Add VID/PID to represent fastboot device Sumit Garg
@ 2025-07-24 11:42 ` neil.armstrong
2025-07-25 13:20 ` Casey Connolly
2025-08-13 13:50 ` Casey Connolly
2 siblings, 0 replies; 5+ messages in thread
From: neil.armstrong @ 2025-07-24 11:42 UTC (permalink / raw)
To: Sumit Garg, u-boot-qcom
Cc: casey.connolly, trini, dmitry.baryshkov, u-boot, Sumit Garg
On 24/07/2025 13:19, Sumit Garg wrote:
> From: Sumit Garg <sumit.garg@oss.qualcomm.com>
>
> Currently fastboot mode is enumerated as VID/PID: 0000:0000 which is
> not appropriate. On Qcom platforms, fastboot mode is rather enumerated
> as VID/PID: 18d1:d00d in ABL or from fastboot.efi app. So lets use the
> same VID/PID pair in U-Boot to represent fastboot mode.
>
> Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
> ---
>
> Changes in v2:
> - Rebased to tip of master since v1 didn't apply cleanly there.
>
> configs/qcom_defconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/configs/qcom_defconfig b/configs/qcom_defconfig
> index b9ba7a677d9..4e24a43b888 100644
> --- a/configs/qcom_defconfig
> +++ b/configs/qcom_defconfig
> @@ -140,6 +140,8 @@ CONFIG_USB_XHCI_DWC3=y
> CONFIG_USB_DWC3=y
> CONFIG_USB_DWC3_GENERIC=y
> CONFIG_USB_GADGET=y
> +CONFIG_USB_GADGET_VENDOR_NUM=0x18d1
> +CONFIG_USB_GADGET_PRODUCT_NUM=0xd00d
> CONFIG_USB_FUNCTION_MASS_STORAGE=y
> CONFIG_UFS=y
> CONFIG_QCOM_UFS=y
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] qcom_defconfig: Add VID/PID to represent fastboot device
2025-07-24 11:19 [PATCH v2] qcom_defconfig: Add VID/PID to represent fastboot device Sumit Garg
2025-07-24 11:42 ` neil.armstrong
@ 2025-07-25 13:20 ` Casey Connolly
2025-08-13 13:50 ` Casey Connolly
2 siblings, 0 replies; 5+ messages in thread
From: Casey Connolly @ 2025-07-25 13:20 UTC (permalink / raw)
To: Sumit Garg, u-boot-qcom
Cc: neil.armstrong, trini, dmitry.baryshkov, u-boot, Sumit Garg
On 24/07/2025 13:19, Sumit Garg wrote:
> From: Sumit Garg <sumit.garg@oss.qualcomm.com>
>
> Currently fastboot mode is enumerated as VID/PID: 0000:0000 which is
> not appropriate. On Qcom platforms, fastboot mode is rather enumerated
> as VID/PID: 18d1:d00d in ABL or from fastboot.efi app. So lets use the
> same VID/PID pair in U-Boot to represent fastboot mode.
>
> Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
Reviewed-by: Casey Connolly <casey.connolly@linaro.org>
> ---
>
> Changes in v2:
> - Rebased to tip of master since v1 didn't apply cleanly there.
>
> configs/qcom_defconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/configs/qcom_defconfig b/configs/qcom_defconfig
> index b9ba7a677d9..4e24a43b888 100644
> --- a/configs/qcom_defconfig
> +++ b/configs/qcom_defconfig
> @@ -140,6 +140,8 @@ CONFIG_USB_XHCI_DWC3=y
> CONFIG_USB_DWC3=y
> CONFIG_USB_DWC3_GENERIC=y
> CONFIG_USB_GADGET=y
> +CONFIG_USB_GADGET_VENDOR_NUM=0x18d1
> +CONFIG_USB_GADGET_PRODUCT_NUM=0xd00d
> CONFIG_USB_FUNCTION_MASS_STORAGE=y
> CONFIG_UFS=y
> CONFIG_QCOM_UFS=y
--
// Casey (she/her)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] qcom_defconfig: Add VID/PID to represent fastboot device
2025-07-24 11:19 [PATCH v2] qcom_defconfig: Add VID/PID to represent fastboot device Sumit Garg
2025-07-24 11:42 ` neil.armstrong
2025-07-25 13:20 ` Casey Connolly
@ 2025-08-13 13:50 ` Casey Connolly
2025-08-14 5:48 ` Sumit Garg
2 siblings, 1 reply; 5+ messages in thread
From: Casey Connolly @ 2025-08-13 13:50 UTC (permalink / raw)
To: Sumit Garg, u-boot-qcom
Cc: neil.armstrong, trini, dmitry.baryshkov, u-boot, Sumit Garg
Hi Sumit,
On 24/07/2025 13:19, Sumit Garg wrote:
> From: Sumit Garg <sumit.garg@oss.qualcomm.com>
>
> Currently fastboot mode is enumerated as VID/PID: 0000:0000 which is
> not appropriate. On Qcom platforms, fastboot mode is rather enumerated
> as VID/PID: 18d1:d00d in ABL or from fastboot.efi app. So lets use the
> same VID/PID pair in U-Boot to represent fastboot mode.
Since we have different defconfigs going on for Qualcomm, I think it
makes more sense to set defaults in drivers/usb/gadget/Kconfig like
rockchip does, then we don't need to update all the defconfigs and we
can just override them if desired. Would you mind respinning this? Sorry
this is coming so late...
Kind regards,>
> Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
> ---
>
> Changes in v2:
> - Rebased to tip of master since v1 didn't apply cleanly there.
>
> configs/qcom_defconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/configs/qcom_defconfig b/configs/qcom_defconfig
> index b9ba7a677d9..4e24a43b888 100644
> --- a/configs/qcom_defconfig
> +++ b/configs/qcom_defconfig
> @@ -140,6 +140,8 @@ CONFIG_USB_XHCI_DWC3=y
> CONFIG_USB_DWC3=y
> CONFIG_USB_DWC3_GENERIC=y
> CONFIG_USB_GADGET=y
> +CONFIG_USB_GADGET_VENDOR_NUM=0x18d1
> +CONFIG_USB_GADGET_PRODUCT_NUM=0xd00d
> CONFIG_USB_FUNCTION_MASS_STORAGE=y
> CONFIG_UFS=y
> CONFIG_QCOM_UFS=y
--
// Casey (she/her)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] qcom_defconfig: Add VID/PID to represent fastboot device
2025-08-13 13:50 ` Casey Connolly
@ 2025-08-14 5:48 ` Sumit Garg
0 siblings, 0 replies; 5+ messages in thread
From: Sumit Garg @ 2025-08-14 5:48 UTC (permalink / raw)
To: Casey Connolly
Cc: u-boot-qcom, neil.armstrong, trini, dmitry.baryshkov, u-boot,
Sumit Garg
On Wed, Aug 13, 2025 at 03:50:21PM +0200, Casey Connolly wrote:
> Hi Sumit,
>
> On 24/07/2025 13:19, Sumit Garg wrote:
> > From: Sumit Garg <sumit.garg@oss.qualcomm.com>
> >
> > Currently fastboot mode is enumerated as VID/PID: 0000:0000 which is
> > not appropriate. On Qcom platforms, fastboot mode is rather enumerated
> > as VID/PID: 18d1:d00d in ABL or from fastboot.efi app. So lets use the
> > same VID/PID pair in U-Boot to represent fastboot mode.
>
> Since we have different defconfigs going on for Qualcomm, I think it
> makes more sense to set defaults in drivers/usb/gadget/Kconfig like
> rockchip does, then we don't need to update all the defconfigs and we
> can just override them if desired. Would you mind respinning this? Sorry
> this is coming so late...
No worries, Kconfig option sounds reasonable to me. I can spin up a v3
with that.
-Sumit
>
> Kind regards,>
> > Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
> > ---
> >
> > Changes in v2:
> > - Rebased to tip of master since v1 didn't apply cleanly there.
> >
> > configs/qcom_defconfig | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/configs/qcom_defconfig b/configs/qcom_defconfig
> > index b9ba7a677d9..4e24a43b888 100644
> > --- a/configs/qcom_defconfig
> > +++ b/configs/qcom_defconfig
> > @@ -140,6 +140,8 @@ CONFIG_USB_XHCI_DWC3=y
> > CONFIG_USB_DWC3=y
> > CONFIG_USB_DWC3_GENERIC=y
> > CONFIG_USB_GADGET=y
> > +CONFIG_USB_GADGET_VENDOR_NUM=0x18d1
> > +CONFIG_USB_GADGET_PRODUCT_NUM=0xd00d
> > CONFIG_USB_FUNCTION_MASS_STORAGE=y
> > CONFIG_UFS=y
> > CONFIG_QCOM_UFS=y
>
> --
> // Casey (she/her)
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-08-14 5:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-24 11:19 [PATCH v2] qcom_defconfig: Add VID/PID to represent fastboot device Sumit Garg
2025-07-24 11:42 ` neil.armstrong
2025-07-25 13:20 ` Casey Connolly
2025-08-13 13:50 ` Casey Connolly
2025-08-14 5:48 ` Sumit Garg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.