All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sunil V L <sunilvl@ventanamicro.com>
To: XianLiang Huang <huangxianliang@lanxincomputing.com>
Cc: ajones@ventanamicro.com, alex@ghiti.fr, anup@brainfault.org,
	apatel@ventanamicro.com, atishp@rivosinc.com,
	iommu@lists.linux.dev, joro@8bytes.org, lenb@kernel.org,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org, palmer@dabbelt.com,
	paul.walmsley@sifive.com, rafael@kernel.org,
	robin.murphy@arm.com, tjeznach@rivosinc.com, will@kernel.org
Subject: Re: [PATCH v5 1/3] ACPI: RISC-V: Add support for RIMT
Date: Fri, 15 Aug 2025 16:21:16 +0530	[thread overview]
Message-ID: <aJ8RJCFM8p_GrFXk@sunil-laptop> (raw)
In-Reply-To: <20250815075541.29941-1-huangxianliang@lanxincomputing.com>

On Fri, Aug 15, 2025 at 03:55:41PM +0800, XianLiang Huang wrote:
> Hi Sunil,
> 
> On Wed, 16 Jul 2025 16:10:57 +0530, Sunil V L wrote:
> > +	parent = ACPI_ADD_PTR(struct acpi_rimt_node, rimt_table, map->dest_offset);
> > +
> > +	if (node->type == ACPI_RIMT_NODE_TYPE_PLAT_DEVICE ||
> > +	    node->type == ACPI_RIMT_NODE_TYPE_PCIE_ROOT_COMPLEX) {
> > +		*id_out = map->dest_offset;
> > +		return parent;
> > +	}
> 
> Why do we assign dest_offset to id_out? The dest_offset is the iommu offset, not
> a valid deviceid required for platform device in rimt_plat_iommu_map?
> 
Good catch!. Thanks!. It should be dest_id_base. Let me fix it in next
revision.

Thanks!
Sunil

WARNING: multiple messages have this Message-ID (diff)
From: Sunil V L <sunilvl@ventanamicro.com>
To: XianLiang Huang <huangxianliang@lanxincomputing.com>
Cc: ajones@ventanamicro.com, alex@ghiti.fr, anup@brainfault.org,
	apatel@ventanamicro.com, atishp@rivosinc.com,
	iommu@lists.linux.dev, joro@8bytes.org, lenb@kernel.org,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org, palmer@dabbelt.com,
	paul.walmsley@sifive.com, rafael@kernel.org,
	robin.murphy@arm.com, tjeznach@rivosinc.com, will@kernel.org
Subject: Re: [PATCH v5 1/3] ACPI: RISC-V: Add support for RIMT
Date: Fri, 15 Aug 2025 16:21:16 +0530	[thread overview]
Message-ID: <aJ8RJCFM8p_GrFXk@sunil-laptop> (raw)
In-Reply-To: <20250815075541.29941-1-huangxianliang@lanxincomputing.com>

On Fri, Aug 15, 2025 at 03:55:41PM +0800, XianLiang Huang wrote:
> Hi Sunil,
> 
> On Wed, 16 Jul 2025 16:10:57 +0530, Sunil V L wrote:
> > +	parent = ACPI_ADD_PTR(struct acpi_rimt_node, rimt_table, map->dest_offset);
> > +
> > +	if (node->type == ACPI_RIMT_NODE_TYPE_PLAT_DEVICE ||
> > +	    node->type == ACPI_RIMT_NODE_TYPE_PCIE_ROOT_COMPLEX) {
> > +		*id_out = map->dest_offset;
> > +		return parent;
> > +	}
> 
> Why do we assign dest_offset to id_out? The dest_offset is the iommu offset, not
> a valid deviceid required for platform device in rimt_plat_iommu_map?
> 
Good catch!. Thanks!. It should be dest_id_base. Let me fix it in next
revision.

Thanks!
Sunil

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2025-08-15 10:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-16 10:40 [PATCH v5 0/3] RISC-V: Add ACPI support for IOMMU Sunil V L
2025-07-16 10:40 ` Sunil V L
2025-07-16 10:40 ` [PATCH v5 1/3] ACPI: RISC-V: Add support for RIMT Sunil V L
2025-07-16 10:40   ` Sunil V L
2025-08-15  7:55   ` XianLiang Huang
2025-08-15  7:55     ` XianLiang Huang
2025-08-15 10:51     ` Sunil V L [this message]
2025-08-15 10:51       ` Sunil V L
2025-07-16 10:40 ` [PATCH v5 2/3] ACPI: scan: Add support for RISC-V in acpi_iommu_configure_id() Sunil V L
2025-07-16 10:40   ` Sunil V L
2025-07-16 10:40 ` [PATCH v5 3/3] iommu/riscv: Add ACPI support Sunil V L
2025-07-16 10:40   ` Sunil V L
2025-07-16 15:27 ` [PATCH v5 0/3] RISC-V: Add ACPI support for IOMMU Palmer Dabbelt
2025-07-16 15:27   ` Palmer Dabbelt
2025-08-06 17:15 ` patchwork-bot+linux-riscv
2025-08-06 17:15   ` patchwork-bot+linux-riscv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aJ8RJCFM8p_GrFXk@sunil-laptop \
    --to=sunilvl@ventanamicro.com \
    --cc=ajones@ventanamicro.com \
    --cc=alex@ghiti.fr \
    --cc=anup@brainfault.org \
    --cc=apatel@ventanamicro.com \
    --cc=atishp@rivosinc.com \
    --cc=huangxianliang@lanxincomputing.com \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=rafael@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=tjeznach@rivosinc.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.