All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86/CPU: correct reset_cpuinfo() comment
@ 2025-07-23 12:00 Jan Beulich
  2025-08-04  9:57 ` Roger Pau Monné
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2025-07-23 12:00 UTC (permalink / raw)
  To: xen-devel@lists.xenproject.org; +Cc: Andrew Cooper, Roger Pau Monné

Part of it stated the opposite of what actual behavior is.

Fixes: 7126b7f806d5 ("x86/CPU: re-work populating of cpu_data[]")
Reported-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/include/asm/cpufeature.h
+++ b/xen/arch/x86/include/asm/cpufeature.h
@@ -91,8 +91,8 @@ struct cpuinfo_x86 {
 
 /*
  * @keep_basic set to true retains data firmly assumed to be symmetric
- * across all CPUs.  With it set to false only CPU_DATA_INIT() will be
- * invoked on the passed structure.
+ * across all CPUs.  Only CPU_DATA_INIT() will be invoked in that case
+ * on the passed structure.
  */
 void reset_cpuinfo(struct cpuinfo_x86 *c, bool keep_basic);
 


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] x86/CPU: correct reset_cpuinfo() comment
  2025-07-23 12:00 [PATCH] x86/CPU: correct reset_cpuinfo() comment Jan Beulich
@ 2025-08-04  9:57 ` Roger Pau Monné
  0 siblings, 0 replies; 2+ messages in thread
From: Roger Pau Monné @ 2025-08-04  9:57 UTC (permalink / raw)
  To: Jan Beulich; +Cc: xen-devel@lists.xenproject.org, Andrew Cooper

On Wed, Jul 23, 2025 at 02:00:55PM +0200, Jan Beulich wrote:
> Part of it stated the opposite of what actual behavior is.
> 
> Fixes: 7126b7f806d5 ("x86/CPU: re-work populating of cpu_data[]")
> Reported-by: Juergen Gross <jgross@suse.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-08-04  9:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-23 12:00 [PATCH] x86/CPU: correct reset_cpuinfo() comment Jan Beulich
2025-08-04  9:57 ` Roger Pau Monné

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.