From: Jorge Ramirez <jorge.ramirez@oss.qualcomm.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>,
quic_dikshita@quicinc.com, quic_vgarodia@quicinc.com,
konradybcio@kernel.org, krzk+dt@kernel.org, mchehab@kernel.org,
conor+dt@kernel.org, andersson@kernel.org,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 2/7] media: venus: Define minimum valid firmware version
Date: Tue, 5 Aug 2025 12:02:29 +0200 [thread overview]
Message-ID: <aJHWtaLung8Ubdh8@trex> (raw)
In-Reply-To: <a5c292ec-e59b-49f0-9681-a990128cbdfe@linaro.org>
On 05/08/25 09:29:55, Bryan O'Donoghue wrote:
> On 05/08/2025 07:44, Jorge Ramirez-Ortiz wrote:
> > + if (!is_fw_rev_or_newer(core, ver->major, ver->minor, ver->rev))
> > + return -EINVAL;
> > +
>
> This is the sort of error case that deserves a kernel log.
>
> dev_err(dev, "Firmware version %d.%d < minimum version %d.%d\n, etc);
>
> If I were to try booting venus with an old/unsupported I wouldn't know why
> the probe was failing.
ok
>
> ---
> bod
next prev parent reply other threads:[~2025-08-05 10:02 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-05 6:44 [PATCH v8 0/7] media: venus: Add QCM2290 support with AR50_LITE core Jorge Ramirez-Ortiz
2025-08-05 6:44 ` [PATCH v8 1/7] media: dt-bindings: venus: Add qcm2290 dt schema Jorge Ramirez-Ortiz
2025-08-05 6:44 ` [PATCH v8 2/7] media: venus: Define minimum valid firmware version Jorge Ramirez-Ortiz
2025-08-05 8:29 ` Bryan O'Donoghue
2025-08-05 10:02 ` Jorge Ramirez [this message]
2025-08-05 6:44 ` [PATCH v8 3/7] media: venus: Add support for AR50_LITE video core Jorge Ramirez-Ortiz
2025-08-05 9:07 ` Bryan O'Donoghue
2025-08-05 10:17 ` Jorge Ramirez
2025-08-05 6:44 ` [PATCH v8 4/7] media: venus: hfi_plat_v4: Add capabilities for the 4XX lite core Jorge Ramirez-Ortiz
2025-08-05 6:44 ` [PATCH v8 5/7] media: venus: core: Add qcm2290 DT compatible and resource data Jorge Ramirez-Ortiz
2025-08-05 10:04 ` Dmitry Baryshkov
2025-08-05 10:44 ` Jorge Ramirez
2025-08-05 11:27 ` Jorge Ramirez
2025-08-06 1:37 ` Dmitry Baryshkov
2025-08-06 8:04 ` Jorge Ramirez
2025-08-06 9:01 ` Konrad Dybcio
2025-08-06 13:07 ` Jorge Ramirez
2025-08-07 11:06 ` Vikash Garodia
2025-08-07 13:52 ` Jorge Ramirez
2025-08-07 16:35 ` Vikash Garodia
2025-08-07 17:05 ` Jorge Ramirez
2025-08-09 8:18 ` Dmitry Baryshkov
2025-08-09 9:09 ` Jorge Ramirez
2025-08-09 9:22 ` Dmitry Baryshkov
2025-08-09 11:43 ` Jorge Ramirez
2025-08-07 11:52 ` Dmitry Baryshkov
2025-08-07 13:50 ` Jorge Ramirez
2025-08-07 6:35 ` Bryan O'Donoghue
2025-08-07 6:48 ` Jorge Ramirez
2025-08-07 10:11 ` Bryan O'Donoghue
2025-08-07 10:17 ` Jorge Ramirez
2025-08-07 11:53 ` Dmitry Baryshkov
2025-08-05 6:44 ` [PATCH v8 6/7] arm64: dts: qcom: qcm2290: Add Venus video node Jorge Ramirez-Ortiz
2025-08-05 9:15 ` Bryan O'Donoghue
2025-08-05 6:44 ` [PATCH v8 7/7] arm64: dts: qcom: qrb2210-rb1: Enable Venus Jorge Ramirez-Ortiz
2025-08-05 9:16 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJHWtaLung8Ubdh8@trex \
--to=jorge.ramirez@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_dikshita@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.