Re: [PATCH v8 5/7] media: venus: core: Add qcm2290 DT compatible and resource data

[Jorge Ramirez <jorge.ramirez@oss.qualcomm.com>]

On 07/08/25 07:35:35, Bryan O'Donoghue wrote:
> On 05/08/2025 11:44, Jorge Ramirez wrote:
> > yes, in V7 I did implement this functionality plus a fix for EOS
> > handling (broken in pre 6.0.55 firmwares).
> > 
> > This added some complexity to the driver. And so in internal discussions
> > it was agreed that it was not worth to carry it and that it should be dropped.
> > 
> > I'll let Vikash and Bryan comment on the decision.
> 
> TBH I think there's not alot of value in supporting a broken firmware which
> only does decode.
> 
> There's not alot of value to the user in that configuration.

I dont know the user base but when I originally did the code (v7) I was
thinking about security conscious users (signed firmwares) who might not
be able to switch to the new fw release so easily (unnaccessible key
management and updates).

But I dont have those numbers so it might be none.

> 
> Provided you have done the work to get the fixed firmware into
> linux-firmware just cut at that point and have the driver reject lesser
> versions.

yep, that went smoothly:

https://gitlab.com/kernel-firmware/linux-firmware/-/commit/8ecf764788f8dbf33fc1c483ddf91f882ad792b6

> 
> I as a user have no use-case or value in a broken old firmware which
> supports decode only, I'd much rather have the full transcoder.
> 
> Its Vikash/Dikshita's call though.

I'll keep on holding v9 until then.