All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] spec: drop special-casing for naming of OL10 BPF crosses
@ 2025-08-06 14:10 Nick Alcock
  2025-08-06 18:49 ` Kris Van Hees
  0 siblings, 1 reply; 2+ messages in thread
From: Nick Alcock @ 2025-08-06 14:10 UTC (permalink / raw)
  To: dtrace, dtrace-devel

Since 14.1.1-1.0.1.1 in June 2025, these have had the same name as
everywhere else: no numeric suffix.

Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
---
 dtrace.spec | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/dtrace.spec b/dtrace.spec
index 115cea60ec98b..2345ace1bc522 100644
--- a/dtrace.spec
+++ b/dtrace.spec
@@ -17,15 +17,6 @@
 %define with_libctf 0
 %endif
 
-# OL10 requires an explicit BPF toolset version.
-%if "%{?dist}" == ".el10"
-%define bpfv -14
-%define bpfc BPFC=bpf-unknown-none-gcc-14
-%else
-%define bpfv %{nil}
-%define bpfc %{nil}
-%endif
-
 # By default, do not build with 32-on-64 support.
 %define glibc32 %{nil}
 
@@ -58,7 +49,7 @@ BuildRequires: fuse3-devel >= 3.2.0
 %define maybe_use_fuse2 %{nil}
 %endif
 %{?systemd_requires}
-BuildRequires: gcc-bpf-unknown-none%{bpfv}
+BuildRequires: gcc-bpf-unknown-none
 BuildRequires: binutils-bpf-unknown-none
 %ifnarch aarch64
 Requires:     binutils
@@ -132,7 +123,7 @@ it always tests the installed DTrace.
 
 %build
 make -j $(getconf _NPROCESSORS_ONLN) VERSION=%{version} \
-	%{bpfc} %{maybe_use_fuse2}
+	%{maybe_use_fuse2}
 
 # Force off debuginfo splitting.  We have no debuginfo in dtrace proper,
 # and the testsuite requires debuginfo for proper operation.

base-commit: b420f057c85b0a57bc31e106aa2440b2ada3a4ea
-- 
2.48.1.283.g18c60a128c


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] spec: drop special-casing for naming of OL10 BPF crosses
  2025-08-06 14:10 [PATCH] spec: drop special-casing for naming of OL10 BPF crosses Nick Alcock
@ 2025-08-06 18:49 ` Kris Van Hees
  0 siblings, 0 replies; 2+ messages in thread
From: Kris Van Hees @ 2025-08-06 18:49 UTC (permalink / raw)
  To: Nick Alcock; +Cc: dtrace, dtrace-devel

On Wed, Aug 06, 2025 at 03:10:36PM +0100, Nick Alcock wrote:
> Since 14.1.1-1.0.1.1 in June 2025, these have had the same name as
> everywhere else: no numeric suffix.

I checked with Jose and the BPF crosses are not available unless you use
'scl enable gcc-toolset-14-cross-{binutils,gcc}' so this patch is not
sufficient for building in OL environments in general.

> 
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> ---
>  dtrace.spec | 13 ++-----------
>  1 file changed, 2 insertions(+), 11 deletions(-)
> 
> diff --git a/dtrace.spec b/dtrace.spec
> index 115cea60ec98b..2345ace1bc522 100644
> --- a/dtrace.spec
> +++ b/dtrace.spec
> @@ -17,15 +17,6 @@
>  %define with_libctf 0
>  %endif
>  
> -# OL10 requires an explicit BPF toolset version.
> -%if "%{?dist}" == ".el10"
> -%define bpfv -14
> -%define bpfc BPFC=bpf-unknown-none-gcc-14
> -%else
> -%define bpfv %{nil}
> -%define bpfc %{nil}
> -%endif
> -
>  # By default, do not build with 32-on-64 support.
>  %define glibc32 %{nil}
>  
> @@ -58,7 +49,7 @@ BuildRequires: fuse3-devel >= 3.2.0
>  %define maybe_use_fuse2 %{nil}
>  %endif
>  %{?systemd_requires}
> -BuildRequires: gcc-bpf-unknown-none%{bpfv}
> +BuildRequires: gcc-bpf-unknown-none
>  BuildRequires: binutils-bpf-unknown-none
>  %ifnarch aarch64
>  Requires:     binutils
> @@ -132,7 +123,7 @@ it always tests the installed DTrace.
>  
>  %build
>  make -j $(getconf _NPROCESSORS_ONLN) VERSION=%{version} \
> -	%{bpfc} %{maybe_use_fuse2}
> +	%{maybe_use_fuse2}
>  
>  # Force off debuginfo splitting.  We have no debuginfo in dtrace proper,
>  # and the testsuite requires debuginfo for proper operation.
> 
> base-commit: b420f057c85b0a57bc31e106aa2440b2ada3a4ea
> -- 
> 2.48.1.283.g18c60a128c
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-08-06 18:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-06 14:10 [PATCH] spec: drop special-casing for naming of OL10 BPF crosses Nick Alcock
2025-08-06 18:49 ` Kris Van Hees

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.