* [PATCH] pinctrl: equilibrium: Remove redundant semicolons
@ 2025-08-12 7:54 Liao Yuanhong
2025-08-13 13:17 ` Andy Shevchenko
2025-08-19 11:37 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Liao Yuanhong @ 2025-08-12 7:54 UTC (permalink / raw)
To: Linus Walleij, Andy Shevchenko, Rahul Tanwar,
open list:PIN CONTROL SUBSYSTEM, open list
Cc: Liao Yuanhong
Remove unnecessary semicolons.
Fixes: 1948d5c51dba4 ("pinctrl: Add pinmux & GPIO controller driver for a new SoC")
Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
---
drivers/pinctrl/pinctrl-equilibrium.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-equilibrium.c b/drivers/pinctrl/pinctrl-equilibrium.c
index fce804d42e7d..f449576488d9 100644
--- a/drivers/pinctrl/pinctrl-equilibrium.c
+++ b/drivers/pinctrl/pinctrl-equilibrium.c
@@ -439,7 +439,6 @@ static int eqbr_pinconf_get(struct pinctrl_dev *pctldev, unsigned int pin,
}
raw_spin_unlock_irqrestore(&pctl->lock, flags);
*config = pinconf_to_config_packed(param, val);
-;
return 0;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: equilibrium: Remove redundant semicolons
2025-08-12 7:54 [PATCH] pinctrl: equilibrium: Remove redundant semicolons Liao Yuanhong
@ 2025-08-13 13:17 ` Andy Shevchenko
2025-08-19 11:37 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2025-08-13 13:17 UTC (permalink / raw)
To: Liao Yuanhong
Cc: Linus Walleij, Rahul Tanwar, open list:PIN CONTROL SUBSYSTEM,
open list
On Tue, Aug 12, 2025 at 03:54:44PM +0800, Liao Yuanhong wrote:
> Remove unnecessary semicolons.
While this is a good one
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
...
> raw_spin_unlock_irqrestore(&pctl->lock, flags);
> *config = pinconf_to_config_packed(param, val);
> -;
> return 0;
...I would still keep a blank line before return. But I leave it to Linus to
decide or even amend when applying.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: equilibrium: Remove redundant semicolons
2025-08-12 7:54 [PATCH] pinctrl: equilibrium: Remove redundant semicolons Liao Yuanhong
2025-08-13 13:17 ` Andy Shevchenko
@ 2025-08-19 11:37 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2025-08-19 11:37 UTC (permalink / raw)
To: Liao Yuanhong
Cc: Andy Shevchenko, Rahul Tanwar, open list:PIN CONTROL SUBSYSTEM,
open list
On Tue, Aug 12, 2025 at 9:54 AM Liao Yuanhong <liaoyuanhong@vivo.com> wrote:
> Remove unnecessary semicolons.
>
> Fixes: 1948d5c51dba4 ("pinctrl: Add pinmux & GPIO controller driver for a new SoC")
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
Patch applied as nonurgent fix, modified to keep as blank
line as suggested by Andy while applying.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-19 11:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-12 7:54 [PATCH] pinctrl: equilibrium: Remove redundant semicolons Liao Yuanhong
2025-08-13 13:17 ` Andy Shevchenko
2025-08-19 11:37 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.