* [RESEND PATCH] accel/habanalabs/gaudi2: Use kvfree() for memory allocated with kvcalloc()
@ 2024-08-20 23:10 Thorsten Blum
2025-08-16 11:02 ` Lukas Wunner
0 siblings, 1 reply; 5+ messages in thread
From: Thorsten Blum @ 2024-08-20 23:10 UTC (permalink / raw)
To: obitton, ogabbay, ttayar, fkassabri, osharabi, dliberman,
quic_carlv
Cc: dri-devel, linux-kernel, Thorsten Blum
Use kvfree() to fix the following Coccinelle/coccicheck warning reported
by kfree_mismatch.cocci:
WARNING kvmalloc is used to allocate this memory at line 10398
Reviewed-by: Tomer Tayar <ttayar@habana.ai>
Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
---
drivers/accel/habanalabs/gaudi2/gaudi2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accel/habanalabs/gaudi2/gaudi2.c b/drivers/accel/habanalabs/gaudi2/gaudi2.c
index a38b88baadf2..5722e4128d3c 100644
--- a/drivers/accel/habanalabs/gaudi2/gaudi2.c
+++ b/drivers/accel/habanalabs/gaudi2/gaudi2.c
@@ -10437,7 +10437,7 @@ static int gaudi2_memset_device_memory(struct hl_device *hdev, u64 addr, u64 siz
(u64 *)(lin_dma_pkts_arr), DEBUGFS_WRITE64);
WREG32(sob_addr, 0);
- kfree(lin_dma_pkts_arr);
+ kvfree(lin_dma_pkts_arr);
return rc;
}
--
2.46.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [RESEND PATCH] accel/habanalabs/gaudi2: Use kvfree() for memory allocated with kvcalloc()
2024-08-20 23:10 [RESEND PATCH] accel/habanalabs/gaudi2: Use kvfree() for memory allocated with kvcalloc() Thorsten Blum
@ 2025-08-16 11:02 ` Lukas Wunner
0 siblings, 0 replies; 5+ messages in thread
From: Lukas Wunner @ 2025-08-16 11:02 UTC (permalink / raw)
To: Thorsten Blum
Cc: obitton, ogabbay, ttayar, fkassabri, osharabi, dliberman,
quic_carlv, dri-devel, linux-kernel, Koby Elbaz,
Konstantin Sinyuk
On Wed, Aug 21, 2024 at 01:10:28AM +0200, Thorsten Blum wrote:
> Use kvfree() to fix the following Coccinelle/coccicheck warning reported
> by kfree_mismatch.cocci:
>
> WARNING kvmalloc is used to allocate this memory at line 10398
>
> Reviewed-by: Tomer Tayar <ttayar@habana.ai>
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
Applied to drm-misc-fixes, thanks.
You used toblux.com in the Signed-off-by tag but have since amended
.mailmap to use linux.dev instead. To avoid a mismatch between the
Signed-off-by tag and the commit author, I've taken the liberty to
hand-edit the former to use linux.dev.
I've also added a Fixes tag and stable designation.
Qianfeng Rong later submitted an identical patch, so I've added a
Reported-by tag to acknowledge that:
https://patch.msgid.link/20250808085530.233737-1-rongqianfeng@vivo.com
Thanks,
Lukas
^ permalink raw reply [flat|nested] 5+ messages in thread
* [RESEND PATCH] accel/habanalabs/gaudi2: Use kvfree() for memory allocated with kvcalloc()
@ 2024-07-03 7:24 Thorsten Blum
0 siblings, 0 replies; 5+ messages in thread
From: Thorsten Blum @ 2024-07-03 7:24 UTC (permalink / raw)
To: ogabbay
Cc: ttayar, obitton, fkassabri, dliberman, quic_carlv, dhirschfeld,
dri-devel, linux-kernel, Thorsten Blum
Use kvfree() to fix the following Coccinelle/coccicheck warning reported
by kfree_mismatch.cocci:
WARNING kvmalloc is used to allocate this memory at line 10398
Reviewed-by: Tomer Tayar <ttayar@habana.ai>
Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
---
drivers/accel/habanalabs/gaudi2/gaudi2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accel/habanalabs/gaudi2/gaudi2.c b/drivers/accel/habanalabs/gaudi2/gaudi2.c
index fa1c4feb9f89..8024047962ec 100644
--- a/drivers/accel/habanalabs/gaudi2/gaudi2.c
+++ b/drivers/accel/habanalabs/gaudi2/gaudi2.c
@@ -10489,7 +10489,7 @@ static int gaudi2_memset_device_memory(struct hl_device *hdev, u64 addr, u64 siz
(u64 *)(lin_dma_pkts_arr), DEBUGFS_WRITE64);
WREG32(sob_addr, 0);
- kfree(lin_dma_pkts_arr);
+ kvfree(lin_dma_pkts_arr);
return rc;
}
--
2.45.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [RESEND PATCH] accel/habanalabs/gaudi2: Use kvfree() for memory allocated with kvcalloc()
@ 2024-05-31 10:46 Thorsten Blum
2024-05-31 12:22 ` Tomer Tayar
0 siblings, 1 reply; 5+ messages in thread
From: Thorsten Blum @ 2024-05-31 10:46 UTC (permalink / raw)
To: Oded Gabbay, Tomer Tayar, Ofir Bitton, Farah Kassabri,
Dani Liberman, Dafna Hirschfeld, Koby Elbaz
Cc: dri-devel, linux-kernel, Thorsten Blum
Use kvfree() to fix the following Coccinelle/coccicheck warning reported
by kfree_mismatch.cocci:
WARNING kvmalloc is used to allocate this memory at line 10398
Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
---
drivers/accel/habanalabs/gaudi2/gaudi2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accel/habanalabs/gaudi2/gaudi2.c b/drivers/accel/habanalabs/gaudi2/gaudi2.c
index fa1c4feb9f89..8024047962ec 100644
--- a/drivers/accel/habanalabs/gaudi2/gaudi2.c
+++ b/drivers/accel/habanalabs/gaudi2/gaudi2.c
@@ -10489,7 +10489,7 @@ static int gaudi2_memset_device_memory(struct hl_device *hdev, u64 addr, u64 siz
(u64 *)(lin_dma_pkts_arr), DEBUGFS_WRITE64);
WREG32(sob_addr, 0);
- kfree(lin_dma_pkts_arr);
+ kvfree(lin_dma_pkts_arr);
return rc;
}
--
2.45.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [RESEND PATCH] accel/habanalabs/gaudi2: Use kvfree() for memory allocated with kvcalloc()
2024-05-31 10:46 Thorsten Blum
@ 2024-05-31 12:22 ` Tomer Tayar
0 siblings, 0 replies; 5+ messages in thread
From: Tomer Tayar @ 2024-05-31 12:22 UTC (permalink / raw)
To: Thorsten Blum, Oded Gabbay, Ofir Bitton, Farah Kassabri,
Dani Liberman, Dafna Hirschfeld, Koby Elbaz
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
On 31/05/2024 13:46, Thorsten Blum wrote:
> Use kvfree() to fix the following Coccinelle/coccicheck warning reported
> by kfree_mismatch.cocci:
>
> WARNING kvmalloc is used to allocate this memory at line 10398
>
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
Reviewed-by: Tomer Tayar <ttayar@habana.ai>
> ---
> drivers/accel/habanalabs/gaudi2/gaudi2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accel/habanalabs/gaudi2/gaudi2.c b/drivers/accel/habanalabs/gaudi2/gaudi2.c
> index fa1c4feb9f89..8024047962ec 100644
> --- a/drivers/accel/habanalabs/gaudi2/gaudi2.c
> +++ b/drivers/accel/habanalabs/gaudi2/gaudi2.c
> @@ -10489,7 +10489,7 @@ static int gaudi2_memset_device_memory(struct hl_device *hdev, u64 addr, u64 siz
> (u64 *)(lin_dma_pkts_arr), DEBUGFS_WRITE64);
> WREG32(sob_addr, 0);
>
> - kfree(lin_dma_pkts_arr);
> + kvfree(lin_dma_pkts_arr);
>
> return rc;
> }
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-08-16 11:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-20 23:10 [RESEND PATCH] accel/habanalabs/gaudi2: Use kvfree() for memory allocated with kvcalloc() Thorsten Blum
2025-08-16 11:02 ` Lukas Wunner
-- strict thread matches above, loose matches on Subject: below --
2024-07-03 7:24 Thorsten Blum
2024-05-31 10:46 Thorsten Blum
2024-05-31 12:22 ` Tomer Tayar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.