All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v6] drm/xe/pm: Disable RPM for SR-IOV VFs
@ 2025-08-12 16:36 Satyanarayana K V P
  2025-08-12 16:26 ` ✓ CI.KUnit: success for drm/xe/pm: Disable RPM for SR-IOV VFs (rev2) Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Satyanarayana K V P @ 2025-08-12 16:36 UTC (permalink / raw)
  To: intel-xe
  Cc: Satyanarayana K V P, Michal Wajdeczko, Matthew Brost,
	Michał Winiarski, Anshuman Gupta, Rodrigo Vivi,
	Maarten Lankhorst

VFs without native PCIe Power Management (PM) capabilities inherit their
PF's power state as per PCIe specifications(§5.10.1 PCIe Base Spec 7.0).
Enabling Runtime Power Management (RPM) for these VFs trigger unnecessary
driver suspend/resume operations that ultimately perform no PCI-level power
transition.

Since VFs without PM capabilities cannot independently enter low-power
states, the existing RPM workflow becomes redundant:
1. Driver executes full suspend/resume sequence
2. PCI PM transition step becomes no-op
3. VF power state remains tied to PF's status

Disabling RPM for VFs eliminates this redundant processing while
maintaining proper power management through PF dependency. This
optimization ensures VFs follow their PF's power state without superfluous
runtime handling.

Signed-off-by: Satyanarayana K V P <satyanarayana.k.v.p@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Michał Winiarski <michal.winiarski@intel.com>
Cc: Anshuman Gupta <anshuman.gupta@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Maarten Lankhorst <dev@lankhorst.se>

---
V5 -> V6:
- Updated comment (Rodrigo).

V4 -> V5:
- Disable RPM for VFs without checking pm_cap (Rodrigo).
- Updated commit title.

V3 -> V4:
- Fixed review comments (Rodrigo & Maarten)

V2 -> V3:
- Fixed review comments (Michal Wajdeczko).

V1 -> V2:
- Disable RPM only for VF devices when PM cap is not implemented.
---
 drivers/gpu/drm/xe/xe_pm.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
index 5e8126ca8e27..51934d5dc44f 100644
--- a/drivers/gpu/drm/xe/xe_pm.c
+++ b/drivers/gpu/drm/xe/xe_pm.c
@@ -247,6 +247,10 @@ static void xe_pm_runtime_init(struct xe_device *xe)
 {
 	struct device *dev = xe->drm.dev;
 
+	/* Our current VFs do not support RPM. so, disable it */
+	if (IS_SRIOV_VF(xe))
+		return;
+
 	/*
 	 * Disable the system suspend direct complete optimization.
 	 * We need to ensure that the regular device suspend/resume functions
@@ -367,6 +371,10 @@ static void xe_pm_runtime_fini(struct xe_device *xe)
 {
 	struct device *dev = xe->drm.dev;
 
+	/* Our current VFs do not support RPM. so, disable it */
+	if (IS_SRIOV_VF(xe))
+		return;
+
 	pm_runtime_get_sync(dev);
 	pm_runtime_forbid(dev);
 }
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2025-08-18 16:06 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-12 16:36 [PATCH v6] drm/xe/pm: Disable RPM for SR-IOV VFs Satyanarayana K V P
2025-08-12 16:26 ` ✓ CI.KUnit: success for drm/xe/pm: Disable RPM for SR-IOV VFs (rev2) Patchwork
2025-08-12 17:28 ` ✓ Xe.CI.BAT: " Patchwork
2025-08-12 20:07 ` ✗ Xe.CI.Full: failure " Patchwork
2025-08-17 16:40 ` [PATCH v6] drm/xe/pm: Disable RPM for SR-IOV VFs Rodrigo Vivi
2025-08-18  2:13   ` Matthew Brost
2025-08-18 10:13     ` Matthew Auld
2025-08-18 16:06       ` Matthew Brost

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.