All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harry Yoo <harry.yoo@oracle.com>
To: kernel test robot <lkp@intel.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH V5 mm-hotfixes 2/3] mm: introduce and use {pgd,p4d}_populate_kernel()
Date: Mon, 18 Aug 2025 19:41:57 +0900	[thread overview]
Message-ID: <aKMDdR9K1V-cOeX5@harry> (raw)
In-Reply-To: <202508181636.0Rtk0T7x-lkp@intel.com>

On Mon, Aug 18, 2025 at 05:02:01PM +0800, kernel test robot wrote:
> Hi Harry,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on tip/master]
> [also build test ERROR on linus/master v6.17-rc2 next-20250818]
> [cannot apply to akpm-mm/mm-everything tip/x86/core tip/x86/mm tip/auto-latest dennis-percpu/for-next]
> [If your patch is applied to the wrong git tree, kindly drop us a note.

This is based on akpm-mm/mm-hotfixes-unstable:
 e4321cf73f53 mm/userfaultfd: fix kmap_local LIFO ordering for CONFIG_HIGHPTE

> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch*_base_tree_information ]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Harry-Yoo/mm-move-page-table-sync-declarations-to-linux-pgtable-h/20250818-101531 
> base:   tip/master
> patch link:    https://lore.kernel.org/r/20250818020206.4517-3-harry.yoo*40oracle.com 
> patch subject: [PATCH V5 mm-hotfixes 2/3] mm: introduce and use {pgd,p4d}_populate_kernel()
> config: arm64-randconfig-001-20250818 (https://download.01.org/0day-ci/archive/20250818/202508181636.0Rtk0T7x-lkp@intel.com/config )
> compiler: aarch64-linux-gcc (GCC) 11.5.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250818/202508181636.0Rtk0T7x-lkp@intel.com/reproduce )
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202508181636.0Rtk0T7x-lkp@intel.com/ 
> 
> All errors (new ones prefixed by >>):
> 
>    aarch64-linux-ld: mm/kasan/init.o: in function `zero_p4d_populate':
> >> mm/kasan/init.c:195:(.ref.text+0x374): undefined reference to `kasan_early_shadow_pud'
> >> mm/kasan/init.c:195:(.ref.text+0x374): relocation truncated to fit: R_AARCH64_ADR_PREL_PG_HI21 against undefined symbol `kasan_early_shadow_pud'
> >> aarch64-linux-ld: mm/kasan/init.c:195:(.ref.text+0x378): undefined reference to `kasan_early_shadow_pud'
>    aarch64-linux-ld: mm/kasan/init.o: in function `kasan_populate_early_shadow':
>    mm/kasan/init.c:258:(.ref.text+0x41c): undefined reference to `kasan_early_shadow_pud'
>    mm/kasan/init.c:258:(.ref.text+0x41c): relocation truncated to fit: R_AARCH64_ADR_PREL_PG_HI21 against undefined symbol `kasan_early_shadow_pud'
>    aarch64-linux-ld: mm/kasan/init.c:258:(.ref.text+0x420): undefined reference to `kasan_early_shadow_pud'
> >> aarch64-linux-ld: mm/kasan/init.c:255:(.ref.text+0x42c): undefined reference to `kasan_early_shadow_p4d'
> >> mm/kasan/init.c:255:(.ref.text+0x42c): relocation truncated to fit: R_AARCH64_ADR_PREL_PG_HI21 against undefined symbol `kasan_early_shadow_p4d'
>    aarch64-linux-ld: mm/kasan/init.c:255:(.ref.text+0x430): undefined reference to `kasan_early_shadow_p4d'

My patch series shouldn't be causing this.
Does this error trigger before applying my patch series?

-- 
Cheers,
Harry / Hyeonggon

> vim +195 mm/kasan/init.c
> 
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  181  
> 0207df4fa1a869 mm/kasan/kasan_init.c Andrey Ryabinin    2018-08-17  182  static int __ref zero_p4d_populate(pgd_t *pgd, unsigned long addr,
> c2febafc67734a mm/kasan/kasan_init.c Kirill A. Shutemov 2017-03-09  183  				unsigned long end)
> c2febafc67734a mm/kasan/kasan_init.c Kirill A. Shutemov 2017-03-09  184  {
> c2febafc67734a mm/kasan/kasan_init.c Kirill A. Shutemov 2017-03-09  185  	p4d_t *p4d = p4d_offset(pgd, addr);
> c2febafc67734a mm/kasan/kasan_init.c Kirill A. Shutemov 2017-03-09  186  	unsigned long next;
> c2febafc67734a mm/kasan/kasan_init.c Kirill A. Shutemov 2017-03-09  187  
> c2febafc67734a mm/kasan/kasan_init.c Kirill A. Shutemov 2017-03-09  188  	do {
> c2febafc67734a mm/kasan/kasan_init.c Kirill A. Shutemov 2017-03-09  189  		next = p4d_addr_end(addr, end);
> 458f7920f9b1e6 mm/kasan/kasan_init.c Joonsoo Kim        2017-07-10  190  		if (IS_ALIGNED(addr, P4D_SIZE) && end - addr >= P4D_SIZE) {
> 458f7920f9b1e6 mm/kasan/kasan_init.c Joonsoo Kim        2017-07-10  191  			pud_t *pud;
> 458f7920f9b1e6 mm/kasan/kasan_init.c Joonsoo Kim        2017-07-10  192  			pmd_t *pmd;
> 458f7920f9b1e6 mm/kasan/kasan_init.c Joonsoo Kim        2017-07-10  193  
> a86b0f4e94542c mm/kasan/init.c       Harry Yoo          2025-08-18  194  			p4d_populate_kernel(addr, p4d,
> 9577dd74864877 mm/kasan/init.c       Andrey Konovalov   2018-12-28 @195  					lm_alias(kasan_early_shadow_pud));
> 458f7920f9b1e6 mm/kasan/kasan_init.c Joonsoo Kim        2017-07-10  196  			pud = pud_offset(p4d, addr);
> 9577dd74864877 mm/kasan/init.c       Andrey Konovalov   2018-12-28  197  			pud_populate(&init_mm, pud,
> 9577dd74864877 mm/kasan/init.c       Andrey Konovalov   2018-12-28  198  					lm_alias(kasan_early_shadow_pmd));
> 458f7920f9b1e6 mm/kasan/kasan_init.c Joonsoo Kim        2017-07-10  199  			pmd = pmd_offset(pud, addr);
> 458f7920f9b1e6 mm/kasan/kasan_init.c Joonsoo Kim        2017-07-10  200  			pmd_populate_kernel(&init_mm, pmd,
> 9577dd74864877 mm/kasan/init.c       Andrey Konovalov   2018-12-28  201  					lm_alias(kasan_early_shadow_pte));
> 458f7920f9b1e6 mm/kasan/kasan_init.c Joonsoo Kim        2017-07-10  202  			continue;
> 458f7920f9b1e6 mm/kasan/kasan_init.c Joonsoo Kim        2017-07-10  203  		}
> c2febafc67734a mm/kasan/kasan_init.c Kirill A. Shutemov 2017-03-09  204  
> c2febafc67734a mm/kasan/kasan_init.c Kirill A. Shutemov 2017-03-09  205  		if (p4d_none(*p4d)) {
> 0207df4fa1a869 mm/kasan/kasan_init.c Andrey Ryabinin    2018-08-17  206  			pud_t *p;
> 0207df4fa1a869 mm/kasan/kasan_init.c Andrey Ryabinin    2018-08-17  207  
> 0207df4fa1a869 mm/kasan/kasan_init.c Andrey Ryabinin    2018-08-17  208  			if (slab_is_available()) {
> 0207df4fa1a869 mm/kasan/kasan_init.c Andrey Ryabinin    2018-08-17  209  				p = pud_alloc(&init_mm, p4d, addr);
> 0207df4fa1a869 mm/kasan/kasan_init.c Andrey Ryabinin    2018-08-17  210  				if (!p)
> 0207df4fa1a869 mm/kasan/kasan_init.c Andrey Ryabinin    2018-08-17  211  					return -ENOMEM;
> 0207df4fa1a869 mm/kasan/kasan_init.c Andrey Ryabinin    2018-08-17  212  			} else {
> fb6d5c1d99ab69 mm/kasan/init.c       Qing Zhang         2023-09-06  213  				p = early_alloc(PAGE_SIZE, NUMA_NO_NODE);
> fb6d5c1d99ab69 mm/kasan/init.c       Qing Zhang         2023-09-06  214  				pud_init(p);
> a86b0f4e94542c mm/kasan/init.c       Harry Yoo          2025-08-18  215  				p4d_populate_kernel(addr, p4d, p);
> c2febafc67734a mm/kasan/kasan_init.c Kirill A. Shutemov 2017-03-09  216  			}
> 0207df4fa1a869 mm/kasan/kasan_init.c Andrey Ryabinin    2018-08-17  217  		}
> c2febafc67734a mm/kasan/kasan_init.c Kirill A. Shutemov 2017-03-09  218  		zero_pud_populate(p4d, addr, next);
> c2febafc67734a mm/kasan/kasan_init.c Kirill A. Shutemov 2017-03-09  219  	} while (p4d++, addr = next, addr != end);
> 0207df4fa1a869 mm/kasan/kasan_init.c Andrey Ryabinin    2018-08-17  220  
> 0207df4fa1a869 mm/kasan/kasan_init.c Andrey Ryabinin    2018-08-17  221  	return 0;
> c2febafc67734a mm/kasan/kasan_init.c Kirill A. Shutemov 2017-03-09  222  }
> c2febafc67734a mm/kasan/kasan_init.c Kirill A. Shutemov 2017-03-09  223  
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  224  /**
> 9577dd74864877 mm/kasan/init.c       Andrey Konovalov   2018-12-28  225   * kasan_populate_early_shadow - populate shadow memory region with
> 9577dd74864877 mm/kasan/init.c       Andrey Konovalov   2018-12-28  226   *                               kasan_early_shadow_page
> 7b6889f54a3c8c mm/kasan/init.c       Yu Kuai            2021-06-04  227   * @shadow_start: start of the memory range to populate
> 7b6889f54a3c8c mm/kasan/init.c       Yu Kuai            2021-06-04  228   * @shadow_end: end of the memory range to populate
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  229   */
> 9577dd74864877 mm/kasan/init.c       Andrey Konovalov   2018-12-28  230  int __ref kasan_populate_early_shadow(const void *shadow_start,
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  231  					const void *shadow_end)
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  232  {
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  233  	unsigned long addr = (unsigned long)shadow_start;
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  234  	unsigned long end = (unsigned long)shadow_end;
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  235  	pgd_t *pgd = pgd_offset_k(addr);
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  236  	unsigned long next;
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  237  
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  238  	do {
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  239  		next = pgd_addr_end(addr, end);
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  240  
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  241  		if (IS_ALIGNED(addr, PGDIR_SIZE) && end - addr >= PGDIR_SIZE) {
> c2febafc67734a mm/kasan/kasan_init.c Kirill A. Shutemov 2017-03-09  242  			p4d_t *p4d;
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  243  			pud_t *pud;
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  244  			pmd_t *pmd;
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  245  
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  246  			/*
> 9577dd74864877 mm/kasan/init.c       Andrey Konovalov   2018-12-28  247  			 * kasan_early_shadow_pud should be populated with pmds
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  248  			 * at this moment.
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  249  			 * [pud,pmd]_populate*() below needed only for
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  250  			 * 3,2 - level page tables where we don't have
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  251  			 * puds,pmds, so pgd_populate(), pud_populate()
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  252  			 * is noops.
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  253  			 */
> a86b0f4e94542c mm/kasan/init.c       Harry Yoo          2025-08-18  254  			pgd_populate_kernel(addr, pgd,
> 9577dd74864877 mm/kasan/init.c       Andrey Konovalov   2018-12-28 @255  					lm_alias(kasan_early_shadow_p4d));
> c2febafc67734a mm/kasan/kasan_init.c Kirill A. Shutemov 2017-03-09  256  			p4d = p4d_offset(pgd, addr);
> a86b0f4e94542c mm/kasan/init.c       Harry Yoo          2025-08-18  257  			p4d_populate_kernel(addr, p4d,
> 9577dd74864877 mm/kasan/init.c       Andrey Konovalov   2018-12-28  258  					lm_alias(kasan_early_shadow_pud));
> c2febafc67734a mm/kasan/kasan_init.c Kirill A. Shutemov 2017-03-09  259  			pud = pud_offset(p4d, addr);
> 9577dd74864877 mm/kasan/init.c       Andrey Konovalov   2018-12-28  260  			pud_populate(&init_mm, pud,
> 9577dd74864877 mm/kasan/init.c       Andrey Konovalov   2018-12-28  261  					lm_alias(kasan_early_shadow_pmd));
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  262  			pmd = pmd_offset(pud, addr);
> 9577dd74864877 mm/kasan/init.c       Andrey Konovalov   2018-12-28  263  			pmd_populate_kernel(&init_mm, pmd,
> 9577dd74864877 mm/kasan/init.c       Andrey Konovalov   2018-12-28  264  					lm_alias(kasan_early_shadow_pte));
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  265  			continue;
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  266  		}
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  267  
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  268  		if (pgd_none(*pgd)) {
> 0207df4fa1a869 mm/kasan/kasan_init.c Andrey Ryabinin    2018-08-17  269  			p4d_t *p;
> 0207df4fa1a869 mm/kasan/kasan_init.c Andrey Ryabinin    2018-08-17  270  
> 0207df4fa1a869 mm/kasan/kasan_init.c Andrey Ryabinin    2018-08-17  271  			if (slab_is_available()) {
> 0207df4fa1a869 mm/kasan/kasan_init.c Andrey Ryabinin    2018-08-17  272  				p = p4d_alloc(&init_mm, pgd, addr);
> 0207df4fa1a869 mm/kasan/kasan_init.c Andrey Ryabinin    2018-08-17  273  				if (!p)
> 0207df4fa1a869 mm/kasan/kasan_init.c Andrey Ryabinin    2018-08-17  274  					return -ENOMEM;
> 0207df4fa1a869 mm/kasan/kasan_init.c Andrey Ryabinin    2018-08-17  275  			} else {
> a86b0f4e94542c mm/kasan/init.c       Harry Yoo          2025-08-18  276  				pgd_populate_kernel(addr, pgd,
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  277  					early_alloc(PAGE_SIZE, NUMA_NO_NODE));
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  278  			}
> 0207df4fa1a869 mm/kasan/kasan_init.c Andrey Ryabinin    2018-08-17  279  		}
> c2febafc67734a mm/kasan/kasan_init.c Kirill A. Shutemov 2017-03-09  280  		zero_p4d_populate(pgd, addr, next);
> 69786cdb379bbc mm/kasan/kasan_init.c Andrey Ryabinin    2015-08-13  281  	} while (pgd++, addr = next, addr != end);
> 0207df4fa1a869 mm/kasan/kasan_init.c Andrey Ryabinin    2018-08-17  282  
> 0207df4fa1a869 mm/kasan/kasan_init.c Andrey Ryabinin    2018-08-17  283  	return 0;
> 0207df4fa1a869 mm/kasan/kasan_init.c Andrey Ryabinin    2018-08-17  284  }
> 0207df4fa1a869 mm/kasan/kasan_init.c Andrey Ryabinin    2018-08-17  285  
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki 

  reply	other threads:[~2025-08-18 10:42 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-18  2:02 [PATCH V5 mm-hotfixes 0/3] mm, x86: fix crash due to missing page table sync and make it harder to miss Harry Yoo
2025-08-18  2:02 ` [PATCH V5 mm-hotfixes 1/3] mm: move page table sync declarations to linux/pgtable.h Harry Yoo
2025-08-18  7:47   ` David Hildenbrand
2025-08-18  2:02 ` [PATCH V5 mm-hotfixes 2/3] mm: introduce and use {pgd,p4d}_populate_kernel() Harry Yoo
2025-08-18  7:48   ` David Hildenbrand
2025-08-18  9:02   ` kernel test robot
2025-08-18 10:41     ` Harry Yoo [this message]
2025-08-21  9:35   ` [PATCH] mm: fix KASAN build error due to p*d_populate_kernel() Harry Yoo
2025-08-21  9:38     ` kernel test robot
2025-08-21 10:10     ` Lorenzo Stoakes
2025-08-21 10:42       ` Harry Yoo
2025-08-21 11:46         ` Lorenzo Stoakes
2025-08-21 11:57     ` [PATCH v2] " Harry Yoo
2025-08-21 12:00       ` kernel test robot
2025-08-21 17:36       ` Dave Hansen
2025-08-22  1:11         ` Harry Yoo
2025-08-22 16:02           ` Andrey Ryabinin
2025-08-27  6:30             ` Harry Yoo
2025-08-22 17:08           ` Dave Hansen
2025-08-25  9:46             ` Andrey Ryabinin
2025-08-22  2:07   ` [PATCH v3] " Harry Yoo
2025-08-18  2:02 ` [PATCH V5 mm-hotfixes 3/3] x86/mm/64: define ARCH_PAGE_TABLE_SYNC_MASK and arch_sync_kernel_mappings() Harry Yoo
2025-08-18  7:49   ` David Hildenbrand
2025-08-18  7:50 ` [PATCH V5 mm-hotfixes 0/3] mm, x86: fix crash due to missing page table sync and make it harder to miss David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aKMDdR9K1V-cOeX5@harry \
    --to=harry.yoo@oracle.com \
    --cc=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.