Re: [PATCH 27/33] migration/socket: keep fds non-block

[Peter Xu <peterx@redhat.com>]

On Wed, Aug 13, 2025 at 07:48:48PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> For migration channel keep fds non-blocking property as is.
> It's needed for future local migration of fds.

It is pretty risky.  This changes the attribute for all the iochannels that
migration incoming side uses, including multifd / postcopy / ...

I left comment in previous patch as a pure question trying to understand
whether the feature is needed.  If it is, here it might still be good to:

  - Above the line add a comment explaning why
  - Only apply it to whatever channel that matters.  In this case, IIUC
    only the main channel matters

Thanks,

> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
>  migration/socket.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/migration/socket.c b/migration/socket.c
> index 5ec65b8c03..9f7b6919cf 100644
> --- a/migration/socket.c
> +++ b/migration/socket.c
> @@ -129,6 +129,7 @@ static void socket_accept_incoming_migration(QIONetListener *listener,
>      }
>  
>      qio_channel_set_name(QIO_CHANNEL(cioc), "migration-socket-incoming");
> +    qio_channel_socket_keep_nonblock(QIO_CHANNEL(cioc));
>      migration_channel_process_incoming(QIO_CHANNEL(cioc));
>  }
>  
> -- 
> 2.48.1
> 

-- 
Peter Xu