* [PATCH v2] media: atomisp: use kmalloc_array() for array space allocation
@ 2025-08-21 8:17 Qianfeng Rong
2025-08-21 9:26 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Qianfeng Rong @ 2025-08-21 8:17 UTC (permalink / raw)
To: Andy Shevchenko, Hans de Goede, Mauro Carvalho Chehab,
Sakari Ailus, Greg Kroah-Hartman, Qianfeng Rong, Colin Ian King,
linux-kernel, linux-media, linux-staging
Replace kmalloc(count * sizeof(type)) with kmalloc_array() for safer memory
allocation and overflow prevention. Additionally, replace sizeof(type) with
sizeof(*ptr) to improve code robustness.
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
---
v2: change sizeof(type) to sizeof(*ptr) to improve code robustness as
suggested by Andy.
---
drivers/staging/media/atomisp/pci/sh_css.c | 54 +++++++++++-----------
1 file changed, 28 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/sh_css.c b/drivers/staging/media/atomisp/pci/sh_css.c
index 73bd87f43a8c..61df1bf2bff5 100644
--- a/drivers/staging/media/atomisp/pci/sh_css.c
+++ b/drivers/staging/media/atomisp/pci/sh_css.c
@@ -5821,36 +5821,37 @@ static int ia_css_pipe_create_cas_scaler_desc_single_output(
i *= max_scale_factor_per_stage;
}
- descr->in_info = kmalloc(descr->num_stage *
- sizeof(struct ia_css_frame_info),
- GFP_KERNEL);
+ descr->in_info = kmalloc_array(descr->num_stage,
+ sizeof(*descr->in_info),
+ GFP_KERNEL);
if (!descr->in_info) {
err = -ENOMEM;
goto ERR;
}
- descr->internal_out_info = kmalloc(descr->num_stage *
- sizeof(struct ia_css_frame_info),
- GFP_KERNEL);
+ descr->internal_out_info = kmalloc_array(descr->num_stage,
+ sizeof(*descr->internal_out_info),
+ GFP_KERNEL);
if (!descr->internal_out_info) {
err = -ENOMEM;
goto ERR;
}
- descr->out_info = kmalloc(descr->num_stage *
- sizeof(struct ia_css_frame_info),
- GFP_KERNEL);
+ descr->out_info = kmalloc_array(descr->num_stage,
+ sizeof(*descr->out_info),
+ GFP_KERNEL);
if (!descr->out_info) {
err = -ENOMEM;
goto ERR;
}
- descr->vf_info = kmalloc(descr->num_stage *
- sizeof(struct ia_css_frame_info),
- GFP_KERNEL);
+ descr->vf_info = kmalloc_array(descr->num_stage,
+ sizeof(*descr->vf_info),
+ GFP_KERNEL);
if (!descr->vf_info) {
err = -ENOMEM;
goto ERR;
}
- descr->is_output_stage = kmalloc(descr->num_stage * sizeof(bool),
- GFP_KERNEL);
+ descr->is_output_stage = kmalloc_array(descr->num_stage,
+ sizeof(*descr->is_output_stage),
+ GFP_KERNEL);
if (!descr->is_output_stage) {
err = -ENOMEM;
goto ERR;
@@ -5971,35 +5972,36 @@ ia_css_pipe_create_cas_scaler_desc(struct ia_css_pipe *pipe,
descr->num_stage = num_stages;
descr->in_info = kmalloc_array(descr->num_stage,
- sizeof(struct ia_css_frame_info),
+ sizeof(*descr->in_info),
GFP_KERNEL);
if (!descr->in_info) {
err = -ENOMEM;
goto ERR;
}
- descr->internal_out_info = kmalloc(descr->num_stage *
- sizeof(struct ia_css_frame_info),
- GFP_KERNEL);
+ descr->internal_out_info = kmalloc_array(descr->num_stage,
+ sizeof(*descr->internal_out_info),
+ GFP_KERNEL);
if (!descr->internal_out_info) {
err = -ENOMEM;
goto ERR;
}
- descr->out_info = kmalloc(descr->num_stage *
- sizeof(struct ia_css_frame_info),
- GFP_KERNEL);
+ descr->out_info = kmalloc_array(descr->num_stage,
+ sizeof(*descr->out_info),
+ GFP_KERNEL);
if (!descr->out_info) {
err = -ENOMEM;
goto ERR;
}
- descr->vf_info = kmalloc(descr->num_stage *
- sizeof(struct ia_css_frame_info),
- GFP_KERNEL);
+ descr->vf_info = kmalloc_array(descr->num_stage,
+ sizeof(*descr->vf_info),
+ GFP_KERNEL);
if (!descr->vf_info) {
err = -ENOMEM;
goto ERR;
}
- descr->is_output_stage = kmalloc(descr->num_stage * sizeof(bool),
- GFP_KERNEL);
+ descr->is_output_stage = kmalloc_array(descr->num_stage,
+ sizeof(*descr->is_output_stage),
+ GFP_KERNEL);
if (!descr->is_output_stage) {
err = -ENOMEM;
goto ERR;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] media: atomisp: use kmalloc_array() for array space allocation
2025-08-21 8:17 [PATCH v2] media: atomisp: use kmalloc_array() for array space allocation Qianfeng Rong
@ 2025-08-21 9:26 ` Andy Shevchenko
2026-04-18 8:46 ` Sakari Ailus
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2025-08-21 9:26 UTC (permalink / raw)
To: Qianfeng Rong
Cc: Andy Shevchenko, Hans de Goede, Mauro Carvalho Chehab,
Sakari Ailus, Greg Kroah-Hartman, Colin Ian King, linux-kernel,
linux-media, linux-staging
On Thu, Aug 21, 2025 at 04:17:42PM +0800, Qianfeng Rong wrote:
> Replace kmalloc(count * sizeof(type)) with kmalloc_array() for safer memory
> allocation and overflow prevention. Additionally, replace sizeof(type) with
> sizeof(*ptr) to improve code robustness.
LGTM, thanks.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] media: atomisp: use kmalloc_array() for array space allocation
2025-08-21 9:26 ` Andy Shevchenko
@ 2026-04-18 8:46 ` Sakari Ailus
0 siblings, 0 replies; 3+ messages in thread
From: Sakari Ailus @ 2026-04-18 8:46 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Qianfeng Rong, Andy Shevchenko, Hans de Goede,
Mauro Carvalho Chehab, Sakari Ailus, Greg Kroah-Hartman,
Colin Ian King, linux-kernel, linux-media, linux-staging
On Thu, Aug 21, 2025 at 12:26:39PM +0300, Andy Shevchenko wrote:
> On Thu, Aug 21, 2025 at 04:17:42PM +0800, Qianfeng Rong wrote:
> > Replace kmalloc(count * sizeof(type)) with kmalloc_array() for safer memory
> > allocation and overflow prevention. Additionally, replace sizeof(type) with
> > sizeof(*ptr) to improve code robustness.
>
> LGTM, thanks.
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
I'm afraid this no longer applies to my atomisp branch.
--
Sakari Ailus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-18 8:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-21 8:17 [PATCH v2] media: atomisp: use kmalloc_array() for array space allocation Qianfeng Rong
2025-08-21 9:26 ` Andy Shevchenko
2026-04-18 8:46 ` Sakari Ailus
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.