From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Mario Limonciello (AMD)" <superm1@kernel.org>
Cc: mario.limonciello@amd.com, Basavaraj.Natikar@amd.com,
Shyam-sundar.S-k@amd.com, linus.walleij@linaro.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2] pinctrl: amd: Don't access irq_data's hwirq member directly
Date: Thu, 21 Aug 2025 18:42:49 +0300 [thread overview]
Message-ID: <aKc-eRIeLP3DOjQN@smile.fi.intel.com> (raw)
In-Reply-To: <20250821144942.2463014-1-superm1@kernel.org>
On Thu, Aug 21, 2025 at 09:49:11AM -0500, Mario Limonciello (AMD) wrote:
> There is an irqd_to_hwirq() intended to get the hwirq number. Switch
> all use to it.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
...
> pm_pr_dbg("Setting wake for GPIO %lu to %s\n",
> - d->hwirq, str_enable_disable(on));
> + hwirq, str_enable_disable(on));
Not related to this series, just wondering if it makes sense to have this to be
in IRQ chip core (OTOH, it will not tell about GPIO per se, just about an IRQ
chip).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-08-21 15:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 14:49 [PATCH v2] pinctrl: amd: Don't access irq_data's hwirq member directly Mario Limonciello (AMD)
2025-08-21 15:42 ` Andy Shevchenko [this message]
2025-08-21 15:46 ` Mario Limonciello
2025-08-21 22:16 ` Linus Walleij
2025-08-22 0:30 ` Mario Limonciello
2025-08-22 6:33 ` Linus Walleij
2025-08-22 7:53 ` Andy Shevchenko
2025-08-22 13:12 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKc-eRIeLP3DOjQN@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=superm1@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.