Re: [axboe-block:for-6.18/io_uring 16/16] include/linux/io_uring/cmd.h:123:1: error: expected identifier or '(' before '{' token

[Ming Lei <ming.lei@redhat.com>]

On Thu, Aug 21, 2025 at 10:46:05PM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-6.18/io_uring
> head:   55dc643dd2ad15e755a706980692a374de1bb7a8
> commit: 55dc643dd2ad15e755a706980692a374de1bb7a8 [16/16] io_uring: uring_cmd: add multishot support
> config: i386-buildonly-randconfig-001-20250821 (https://download.01.org/0day-ci/archive/20250821/202508212218.pOwu5QFJ-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250821/202508212218.pOwu5QFJ-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202508212218.pOwu5QFJ-lkp@intel.com/
> 
> All error/warnings (new ones prefixed by >>):
> 
>    In file included from block/fops.c:20:
> >> include/linux/io_uring/cmd.h:123:1: error: expected identifier or '(' before '{' token
>      123 | {
>          | ^
> >> include/linux/io_uring/cmd.h:121:1: warning: 'io_uring_cmd_buffer_select' declared 'static' but never defined [-Wunused-function]
>      121 | io_uring_cmd_buffer_select(struct io_uring_cmd *ioucmd, unsigned buf_group,
>          | ^~~~~~~~~~~~~~~~~~~~~~~~~~

Hi Jens,

Can you fold the following change into this patch?


diff --git a/include/linux/io_uring/cmd.h b/include/linux/io_uring/cmd.h
index be0e29b72669..4bd3a7339243 100644
--- a/include/linux/io_uring/cmd.h
+++ b/include/linux/io_uring/cmd.h
@@ -119,7 +119,7 @@ static inline void io_uring_cmd_issue_blocking(struct io_uring_cmd *ioucmd)
 }
 static inline struct io_br_sel
 io_uring_cmd_buffer_select(struct io_uring_cmd *ioucmd, unsigned buf_group,
-			   size_t *len, unsigned int issue_flags);
+			   size_t *len, unsigned int issue_flags)
 {
 	return (struct io_br_sel) { .val = -EOPNOTSUPP };
 }


Thanks,
Ming