[axboe-block:for-6.18/io_uring 16/16] include/linux/io_uring/cmd.h:123:1: error: expected identifier or '(' before '{' token

[axboe-block:for-6.18/io_uring 16/16] include/linux/io_uring/cmd.h:123:1: error: expected identifier or '(' before '{' token

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-6.18/io_uring
head:   55dc643dd2ad15e755a706980692a374de1bb7a8
commit: 55dc643dd2ad15e755a706980692a374de1bb7a8 [16/16] io_uring: uring_cmd: add multishot support
config: i386-buildonly-randconfig-001-20250821 (https://download.01.org/0day-ci/archive/20250821/202508212218.pOwu5QFJ-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250821/202508212218.pOwu5QFJ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508212218.pOwu5QFJ-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   In file included from block/fops.c:20:
>> include/linux/io_uring/cmd.h:123:1: error: expected identifier or '(' before '{' token
     123 | {
         | ^
>> include/linux/io_uring/cmd.h:121:1: warning: 'io_uring_cmd_buffer_select' declared 'static' but never defined [-Wunused-function]
     121 | io_uring_cmd_buffer_select(struct io_uring_cmd *ioucmd, unsigned buf_group,
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~


vim +123 include/linux/io_uring/cmd.h

    72	
    73	/*
    74	 * Select a buffer from the provided buffer group for multishot uring_cmd.
    75	 * Returns the selected buffer address and size.
    76	 */
    77	struct io_br_sel io_uring_cmd_buffer_select(struct io_uring_cmd *ioucmd,
    78						    unsigned buf_group, size_t *len,
    79						    unsigned int issue_flags);
    80	
    81	/*
    82	 * Complete a multishot uring_cmd event. This will post a CQE to the completion
    83	 * queue and update the provided buffer.
    84	 */
    85	bool io_uring_mshot_cmd_post_cqe(struct io_uring_cmd *ioucmd,
    86					 struct io_br_sel *sel, unsigned int issue_flags);
    87	
    88	#else
    89	static inline int
    90	io_uring_cmd_import_fixed(u64 ubuf, unsigned long len, int rw,
    91				  struct iov_iter *iter, struct io_uring_cmd *ioucmd,
    92				  unsigned int issue_flags)
    93	{
    94		return -EOPNOTSUPP;
    95	}
    96	static inline int io_uring_cmd_import_fixed_vec(struct io_uring_cmd *ioucmd,
    97							const struct iovec __user *uvec,
    98							size_t uvec_segs,
    99							int ddir, struct iov_iter *iter,
   100							unsigned issue_flags)
   101	{
   102		return -EOPNOTSUPP;
   103	}
   104	static inline void io_uring_cmd_done(struct io_uring_cmd *cmd, ssize_t ret,
   105			u64 ret2, unsigned issue_flags)
   106	{
   107	}
   108	static inline void __io_uring_cmd_do_in_task(struct io_uring_cmd *ioucmd,
   109				    void (*task_work_cb)(struct io_uring_cmd *, unsigned),
   110				    unsigned flags)
   111	{
   112	}
   113	static inline void io_uring_cmd_mark_cancelable(struct io_uring_cmd *cmd,
   114			unsigned int issue_flags)
   115	{
   116	}
   117	static inline void io_uring_cmd_issue_blocking(struct io_uring_cmd *ioucmd)
   118	{
   119	}
   120	static inline struct io_br_sel
 > 121	io_uring_cmd_buffer_select(struct io_uring_cmd *ioucmd, unsigned buf_group,
   122				   size_t *len, unsigned int issue_flags);
 > 123	{
   124		return (struct io_br_sel) { .val = -EOPNOTSUPP };
   125	}
   126	static inline bool io_uring_mshot_cmd_post_cqe(struct io_uring_cmd *ioucmd,
   127					ssize_t ret, unsigned int issue_flags)
   128	{
   129		return true;
   130	}
   131	#endif
   132	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [axboe-block:for-6.18/io_uring 16/16] include/linux/io_uring/cmd.h:123:1: error: expected identifier or '(' before '{' token

[Ming Lei]

On Thu, Aug 21, 2025 at 10:46:05PM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-6.18/io_uring
> head:   55dc643dd2ad15e755a706980692a374de1bb7a8
> commit: 55dc643dd2ad15e755a706980692a374de1bb7a8 [16/16] io_uring: uring_cmd: add multishot support
> config: i386-buildonly-randconfig-001-20250821 (https://download.01.org/0day-ci/archive/20250821/202508212218.pOwu5QFJ-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250821/202508212218.pOwu5QFJ-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202508212218.pOwu5QFJ-lkp@intel.com/
> 
> All error/warnings (new ones prefixed by >>):
> 
>    In file included from block/fops.c:20:
> >> include/linux/io_uring/cmd.h:123:1: error: expected identifier or '(' before '{' token
>      123 | {
>          | ^
> >> include/linux/io_uring/cmd.h:121:1: warning: 'io_uring_cmd_buffer_select' declared 'static' but never defined [-Wunused-function]
>      121 | io_uring_cmd_buffer_select(struct io_uring_cmd *ioucmd, unsigned buf_group,
>          | ^~~~~~~~~~~~~~~~~~~~~~~~~~

Hi Jens,

Can you fold the following change into this patch?


diff --git a/include/linux/io_uring/cmd.h b/include/linux/io_uring/cmd.h
index be0e29b72669..4bd3a7339243 100644
--- a/include/linux/io_uring/cmd.h
+++ b/include/linux/io_uring/cmd.h
@@ -119,7 +119,7 @@ static inline void io_uring_cmd_issue_blocking(struct io_uring_cmd *ioucmd)
 }
 static inline struct io_br_sel
 io_uring_cmd_buffer_select(struct io_uring_cmd *ioucmd, unsigned buf_group,
-			   size_t *len, unsigned int issue_flags);
+			   size_t *len, unsigned int issue_flags)
 {
 	return (struct io_br_sel) { .val = -EOPNOTSUPP };
 }


Thanks,
Ming