From: Dan Carpenter <dan.carpenter@linaro.org>
To: Jai Luthra <jai.luthra@ideasonboard.com>
Cc: Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
kernel-list@raspberrypi.com, Stefan Wahren <wahrenst@gmx.net>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Umang Jain <umang.jain@ideasonboard.com>
Subject: Re: [PATCH v2 0/5] staging: Destage VCHIQ interface and MMAL
Date: Mon, 8 Sep 2025 08:48:25 +0300 [thread overview]
Message-ID: <aL5uKTiEYZP68xLd@stanley.mountain> (raw)
In-Reply-To: <20250907-vchiq-destage-v2-0-6884505dca78@ideasonboard.com>
It's really hard to review the code when it's just sigle line like
this:
> .../raspberrypi/vchiq-interface}/vchiq_arm.c | 9 +-
It's also a head ache to do a cat -n filename and then copy and paste
it into an email message... I thought there was a trick to make the
diff show up in the email?
regards,
dan carpenter
next prev parent reply other threads:[~2025-09-08 5:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-07 8:56 [PATCH v2 0/5] staging: Destage VCHIQ interface and MMAL Jai Luthra
2025-09-07 8:56 ` [PATCH v2 1/5] include: linux: Destage VCHIQ interface headers Jai Luthra
2025-09-07 8:56 ` [PATCH v2 2/5] staging: vc04_services: Cleanup VCHIQ TODO entries Jai Luthra
2025-09-07 8:56 ` [PATCH v2 3/5] platform/broadcom: Destage VCHIQ interface Jai Luthra
2025-09-20 9:14 ` Stefan Wahren
2025-09-07 8:56 ` [PATCH v2 4/5] media: staging: Drop bcm2835-camera driver Jai Luthra
2025-09-07 8:56 ` [PATCH v2 5/5] platform/broadcom: Destage VCHIQ MMAL driver Jai Luthra
2025-09-08 4:19 ` Jai Luthra
2025-09-20 9:19 ` Stefan Wahren
2025-09-08 5:48 ` Dan Carpenter [this message]
2025-09-08 11:15 ` [PATCH v2 0/5] staging: Destage VCHIQ interface and MMAL Jai Luthra
2025-09-08 13:35 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aL5uKTiEYZP68xLd@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=jai.luthra@ideasonboard.com \
--cc=kernel-list@raspberrypi.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=umang.jain@ideasonboard.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.