* [PATCH] libxl: except Dom0 from setting PoD target
@ 2025-08-27 5:53 Jan Beulich
2025-08-28 1:08 ` Jason Andryuk
0 siblings, 1 reply; 4+ messages in thread
From: Jan Beulich @ 2025-08-27 5:53 UTC (permalink / raw)
To: xen-devel@lists.xenproject.org; +Cc: Anthony PERARD
Dom0 is never started in PoD mode, and hence it can at "best" do harm if
we try to set a PoD target for it.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/tools/libs/light/libxl_mem.c
+++ b/tools/libs/light/libxl_mem.c
@@ -306,7 +306,7 @@ retry_transaction:
}
}
- if (d_config.c_info.type != LIBXL_DOMAIN_TYPE_PV) {
+ if (domid && d_config.c_info.type != LIBXL_DOMAIN_TYPE_PV) {
r = xc_domain_set_pod_target(ctx->xch, domid,
(new_target_memkb + size) / 4, NULL, NULL, NULL);
if (r != 0) {
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] libxl: except Dom0 from setting PoD target
2025-08-27 5:53 [PATCH] libxl: except Dom0 from setting PoD target Jan Beulich
@ 2025-08-28 1:08 ` Jason Andryuk
2025-08-28 6:05 ` Jan Beulich
2025-09-08 12:46 ` Anthony PERARD
0 siblings, 2 replies; 4+ messages in thread
From: Jason Andryuk @ 2025-08-28 1:08 UTC (permalink / raw)
To: Jan Beulich, xen-devel@lists.xenproject.org; +Cc: Anthony PERARD
On 2025-08-27 01:53, Jan Beulich wrote:
> Dom0 is never started in PoD mode, and hence it can at "best" do harm if
> we try to set a PoD target for it.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Jason Andryuk <jason.andryuk@amd.com>
Did you observe an issue, or just notice this when inspecting the code?
If an issue, please add to the commit message.
Thanks,
Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] libxl: except Dom0 from setting PoD target
2025-08-28 1:08 ` Jason Andryuk
@ 2025-08-28 6:05 ` Jan Beulich
2025-09-08 12:46 ` Anthony PERARD
1 sibling, 0 replies; 4+ messages in thread
From: Jan Beulich @ 2025-08-28 6:05 UTC (permalink / raw)
To: Jason Andryuk; +Cc: Anthony PERARD, xen-devel@lists.xenproject.org
On 28.08.2025 03:08, Jason Andryuk wrote:
> On 2025-08-27 01:53, Jan Beulich wrote:
>> Dom0 is never started in PoD mode, and hence it can at "best" do harm if
>> we try to set a PoD target for it.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Reviewed-by: Jason Andryuk <jason.andryuk@amd.com>
Thanks.
> Did you observe an issue, or just notice this when inspecting the code?
It simply caught my eye while investigating the ballooning issue I sent
a mail about.
> If an issue, please add to the commit message.
I would have, sure.
Jan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] libxl: except Dom0 from setting PoD target
2025-08-28 1:08 ` Jason Andryuk
2025-08-28 6:05 ` Jan Beulich
@ 2025-09-08 12:46 ` Anthony PERARD
1 sibling, 0 replies; 4+ messages in thread
From: Anthony PERARD @ 2025-09-08 12:46 UTC (permalink / raw)
To: Jason Andryuk; +Cc: Jan Beulich, xen-devel@lists.xenproject.org, Anthony PERARD
On Wed, Aug 27, 2025 at 09:08:10PM -0400, Jason Andryuk wrote:
> On 2025-08-27 01:53, Jan Beulich wrote:
> > Dom0 is never started in PoD mode, and hence it can at "best" do harm if
> > we try to set a PoD target for it.
> >
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Reviewed-by: Jason Andryuk <jason.andryuk@amd.com>
Acked-by: Anthony PERARD <anthony.perard@vates.tech>
Thanks,
--
Anthony PERARD
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-09-08 12:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-27 5:53 [PATCH] libxl: except Dom0 from setting PoD target Jan Beulich
2025-08-28 1:08 ` Jason Andryuk
2025-08-28 6:05 ` Jan Beulich
2025-09-08 12:46 ` Anthony PERARD
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.