All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Mark Syms <mark.syms@cloud.com>
Cc: jgross@suse.com, andrew.cooper3@citrix.com,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2] Clarify the cases where BLKIF_RSP_EOPNOTSUPP can be returned.
Date: Mon, 1 Sep 2025 13:09:04 +0200	[thread overview]
Message-ID: <aLV-0C9J5MugXuF0@Mac.lan> (raw)
In-Reply-To: <20250829085627.407307-1-mark.syms@cloud.com>

On Fri, Aug 29, 2025 at 09:56:27AM +0100, Mark Syms wrote:
> Previously this said it would only happen on barrier writes. Except
> the documentation blocks for
>  * feature-flush-cache
>  * feature-discard

I cannot parse what "documentation blocks" means in this context.  I
would maybe write this as:

"Previously this said it would only happen on barrier writes.  However
Linux blkback and possibly other backends already return it when the
type of the requests is unknown.

Fix the comment to clarify the return code can be used as a reply to
any request types not understood by the backend, not just barrier
writes."

> 
> Also say that they can return this error.
> 
> Signed-off-by: Mark Syms <mark.syms@cloud.com>

Possibly with the commit message adjusted:

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


  reply	other threads:[~2025-09-01 11:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-28  9:38 [PATCH] Clarify the cases where BLKIF_RSP_EOPNOTSUPP can be returned Mark Syms
2025-08-29  7:41 ` Roger Pau Monné
2025-08-29  8:47   ` Mark Syms
2025-08-29  8:56 ` [PATCH v2] " Mark Syms
2025-09-01 11:09   ` Roger Pau Monné [this message]
2025-09-01 12:09   ` Jürgen Groß

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aLV-0C9J5MugXuF0@Mac.lan \
    --to=roger.pau@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jgross@suse.com \
    --cc=mark.syms@cloud.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.