All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Syms <mark.syms@cloud.com>
To: jgross@suse.com, roger.pau@citrix.com, andrew.cooper3@citrix.com,
	xen-devel@lists.xenproject.org
Cc: Mark Syms <mark.syms@cloud.com>
Subject: [PATCH] Clarify the cases where BLKIF_RSP_EOPNOTSUPP can be returned.
Date: Thu, 28 Aug 2025 10:38:21 +0100	[thread overview]
Message-ID: <20250828093821.372024-1-mark.syms@cloud.com> (raw)

Previously this said it would only happen on barrier writes. Except
the documentation blocks for
 * feature-flush-cache
 * feature-discard

Also say that they can return this error.

Signed-off-by: Mark Syms <mark.syms@cloud.com>
---
 xen/include/public/io/blkif.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/public/io/blkif.h b/xen/include/public/io/blkif.h
index 8407453324..5e617b0c67 100644
--- a/xen/include/public/io/blkif.h
+++ b/xen/include/public/io/blkif.h
@@ -710,7 +710,7 @@ typedef struct blkif_response blkif_response_t;
 /*
  * STATUS RETURN CODES.
  */
- /* Operation not supported (only happens on barrier writes). */
+ /* Operation not supported, see feature-barrier, feature-flush-cache, feature-discard. */
 #define BLKIF_RSP_EOPNOTSUPP  -2
  /* Operation failed for some unspecified reason (-EIO). */
 #define BLKIF_RSP_ERROR       -1
-- 
2.50.1



             reply	other threads:[~2025-08-28  9:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-28  9:38 Mark Syms [this message]
2025-08-29  7:41 ` [PATCH] Clarify the cases where BLKIF_RSP_EOPNOTSUPP can be returned Roger Pau Monné
2025-08-29  8:47   ` Mark Syms
2025-08-29  8:56 ` [PATCH v2] " Mark Syms
2025-09-01 11:09   ` Roger Pau Monné
2025-09-01 12:09   ` Jürgen Groß

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250828093821.372024-1-mark.syms@cloud.com \
    --to=mark.syms@cloud.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jgross@suse.com \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.