From: Yao Zi <ziyao@disroot.org>
To: Philipp Zabel <p.zabel@pengutronix.de>,
Drew Fustini <fustini@kernel.org>, Guo Ren <guoren@kernel.org>,
Fu Wei <wefu@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Michal Wilczynski <m.wilczynski@samsung.com>
Cc: devicetree@vger.kernel.org, Han Gao <gaohan@iscas.ac.cn>,
linux-kernel@vger.kernel.org, Han Gao <rabenda.cn@gmail.com>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH 1/4] dt-bindings: reset: thead,th1520-reset: Add controllers for more subsys
Date: Wed, 3 Sep 2025 00:41:57 +0000 [thread overview]
Message-ID: <aLeO1T1YM8_UorEr@pie> (raw)
In-Reply-To: <8de5763d7104a552f32196f04363d071548b7bba.camel@pengutronix.de>
On Tue, Sep 02, 2025 at 03:57:07PM +0200, Philipp Zabel wrote:
> On Mo, 2025-09-01 at 04:23 +0000, Yao Zi wrote:
> > TH1520 SoC is divided into several subsystems, most of them have
> > distinct reset controllers. Let's document reset controllers other than
> > the one for VO subsystem and IDs for their reset signals.
> >
> > Signed-off-by: Yao Zi <ziyao@disroot.org>
> > ---
> > .../bindings/reset/thead,th1520-reset.yaml | 8 +-
> > .../dt-bindings/reset/thead,th1520-reset.h | 219 +++++++++++++++++-
> > 2 files changed, 223 insertions(+), 4 deletions(-)
> >
> [...]
> > diff --git a/include/dt-bindings/reset/thead,th1520-reset.h b/include/dt-bindings/reset/thead,th1520-reset.h
> > index ee799286c175..927e251edfab 100644
> > --- a/include/dt-bindings/reset/thead,th1520-reset.h
> > +++ b/include/dt-bindings/reset/thead,th1520-reset.h
> > @@ -7,11 +7,186 @@
> [...]
> > +/* AP Subsystem */
> [...]
> > +#define TH1520_RESET_ID_C910_C0 5
> > +#define TH1520_RESET_ID_C910_C1 5
> > +#define TH1520_RESET_ID_C910_C2 5
> > +#define TH1520_RESET_ID_C910_C3 5
>
> As the kernel test robot already noticed, this doesn't seem right.
Yes, this is a copy-paste error. I'll fix it and run static check before
sending v2. Thanks.
> regards
> Philipp
Best regards,
Yao Zi
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Yao Zi <ziyao@disroot.org>
To: Philipp Zabel <p.zabel@pengutronix.de>,
Drew Fustini <fustini@kernel.org>, Guo Ren <guoren@kernel.org>,
Fu Wei <wefu@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Michal Wilczynski <m.wilczynski@samsung.com>
Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Icenowy Zheng <uwu@icenowy.me>,
Han Gao <rabenda.cn@gmail.com>, Han Gao <gaohan@iscas.ac.cn>
Subject: Re: [PATCH 1/4] dt-bindings: reset: thead,th1520-reset: Add controllers for more subsys
Date: Wed, 3 Sep 2025 00:41:57 +0000 [thread overview]
Message-ID: <aLeO1T1YM8_UorEr@pie> (raw)
In-Reply-To: <8de5763d7104a552f32196f04363d071548b7bba.camel@pengutronix.de>
On Tue, Sep 02, 2025 at 03:57:07PM +0200, Philipp Zabel wrote:
> On Mo, 2025-09-01 at 04:23 +0000, Yao Zi wrote:
> > TH1520 SoC is divided into several subsystems, most of them have
> > distinct reset controllers. Let's document reset controllers other than
> > the one for VO subsystem and IDs for their reset signals.
> >
> > Signed-off-by: Yao Zi <ziyao@disroot.org>
> > ---
> > .../bindings/reset/thead,th1520-reset.yaml | 8 +-
> > .../dt-bindings/reset/thead,th1520-reset.h | 219 +++++++++++++++++-
> > 2 files changed, 223 insertions(+), 4 deletions(-)
> >
> [...]
> > diff --git a/include/dt-bindings/reset/thead,th1520-reset.h b/include/dt-bindings/reset/thead,th1520-reset.h
> > index ee799286c175..927e251edfab 100644
> > --- a/include/dt-bindings/reset/thead,th1520-reset.h
> > +++ b/include/dt-bindings/reset/thead,th1520-reset.h
> > @@ -7,11 +7,186 @@
> [...]
> > +/* AP Subsystem */
> [...]
> > +#define TH1520_RESET_ID_C910_C0 5
> > +#define TH1520_RESET_ID_C910_C1 5
> > +#define TH1520_RESET_ID_C910_C2 5
> > +#define TH1520_RESET_ID_C910_C3 5
>
> As the kernel test robot already noticed, this doesn't seem right.
Yes, this is a copy-paste error. I'll fix it and run static check before
sending v2. Thanks.
> regards
> Philipp
Best regards,
Yao Zi
next prev parent reply other threads:[~2025-09-03 0:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 4:23 [PATCH 0/4] Add reset controllers for other TH1520 subsystems Yao Zi
2025-09-01 4:23 ` Yao Zi
2025-09-01 4:23 ` [PATCH 1/4] dt-bindings: reset: thead,th1520-reset: Add controllers for more subsys Yao Zi
2025-09-01 4:23 ` Yao Zi
2025-09-02 8:27 ` Krzysztof Kozlowski
2025-09-02 8:27 ` Krzysztof Kozlowski
2025-09-02 9:04 ` Yao Zi
2025-09-02 9:04 ` Yao Zi
2025-09-02 13:44 ` Krzysztof Kozlowski
2025-09-02 13:44 ` Krzysztof Kozlowski
2025-09-02 13:57 ` Philipp Zabel
2025-09-02 13:57 ` Philipp Zabel
2025-09-02 15:43 ` Krzysztof Kozlowski
2025-09-02 15:43 ` Krzysztof Kozlowski
2025-09-02 13:57 ` Philipp Zabel
2025-09-02 13:57 ` Philipp Zabel
2025-09-03 0:41 ` Yao Zi [this message]
2025-09-03 0:41 ` Yao Zi
2025-09-01 4:23 ` [PATCH 2/4] reset: th1520: Prepare for supporting multiple controllers Yao Zi
2025-09-01 4:23 ` Yao Zi
2025-09-01 4:23 ` [PATCH 3/4] reset: th1520: Support reset controllers in more subsystems Yao Zi
2025-09-01 4:23 ` Yao Zi
2025-09-02 10:50 ` kernel test robot
2025-09-02 10:50 ` kernel test robot
2025-09-02 14:15 ` Maud Spierings
2025-09-02 14:15 ` Maud Spierings
2025-09-03 0:44 ` Yao Zi
2025-09-03 0:44 ` Yao Zi
2025-09-01 4:23 ` [PATCH 4/4] riscv: dts: thead: Add reset controllers of more subsystems for TH1520 Yao Zi
2025-09-01 4:23 ` Yao Zi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLeO1T1YM8_UorEr@pie \
--to=ziyao@disroot.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fustini@kernel.org \
--cc=gaohan@iscas.ac.cn \
--cc=guoren@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=m.wilczynski@samsung.com \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rabenda.cn@gmail.com \
--cc=robh@kernel.org \
--cc=wefu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.