All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH v2 2/7] tests: monitor: Support running all tests in one go
Date: Wed, 3 Sep 2025 13:04:07 +0200	[thread overview]
Message-ID: <aLggp4FFR3fN-1dk@orbyte.nwl.cc> (raw)
In-Reply-To: <aLcCr2YxUkRFH6UH@calendula>

On Tue, Sep 02, 2025 at 04:43:59PM +0200, Pablo Neira Ayuso wrote:
> On Fri, Aug 29, 2025 at 05:51:58PM +0200, Phil Sutter wrote:
> > Detect RUN_FULL_TESTSUITE env variable set by automake and do an
> > "unattended" full testrun.
> 
> This test is so small that I think it is better to enable both modes:
> w/json and w/o json by default.

ACK, good point. I just investigated and it is feasible to use the
stored JSON output for testing '--echo --json' as well. So I can extend
the test suite to test echo and monitor mode for both standard and JSON
syntax.

Thanks, Phil

  reply	other threads:[~2025-09-03 11:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-29 15:51 [nft PATCH v2 0/7] Run all test suites via 'make check' Phil Sutter
2025-08-29 15:51 ` [nft PATCH v2 1/7] tests: Prepare exit codes for automake Phil Sutter
2025-08-29 15:51 ` [nft PATCH v2 2/7] tests: monitor: Support running all tests in one go Phil Sutter
2025-09-02 14:43   ` Pablo Neira Ayuso
2025-09-03 11:04     ` Phil Sutter [this message]
2025-08-29 15:51 ` [nft PATCH v2 3/7] tests: py: Set default options based on RUN_FULL_TESTSUITE Phil Sutter
2025-09-02 15:33   ` Pablo Neira Ayuso
2025-09-03 11:13     ` Phil Sutter
2025-08-29 15:52 ` [nft PATCH v2 4/7] tests: json_echo: Skip if run as non-root Phil Sutter
2025-08-29 15:52 ` [nft PATCH v2 5/7] tests: shell: Skip packetpath/nat_ftp in fake root env Phil Sutter
2025-08-29 15:52 ` [nft PATCH v2 6/7] tests: build: Do not assume caller's CWD Phil Sutter
2025-08-29 15:52 ` [nft PATCH v2 7/7] Makefile: Enable support for 'make check' Phil Sutter
2025-09-02 14:45   ` Pablo Neira Ayuso
2025-09-03 11:06     ` Phil Sutter
2025-09-03 11:11       ` Pablo Neira Ayuso
2025-09-03 11:17         ` Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aLggp4FFR3fN-1dk@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.