Re: [nft PATCH v2 7/7] Makefile: Enable support for 'make check'

[Phil Sutter <phil@nwl.cc>]

On Wed, Sep 03, 2025 at 01:11:15PM +0200, Pablo Neira Ayuso wrote:
> On Wed, Sep 03, 2025 at 01:06:43PM +0200, Phil Sutter wrote:
> > On Tue, Sep 02, 2025 at 04:45:43PM +0200, Pablo Neira Ayuso wrote:
> > > On Fri, Aug 29, 2025 at 05:52:03PM +0200, Phil Sutter wrote:
> > > > Add the various testsuite runners to TESTS variable and have make call
> > > > them with RUN_FULL_TESTSUITE=1 env var.
> > > 
> > > Given you add a env var for every test, would you instead use
> > > distcheck-hook: in Makefile.am to short circuit the test run and
> > > display SKIPPED?
> > 
> > I don't follow, sorry. The RUN_FULL_TESTSUITE variable is merely used to
> > enable "run all variants"-mode in test suites.
> 
> For make check, I think tests should be updated to run all variants by
> default. Then provide options to run independent variants.
> 
> > Test suites are skipped only if they require root and caller is not
> > - one may still run 'make check' as root or not, irrespective of the
> > hack to leave 'make distcheck' alone.
> 
> Right, I call diskcheck as non-root.
> 
> Maybe we can just skip tests for non-root when make check is called.

I had considered this, but dropping the fakeroot functionality from
shell test suite just for that feels wrong (and is pretty tedious as
well). Keeping it, letting 'make check' run as much as possible and
making sure 'make distcheck' remains unaffected is a cleaner solution
IMO.

> If the tests are updated to run all variants by default, then
> RUN_FULL_TESTSUITE is not needed.

ACK, I'll work on that. It will also improve live for non-"make check"
users.

Thanks, Phil