From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH v3 00/11] Run all test suites via 'make check'
Date: Thu, 4 Sep 2025 17:15:39 +0200 [thread overview]
Message-ID: <aLmtG3euLlPaGbZ6@orbyte.nwl.cc> (raw)
In-Reply-To: <20250903172259.26266-1-phil@nwl.cc>
On Wed, Sep 03, 2025 at 07:22:48PM +0200, Phil Sutter wrote:
> Help me (and maybe others) to not occasionally forget to run this or
> that test suite in this or that mode:
>
> Have test suites execute all variants by default (patches 5 and 6),
> make sure their exit codes
> match Automake expectations (patch 7) and register them with Automake
> (patch 11). Also fix for running 'make check' as non-root (patches 8 and
> 9) and calling build test suite from outside its directory (patch 10).
>
> The first four patches are fallout from enabling all variants by default
> in monitor test suite, which includes implementing previously missing
> JSON echo testing.
>
> Changes since v2:
> - Drop the need for RUN_FULL_TESTSUITE env var by making the "all
> variants" mode the default in all test suites
> - Implement JSON echo testing into monitor test suite, stored JSON
> output matches echo output after minor adjustment
>
> Changes since v1:
> - Also integrate build test suite
> - Populate TESTS variable only for non-distcheck builds, so 'make
> distcheck' does not run any test suite
>
> Phil Sutter (11):
> tests: monitor: Label diffs to help users
> tests: monitor: Fix regex collecting expected echo output
> tests: monitor: Test JSON echo mode as well
> tests: monitor: Extend debug output a bit
Applied these four patches as they are pretty harmless and not related
to the remaining series.
Cheers, Phil
prev parent reply other threads:[~2025-09-04 15:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 17:22 [nft PATCH v3 00/11] Run all test suites via 'make check' Phil Sutter
2025-09-03 17:22 ` [nft PATCH v3 01/11] tests: monitor: Label diffs to help users Phil Sutter
2025-09-03 17:22 ` [nft PATCH v3 02/11] tests: monitor: Fix regex collecting expected echo output Phil Sutter
2025-09-03 17:22 ` [nft PATCH v3 03/11] tests: monitor: Test JSON echo mode as well Phil Sutter
2025-09-03 17:22 ` [nft PATCH v3 04/11] tests: monitor: Extend debug output a bit Phil Sutter
2025-09-03 17:22 ` [nft PATCH v3 05/11] tests: monitor: Excercise all syntaxes and variants by default Phil Sutter
2025-09-03 17:22 ` [nft PATCH v3 06/11] tests: py: Enable JSON and JSON schema " Phil Sutter
2025-09-04 15:24 ` Pablo Neira Ayuso
2025-09-03 17:22 ` [nft PATCH v3 07/11] tests: Prepare exit codes for automake Phil Sutter
2025-09-03 17:22 ` [nft PATCH v3 08/11] tests: json_echo: Skip if run as non-root Phil Sutter
2025-09-03 17:22 ` [nft PATCH v3 09/11] tests: shell: Skip packetpath/nat_ftp in fake root env Phil Sutter
2025-09-03 17:22 ` [nft PATCH v3 10/11] tests: build: Do not assume caller's CWD Phil Sutter
2025-09-03 17:22 ` [nft PATCH v3 11/11] Makefile: Enable support for 'make check' Phil Sutter
2025-09-04 15:24 ` Pablo Neira Ayuso
2025-09-04 15:25 ` Pablo Neira Ayuso
2025-09-04 15:32 ` Phil Sutter
2025-09-04 16:21 ` Phil Sutter
2025-09-04 16:57 ` Pablo Neira Ayuso
2025-09-04 18:39 ` Phil Sutter
2025-09-11 12:02 ` Phil Sutter
2025-09-11 15:13 ` Pablo Neira Ayuso
2025-09-04 15:15 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLmtG3euLlPaGbZ6@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.