All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>, netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH v3 11/11] Makefile: Enable support for 'make check'
Date: Thu, 11 Sep 2025 14:02:37 +0200	[thread overview]
Message-ID: <aMK6XUffoFcnzkXM@orbyte.nwl.cc> (raw)
In-Reply-To: <aLnc7AidZLW9dCbY@orbyte.nwl.cc>

Hi Pablo,

On Thu, Sep 04, 2025 at 08:39:40PM +0200, Phil Sutter wrote:
> On Thu, Sep 04, 2025 at 06:57:52PM +0200, Pablo Neira Ayuso wrote:
[...]
> > distcheck-hook: could set a env var so test just print a [SKIP].
> > 
> > Similar to your previous approach with the env var, but logic reversed.
> 
> I don't think the 'make distcheck-hook' call is able to inject variables
> into the following 'make check' call's environment. It could create a
> special file though which all test suites recognize and exit 77
> immediately.

What are your thoughts about this? IMO, the special configure option is
much cleaner than creating a special file and patching all test runners
to check for it. It should be doable though, so if you prefer this I
don't mind.

Thanks, Phil

  reply	other threads:[~2025-09-11 12:02 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-03 17:22 [nft PATCH v3 00/11] Run all test suites via 'make check' Phil Sutter
2025-09-03 17:22 ` [nft PATCH v3 01/11] tests: monitor: Label diffs to help users Phil Sutter
2025-09-03 17:22 ` [nft PATCH v3 02/11] tests: monitor: Fix regex collecting expected echo output Phil Sutter
2025-09-03 17:22 ` [nft PATCH v3 03/11] tests: monitor: Test JSON echo mode as well Phil Sutter
2025-09-03 17:22 ` [nft PATCH v3 04/11] tests: monitor: Extend debug output a bit Phil Sutter
2025-09-03 17:22 ` [nft PATCH v3 05/11] tests: monitor: Excercise all syntaxes and variants by default Phil Sutter
2025-09-03 17:22 ` [nft PATCH v3 06/11] tests: py: Enable JSON and JSON schema " Phil Sutter
2025-09-04 15:24   ` Pablo Neira Ayuso
2025-09-03 17:22 ` [nft PATCH v3 07/11] tests: Prepare exit codes for automake Phil Sutter
2025-09-03 17:22 ` [nft PATCH v3 08/11] tests: json_echo: Skip if run as non-root Phil Sutter
2025-09-03 17:22 ` [nft PATCH v3 09/11] tests: shell: Skip packetpath/nat_ftp in fake root env Phil Sutter
2025-09-03 17:22 ` [nft PATCH v3 10/11] tests: build: Do not assume caller's CWD Phil Sutter
2025-09-03 17:22 ` [nft PATCH v3 11/11] Makefile: Enable support for 'make check' Phil Sutter
2025-09-04 15:24   ` Pablo Neira Ayuso
2025-09-04 15:25     ` Pablo Neira Ayuso
2025-09-04 15:32       ` Phil Sutter
2025-09-04 16:21     ` Phil Sutter
2025-09-04 16:57       ` Pablo Neira Ayuso
2025-09-04 18:39         ` Phil Sutter
2025-09-11 12:02           ` Phil Sutter [this message]
2025-09-11 15:13             ` Pablo Neira Ayuso
2025-09-04 15:15 ` [nft PATCH v3 00/11] Run all test suites via " Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aMK6XUffoFcnzkXM@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.