Re: [PATCH v15 0/5] rust: adds Bitmap API, ID pool and bindings

[Yury Norov <yury.norov@gmail.com>]

On Sat, Sep 06, 2025 at 12:18:38PM +0300, Dan Carpenter wrote:
> Nope.  Try again.
> 
> diff --git a/rust/kernel/bitmap.rs b/rust/kernel/bitmap.rs
> index 6e0824579781..2f00e91e9c35 100644
> --- a/rust/kernel/bitmap.rs
> +++ b/rust/kernel/bitmap.rs
> @@ -551,18 +551,21 @@ fn bitmap_set_clear_find() -> Result<(), AllocError> {
>          Ok(())
>      }
>  
> -    #[cfg(not(CONFIG_RUST_BITMAP_HARDENED))]
>      #[test]
>      fn owned_bitmap_out_of_bounds() -> Result<(), AllocError> {
> -        let mut b = BitmapVec::new(128, GFP_KERNEL)?;
> +        #[cfg(not(CONFIG_RUST_BITMAP_HARDENED))]
> +        {
> +            let mut b = BitmapVec::new(128, GFP_KERNEL)?;
> +
> +            b.set_bit(2048);
> +            b.set_bit_atomic(2048);
> +            b.clear_bit(2048);
> +            b.clear_bit_atomic(2048);
> +            assert_eq!(None, b.next_bit(2048));
> +            assert_eq!(None, b.next_zero_bit(2048));
> +            assert_eq!(None, b.last_bit());
> +        }
>  
> -        b.set_bit(2048);
> -        b.set_bit_atomic(2048);
> -        b.clear_bit(2048);
> -        b.clear_bit_atomic(2048);
> -        assert_eq!(None, b.next_bit(2048));
> -        assert_eq!(None, b.next_zero_bit(2048));
> -        assert_eq!(None, b.last_bit());
>          Ok(())
>      }

Alright, the testing is definitely failed. I'll drop the series and
let Burak to send v16 with all fixes merged.

Thanks,
Yury