All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yao Zi <ziyao@disroot.org>
To: Xukai Wang <kingxukai@zohomail.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Conor Dooley <conor@kernel.org>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	Samuel Holland <samuel.holland@sifive.com>,
	Troy Mitchell <TroyMitchell988@gmail.com>
Subject: Re: [PATCH v8 2/3] clk: canaan: Add clock driver for Canaan K230
Date: Sun, 7 Sep 2025 03:17:26 +0000	[thread overview]
Message-ID: <aLz5RsjBoi0KVGSJ@pie> (raw)
In-Reply-To: <aLz4Q7LZFEfQQGUj@pie>

On Sun, Sep 07, 2025 at 03:13:07AM +0000, Yao Zi wrote:
> > +struct k230_clk_rate_self {
> > +	struct clk_hw	hw;
> > +	void __iomem	*reg;
> > +	bool		read_only;
> 
> Isn't a read-only multiplier, divider or something capable of both a
> simple fixed-factor hardware? If so please switch to the existing clock
> hardware, instead of introducing a field in description of rate clocks.
> 
> It's worth noting that you've already had at least one fixed-rate clock
> (shrm_sram_div2).

It should be "fixed-factor" clock instead of "fixed-rate" clock, sorry
for the typo.

Regards,
Yao Zi

WARNING: multiple messages have this Message-ID (diff)
From: Yao Zi <ziyao@disroot.org>
To: Xukai Wang <kingxukai@zohomail.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Conor Dooley <conor@kernel.org>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	Samuel Holland <samuel.holland@sifive.com>,
	Troy Mitchell <TroyMitchell988@gmail.com>
Subject: Re: [PATCH v8 2/3] clk: canaan: Add clock driver for Canaan K230
Date: Sun, 7 Sep 2025 03:17:26 +0000	[thread overview]
Message-ID: <aLz5RsjBoi0KVGSJ@pie> (raw)
In-Reply-To: <aLz4Q7LZFEfQQGUj@pie>

On Sun, Sep 07, 2025 at 03:13:07AM +0000, Yao Zi wrote:
> > +struct k230_clk_rate_self {
> > +	struct clk_hw	hw;
> > +	void __iomem	*reg;
> > +	bool		read_only;
> 
> Isn't a read-only multiplier, divider or something capable of both a
> simple fixed-factor hardware? If so please switch to the existing clock
> hardware, instead of introducing a field in description of rate clocks.
> 
> It's worth noting that you've already had at least one fixed-rate clock
> (shrm_sram_div2).

It should be "fixed-factor" clock instead of "fixed-rate" clock, sorry
for the typo.

Regards,
Yao Zi

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2025-09-07  3:17 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-05  3:10 [PATCH v8 0/3] riscv: canaan: Add support for K230 clock Xukai Wang
2025-09-05  3:10 ` Xukai Wang
2025-09-05  3:10 ` [PATCH v8 1/3] dt-bindings: clock: Add bindings for Canaan K230 clock controller Xukai Wang
2025-09-05  3:10   ` Xukai Wang
2025-09-05  3:10 ` [PATCH v8 2/3] clk: canaan: Add clock driver for Canaan K230 Xukai Wang
2025-09-05  3:10   ` Xukai Wang
2025-09-05  4:12   ` Xukai Wang
2025-09-05  4:12     ` Xukai Wang
2025-09-07  3:13   ` Yao Zi
2025-09-07  3:13     ` Yao Zi
2025-09-07  3:17     ` Yao Zi [this message]
2025-09-07  3:17       ` Yao Zi
2025-09-08 14:13     ` Xukai Wang
2025-09-08 14:13       ` Xukai Wang
2025-09-09  2:51       ` Yao Zi
2025-09-09  2:51         ` Yao Zi
2025-09-09  5:01         ` Xukai Wang
2025-09-09  5:01           ` Xukai Wang
2025-09-09  7:02       ` Vivian Wang
2025-09-09  7:02         ` Vivian Wang
2025-09-10  8:38         ` Xukai Wang
2025-09-10  8:38           ` Xukai Wang
2025-09-05  3:10 ` [PATCH v8 3/3] riscv: dts: canaan: Add clock definition for K230 Xukai Wang
2025-09-05  3:10   ` Xukai Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aLz5RsjBoi0KVGSJ@pie \
    --to=ziyao@disroot.org \
    --cc=TroyMitchell988@gmail.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kingxukai@zohomail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh@kernel.org \
    --cc=samuel.holland@sifive.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.