From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "Hubert Wiśniewski" <hubert.wisniewski.25632@gmail.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
stable@vger.kernel.org, kernel@pengutronix.de,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
"Lukas Wunner" <lukas@wunner.de>,
"Russell King" <linux@armlinux.org.uk>,
"Xu Yang" <xu.yang_2@nxp.com>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH net v1 1/1] net: usb: asix: ax88772: drop phylink use in PM to avoid MDIO runtime PM wakeups
Date: Wed, 10 Sep 2025 06:16:48 +0200 [thread overview]
Message-ID: <aMD7sFlcQJpOK51B@pengutronix.de> (raw)
In-Reply-To: <20250909165645.755e52f6@kernel.org>
On Tue, Sep 09, 2025 at 04:56:45PM -0700, Jakub Kicinski wrote:
> On Tue, 9 Sep 2025 09:17:17 +0200 Oleksij Rempel wrote:
> > > > Fixes: e0bffe3e6894 ("net: asix: ax88772: migrate to phylink")
> > >
> > > It does, but v5.15 (including v5.15.191 LTS) is affected as well, from
> > > 4a2c7217cd5a ("net: usb: asix: ax88772: manage PHY PM from MAC"). I think
> > > it could also use a patch, but I won't insist.
> >
> > Ack, I'll try do address it later.
>
> Any idea what the problem is there? Deadlocking on a different lock?
Yes, it is PM lock taken in MDIO access inside of PM routine. We can't
reliably detect a PM context from MDIO bus read/write calls. Taking
local counters or setting flags would partially work, but they all are
not safe against race conditions.
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2025-09-10 4:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250911135853eucas1p283b1afd37287b715403cd2cdbfa03a94@eucas1p2.samsung.com>
2025-09-08 11:26 ` [PATCH net v1 1/1] net: usb: asix: ax88772: drop phylink use in PM to avoid MDIO runtime PM wakeups Oleksij Rempel
2025-09-08 17:00 ` Hubert Wiśniewski
2025-09-09 7:17 ` Oleksij Rempel
2025-09-09 23:56 ` Jakub Kicinski
2025-09-10 4:16 ` Oleksij Rempel [this message]
2025-09-09 2:05 ` Xu Yang
2025-09-09 23:58 ` Jakub Kicinski
2025-09-10 4:11 ` Oleksij Rempel
2025-09-11 0:50 ` Jakub Kicinski
2025-09-11 1:00 ` patchwork-bot+netdevbpf
2025-09-11 13:58 ` Marek Szyprowski
2025-09-11 14:39 ` Russell King (Oracle)
2025-09-11 14:55 ` Jakub Kicinski
2025-09-11 20:46 ` Russell King (Oracle)
2025-09-12 2:30 ` Alan Stern
2025-09-12 8:33 ` Russell King (Oracle)
2025-09-12 14:29 ` Alan Stern
2025-09-12 14:37 ` Russell King (Oracle)
2025-09-13 6:45 ` Oleksij Rempel
2025-09-16 7:18 ` Oleksij Rempel
2025-09-16 14:42 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMD7sFlcQJpOK51B@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hubert.wisniewski.25632@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukas@wunner.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.