From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

[Andy Shevchenko]

clang is not happy about set but unused variable:

kernel/kexec_core.c:745:16: error: variable 'maddr' set but not used [-Werror,-Wunused-but-set-variable]
  745 |         unsigned long maddr;
      |                       ^
1 error generated.

Fix the compilation breakage (`make W=1` build) by removing unused variable.

As Nathan noted, GCC 16 produces the similar warning;

Fixes: f4fecb50d6e1 ("kexec_core: remove superfluous page offset handling in segment loading")
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---

v2: fixed Fixes (Nathan), added a note about GCC (Nathan), added tag (Nathan)

 kernel/kexec_core.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
index 5357ed39e9d1..32722926bc7e 100644
--- a/kernel/kexec_core.c
+++ b/kernel/kexec_core.c
@@ -742,7 +742,6 @@ static int kimage_load_cma_segment(struct kimage *image, int idx)
 	struct kexec_segment *segment = &image->segment[idx];
 	struct page *cma = image->segment_cma[idx];
 	char *ptr = page_address(cma);
-	unsigned long maddr;
 	size_t ubytes, mbytes;
 	int result = 0;
 	unsigned char __user *buf = NULL;
@@ -754,7 +753,6 @@ static int kimage_load_cma_segment(struct kimage *image, int idx)
 		buf = segment->buf;
 	ubytes = segment->bufsz;
 	mbytes = segment->memsz;
-	maddr = segment->mem;
 
 	/* Then copy from source buffer to the CMA one */
 	while (mbytes) {
@@ -782,7 +780,6 @@ static int kimage_load_cma_segment(struct kimage *image, int idx)
 		}
 
 		ptr    += mchunk;
-		maddr  += mchunk;
 		mbytes -= mchunk;
 
 		cond_resched();
-- 
2.50.1

Re: From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

[Andy Shevchenko]

On Tue, Sep 16, 2025 at 02:29:49PM +0200, Andy Shevchenko wrote:

My gosh, the Subject is mangled, sorry, I resend it ASAP after double checking
it's fine looking.

-- 
With Best Regards,
Andy Shevchenko

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

[Andy Shevchenko]

This is the subset of the patches [1] that should not affect any
functionality. Here is the unification of ID tables, a couple of
function prototypes, and other small cleanups.

In any case this is Cc'ed to AMD who reported a problem in [1]
presumably in the patch that is *not* included here.

Link: https://lore.kernel.org/linux-i2c/20231207141653.2785124-1-andriy.shevchenko@linux.intel.com/ [1]

v3:
- fixed one more rebase issue in patch 5 (LKP)

v2:
- fixed rebase issue in patch 5 (LKP)

Andy Shevchenko (7):
  i2c: designware: Replace a while-loop by for-loop
  i2c: designware: Let PCI core to take care about interrupt vectors
  i2c: designware: Add missing 'c' into PCI IDs variable name
  i2c: designware: Unify terminator in device ID tables
  i2c: designware: Always provide device ID tables
  i2c: designware: Drop return value from i2c_dw_acpi_configure()
  i2c: designware: Drop return value from dw_i2c_of_configure()

 drivers/i2c/busses/i2c-designware-common.c  |  4 +-
 drivers/i2c/busses/i2c-designware-core.h    |  4 +-
 drivers/i2c/busses/i2c-designware-pcidrv.c  | 22 ++----
 drivers/i2c/busses/i2c-designware-platdrv.c | 76 +++++++++------------
 4 files changed, 44 insertions(+), 62 deletions(-)

-- 
2.43.0.rc1.1336.g36b5255a03ac

Re: From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

[Andi Shyti]

Hi Andy,

On Mon, Aug 19, 2024 at 09:45:06PM GMT, Andy Shevchenko wrote:
> This is the subset of the patches [1] that should not affect any
> functionality. Here is the unification of ID tables, a couple of
> function prototypes, and other small cleanups.
> 
> In any case this is Cc'ed to AMD who reported a problem in [1]
> presumably in the patch that is *not* included here.
> 
> Link: https://lore.kernel.org/linux-i2c/20231207141653.2785124-1-andriy.shevchenko@linux.intel.com/ [1]
> 
> v3:
> - fixed one more rebase issue in patch 5 (LKP)
> 
> v2:
> - fixed rebase issue in patch 5 (LKP)
> 
> Andy Shevchenko (7):
>   i2c: designware: Replace a while-loop by for-loop
>   i2c: designware: Let PCI core to take care about interrupt vectors
>   i2c: designware: Add missing 'c' into PCI IDs variable name
>   i2c: designware: Unify terminator in device ID tables
>   i2c: designware: Always provide device ID tables
>   i2c: designware: Drop return value from i2c_dw_acpi_configure()
>   i2c: designware: Drop return value from dw_i2c_of_configure()

It all applies neatly on my branch and it's all reviewed by me.
I will keep it for a few more days so that others have a chance
to review this series as well.

Thanks,
Andi

Re: From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

[Andi Shyti]

Hi Andy,

All merged to i2c/i2c-host.

Thanks,
Andi

On Mon, Aug 19, 2024 at 09:45:06PM GMT, Andy Shevchenko wrote:
> This is the subset of the patches [1] that should not affect any
> functionality. Here is the unification of ID tables, a couple of
> function prototypes, and other small cleanups.
> 
> In any case this is Cc'ed to AMD who reported a problem in [1]
> presumably in the patch that is *not* included here.
> 
> Link: https://lore.kernel.org/linux-i2c/20231207141653.2785124-1-andriy.shevchenko@linux.intel.com/ [1]
> 
> v3:
> - fixed one more rebase issue in patch 5 (LKP)
> 
> v2:
> - fixed rebase issue in patch 5 (LKP)
> 
> Andy Shevchenko (7):
>   i2c: designware: Replace a while-loop by for-loop
>   i2c: designware: Let PCI core to take care about interrupt vectors
>   i2c: designware: Add missing 'c' into PCI IDs variable name
>   i2c: designware: Unify terminator in device ID tables
>   i2c: designware: Always provide device ID tables
>   i2c: designware: Drop return value from i2c_dw_acpi_configure()
>   i2c: designware: Drop return value from dw_i2c_of_configure()
> 
>  drivers/i2c/busses/i2c-designware-common.c  |  4 +-
>  drivers/i2c/busses/i2c-designware-core.h    |  4 +-
>  drivers/i2c/busses/i2c-designware-pcidrv.c  | 22 ++----
>  drivers/i2c/busses/i2c-designware-platdrv.c | 76 +++++++++------------
>  4 files changed, 44 insertions(+), 62 deletions(-)
> 
> -- 
> 2.43.0.rc1.1336.g36b5255a03ac
> 

Re: From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

[Andy Shevchenko]

On Wed, Aug 21, 2024 at 04:11:44PM +0200, Andi Shyti wrote:
> Hi Andy,
> 
> All merged to i2c/i2c-host.

Thank you!

-- 
With Best Regards,
Andy Shevchenko