Re: [PATCH v2 1/3] dt-bindings: riscv: Add Ssqosid extension description

From: Drew Fustini <fustini@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: "Paul Walmsley" <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexandre Ghiti" <alex@ghiti.fr>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Kornel Dulęba" <mindal@semihalf.com>,
	"Adrien Ricciardi" <aricciardi@baylibre.com>,
	"James Morse" <james.morse@arm.com>,
	"Atish Kumar Patra" <atishp@rivosinc.com>,
	"Atish Patra" <atish.patra@linux.dev>,
	"Vasudevan Srinivasan" <vasu@rivosinc.com>,
	guo.wenjia23@zte.com.cn, liu.qingtao2@zte.com.cn,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: riscv: Add Ssqosid extension description
Date: Tue, 16 Sep 2025 13:00:14 -0700	[thread overview]
Message-ID: <aMnBzqgoUrLMAtxw@x1> (raw)
In-Reply-To: <aMm4n2PlI8JqmK2c@x1>

[-- Attachment #1.1: Type: text/plain, Size: 2221 bytes --]

On Tue, Sep 16, 2025 at 12:21:03PM -0700, Drew Fustini wrote:
> On Tue, Sep 16, 2025 at 07:36:01PM +0100, Conor Dooley wrote:
> > On Mon, Sep 15, 2025 at 10:13:41PM -0700, Drew Fustini wrote:
> > > Document the ratified Supervisor-mode Quality of Service ID (Ssqosid)
> > > extension v1.0.
> > > 
> > > Link: https://github.com/riscv/riscv-ssqosid/releases/tag/v1.0
> > > Signed-off-by: Drew Fustini <fustini@kernel.org>
> > > ---
> > >  Documentation/devicetree/bindings/riscv/extensions.yaml | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/riscv/extensions.yaml b/Documentation/devicetree/bindings/riscv/extensions.yaml
> > > index ede6a58ccf5347d92785dc085a011052c1aade14..38e3d8d38cce55022ea70eb52423b1163e3cb097 100644
> > > --- a/Documentation/devicetree/bindings/riscv/extensions.yaml
> > > +++ b/Documentation/devicetree/bindings/riscv/extensions.yaml
> > > @@ -165,6 +165,12 @@ properties:
> > >              ratified at commit d70011dde6c2 ("Update to ratified state")
> > >              of riscv-j-extension.
> > >  
> > > +        - const: ssqosid
> > > +          description: |
> > > +            The ratified Supervisor-mode Quality of Service ID (Ssqosid)
> > > +            extension v1.0 which adds the Supervisor Resource Management
> > > +            Configuration (srmcfg) CSR.
> > 
> > Please cite when it was added, as is done for other extensions.
> 
> I had seen the pattern of commit X from Unpriv or Priv spec but I was
> having trouble adapting that for Ssqosid as it has its own v1.0 PDF.
> 
> However, I now notice 'zacas' seems to have its own spec. Would this
> work for 'ssqosid'?
> 
>         - const: ssqosid
>           description: |
>             The Ssqosid extension for Quality of Service ID is ratified
> 	      as v1.0 in commit 5059e0ca641c of riscv-ssqosid.

I'll change it to use the kernel style of commit reference:

        - const: ssqosid
          description: |
            The Ssqosid extension for Quality of Service ID is ratified
            as v1.0 in commit 5059e0ca641c  ("Merge pull request #7 from
	    ved-rivos/Ratified") of riscv-ssqosid.

-Drew

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv