[PATCH] perf test attr: Add missing int_mist.uop_dropping event to test-stat files

[PATCH] perf test attr: Add missing int_mist.uop_dropping event to test-stat files

[Trevor Allison]

Setup struct perf-event-attr test was failing on EMR cpu because perf stat
was providing an event that was not included in the test. Type 4 Config 4269
or 10ad, int_misc.uop_dropping.

Add event type=4 config=4269 to test-stat-default and test-stat-detailed-*
files with optional=1 so EMR machines can pass test

Signed-off-by: Trevor Allison <tallison@redhat.com>
---
 tools/perf/tests/shell/attr/test-stat-default    | 7 +++++++
 tools/perf/tests/shell/attr/test-stat-detailed-1 | 7 +++++++
 tools/perf/tests/shell/attr/test-stat-detailed-2 | 7 +++++++
 tools/perf/tests/shell/attr/test-stat-detailed-3 | 7 +++++++
 4 files changed, 28 insertions(+)

diff --git a/tools/perf/tests/shell/attr/test-stat-default b/tools/perf/tests/shell/attr/test-stat-default
index e47fb4944679..8dd27c1fb661 100644
--- a/tools/perf/tests/shell/attr/test-stat-default
+++ b/tools/perf/tests/shell/attr/test-stat-default
@@ -227,3 +227,10 @@ fd=28
 type=4
 config=270
 optional=1
+
+# PERF_TYPE_RAW / INT_MISC.UOP_DROPPING
+[event29:base-stat]
+fd=29
+type=4
+config=4269
+optional=1
\ No newline at end of file
diff --git a/tools/perf/tests/shell/attr/test-stat-detailed-1 b/tools/perf/tests/shell/attr/test-stat-detailed-1
index 3d500d3e0c5c..12a2ebf4e64a 100644
--- a/tools/perf/tests/shell/attr/test-stat-detailed-1
+++ b/tools/perf/tests/shell/attr/test-stat-detailed-1
@@ -269,3 +269,10 @@ fd=32
 type=3
 config=65538
 optional=1
+
+# PERF_TYPE_RAW / INT_MISC.UOP_DROPPING
+[event33:base-stat]
+fd=33
+type=4
+config=4269
+optional=1
\ No newline at end of file
diff --git a/tools/perf/tests/shell/attr/test-stat-detailed-2 b/tools/perf/tests/shell/attr/test-stat-detailed-2
index 01777a63752f..66ea25b7d38f 100644
--- a/tools/perf/tests/shell/attr/test-stat-detailed-2
+++ b/tools/perf/tests/shell/attr/test-stat-detailed-2
@@ -329,3 +329,10 @@ fd=38
 type=3
 config=65540
 optional=1
+
+# PERF_TYPE_RAW / INT_MISC.UOP_DROPPING
+[event39:base-stat]
+fd=39
+type=4
+config=4269
+optional=1
\ No newline at end of file
diff --git a/tools/perf/tests/shell/attr/test-stat-detailed-3 b/tools/perf/tests/shell/attr/test-stat-detailed-3
index 8400abd7e1e4..4a27bbfb9f87 100644
--- a/tools/perf/tests/shell/attr/test-stat-detailed-3
+++ b/tools/perf/tests/shell/attr/test-stat-detailed-3
@@ -349,3 +349,10 @@ fd=40
 type=3
 config=66048
 optional=1
+
+# PERF_TYPE_RAW / INT_MISC.UOP_DROPPING
+[event41:base-stat]
+fd=41
+type=4
+config=4269
+optional=1
\ No newline at end of file
-- 
2.39.5 (Apple Git-154)

Re: [PATCH] perf test attr: Add missing int_mist.uop_dropping event to test-stat files

[Ian Rogers]

On Tue, Sep 16, 2025 at 12:31 PM Trevor Allison <tallison@redhat.com> wrote:
>
> Setup struct perf-event-attr test was failing on EMR cpu because perf stat
> was providing an event that was not included in the test. Type 4 Config 4269
> or 10ad, int_misc.uop_dropping.
>
> Add event type=4 config=4269 to test-stat-default and test-stat-detailed-*
> files with optional=1 so EMR machines can pass test
>
> Signed-off-by: Trevor Allison <tallison@redhat.com>

Thanks! I wonder why this wasn't seen on SapphireRapids.

Reviewed-by: Ian Rogers <irogers@google.com>
Fixes: 50e2eb259650 perf vendor events: Update emeraldrapids events/metrics

Ian

> ---
>  tools/perf/tests/shell/attr/test-stat-default    | 7 +++++++
>  tools/perf/tests/shell/attr/test-stat-detailed-1 | 7 +++++++
>  tools/perf/tests/shell/attr/test-stat-detailed-2 | 7 +++++++
>  tools/perf/tests/shell/attr/test-stat-detailed-3 | 7 +++++++
>  4 files changed, 28 insertions(+)
>
> diff --git a/tools/perf/tests/shell/attr/test-stat-default b/tools/perf/tests/shell/attr/test-stat-default
> index e47fb4944679..8dd27c1fb661 100644
> --- a/tools/perf/tests/shell/attr/test-stat-default
> +++ b/tools/perf/tests/shell/attr/test-stat-default
> @@ -227,3 +227,10 @@ fd=28
>  type=4
>  config=270
>  optional=1
> +
> +# PERF_TYPE_RAW / INT_MISC.UOP_DROPPING
> +[event29:base-stat]
> +fd=29
> +type=4
> +config=4269
> +optional=1
> \ No newline at end of file
> diff --git a/tools/perf/tests/shell/attr/test-stat-detailed-1 b/tools/perf/tests/shell/attr/test-stat-detailed-1
> index 3d500d3e0c5c..12a2ebf4e64a 100644
> --- a/tools/perf/tests/shell/attr/test-stat-detailed-1
> +++ b/tools/perf/tests/shell/attr/test-stat-detailed-1
> @@ -269,3 +269,10 @@ fd=32
>  type=3
>  config=65538
>  optional=1
> +
> +# PERF_TYPE_RAW / INT_MISC.UOP_DROPPING
> +[event33:base-stat]
> +fd=33
> +type=4
> +config=4269
> +optional=1
> \ No newline at end of file
> diff --git a/tools/perf/tests/shell/attr/test-stat-detailed-2 b/tools/perf/tests/shell/attr/test-stat-detailed-2
> index 01777a63752f..66ea25b7d38f 100644
> --- a/tools/perf/tests/shell/attr/test-stat-detailed-2
> +++ b/tools/perf/tests/shell/attr/test-stat-detailed-2
> @@ -329,3 +329,10 @@ fd=38
>  type=3
>  config=65540
>  optional=1
> +
> +# PERF_TYPE_RAW / INT_MISC.UOP_DROPPING
> +[event39:base-stat]
> +fd=39
> +type=4
> +config=4269
> +optional=1
> \ No newline at end of file
> diff --git a/tools/perf/tests/shell/attr/test-stat-detailed-3 b/tools/perf/tests/shell/attr/test-stat-detailed-3
> index 8400abd7e1e4..4a27bbfb9f87 100644
> --- a/tools/perf/tests/shell/attr/test-stat-detailed-3
> +++ b/tools/perf/tests/shell/attr/test-stat-detailed-3
> @@ -349,3 +349,10 @@ fd=40
>  type=3
>  config=66048
>  optional=1
> +
> +# PERF_TYPE_RAW / INT_MISC.UOP_DROPPING
> +[event41:base-stat]
> +fd=41
> +type=4
> +config=4269
> +optional=1
> \ No newline at end of file
> --
> 2.39.5 (Apple Git-154)
>

Re: [PATCH] perf test attr: Add missing int_mist.uop_dropping event to test-stat files

[Arnaldo Carvalho de Melo]

On Tue, Sep 16, 2025 at 01:23:54PM -0700, Ian Rogers wrote:
> On Tue, Sep 16, 2025 at 12:31 PM Trevor Allison <tallison@redhat.com> wrote:
> >
> > Setup struct perf-event-attr test was failing on EMR cpu because perf stat
> > was providing an event that was not included in the test. Type 4 Config 4269
> > or 10ad, int_misc.uop_dropping.
> >
> > Add event type=4 config=4269 to test-stat-default and test-stat-detailed-*
> > files with optional=1 so EMR machines can pass test
> >
> > Signed-off-by: Trevor Allison <tallison@redhat.com>
> 
> Thanks! I wonder why this wasn't seen on SapphireRapids.
> 
> Reviewed-by: Ian Rogers <irogers@google.com>
> Fixes: 50e2eb259650 perf vendor events: Update emeraldrapids events/metrics

You mean:

commit d9a6bb9e359e6f816c746fc8d6aa0999f4594a0c
Author: Ian Rogers <irogers@google.com>
Date:   Mon Aug 18 12:04:02 2025 -0700

    perf vendor events: Update emeraldrapids events/metrics
    
    Update events from v1.14 to v1.16. Update metrics from TMA 5.0 to 5.1.
    
    The event updates come from:
    
    https://github.com/intel/perfmon/commit/9020e49e790349f86141a1f6ef6f009f189a0f48
    https://github.com/intel/perfmon/commit/a0567b56185fea4b968391aae344e9d8ed9782d8

?

As I didn't find 50e2eb259650 in upstream or perf-tools-next.

⬢ [acme@toolbx perf-tools-next]$ git log --oneline tools/perf/pmu-events/arch/x86/emeraldrapids/
d9a6bb9e359e6f81 perf vendor events: Update emeraldrapids events/metrics
31c8714cf5b91da6 perf vendor events: Update EmeraldRapids events
4ecf9eab4a04c75d perf vendor events: Update emeraldrapids events/metrics
5ee60fbf7375abeb perf vendor events: Update EmeraldRapids events/metrics
40ccd6aa3e2e05be perf vendor events: Add/update emeraldrapids events/metrics
36f353a1ebf88280 perf vendor events intel: Update emeraldrapids to 1.06
ea518afc992032f7 perf vendor events intel: Update emeraldrapids events to v1.03
576d7fed09c7edba perf vendor events intel: Update emeraldrapids events to v1.02
8a94d3bfaf45e799 perf vendor events intel: Update emeraldrapids to v1.01
8c994eff8fcfe8ec perf vendor events intel: Add emeraldrapids, update sapphirerapids to v1.16
⬢ [acme@toolbx perf-tools-next]$

- Arnaldo
 
> Ian
> 
> > ---
> >  tools/perf/tests/shell/attr/test-stat-default    | 7 +++++++
> >  tools/perf/tests/shell/attr/test-stat-detailed-1 | 7 +++++++
> >  tools/perf/tests/shell/attr/test-stat-detailed-2 | 7 +++++++
> >  tools/perf/tests/shell/attr/test-stat-detailed-3 | 7 +++++++
> >  4 files changed, 28 insertions(+)
> >
> > diff --git a/tools/perf/tests/shell/attr/test-stat-default b/tools/perf/tests/shell/attr/test-stat-default
> > index e47fb4944679..8dd27c1fb661 100644
> > --- a/tools/perf/tests/shell/attr/test-stat-default
> > +++ b/tools/perf/tests/shell/attr/test-stat-default
> > @@ -227,3 +227,10 @@ fd=28
> >  type=4
> >  config=270
> >  optional=1
> > +
> > +# PERF_TYPE_RAW / INT_MISC.UOP_DROPPING
> > +[event29:base-stat]
> > +fd=29
> > +type=4
> > +config=4269
> > +optional=1
> > \ No newline at end of file
> > diff --git a/tools/perf/tests/shell/attr/test-stat-detailed-1 b/tools/perf/tests/shell/attr/test-stat-detailed-1
> > index 3d500d3e0c5c..12a2ebf4e64a 100644
> > --- a/tools/perf/tests/shell/attr/test-stat-detailed-1
> > +++ b/tools/perf/tests/shell/attr/test-stat-detailed-1
> > @@ -269,3 +269,10 @@ fd=32
> >  type=3
> >  config=65538
> >  optional=1
> > +
> > +# PERF_TYPE_RAW / INT_MISC.UOP_DROPPING
> > +[event33:base-stat]
> > +fd=33
> > +type=4
> > +config=4269
> > +optional=1
> > \ No newline at end of file
> > diff --git a/tools/perf/tests/shell/attr/test-stat-detailed-2 b/tools/perf/tests/shell/attr/test-stat-detailed-2
> > index 01777a63752f..66ea25b7d38f 100644
> > --- a/tools/perf/tests/shell/attr/test-stat-detailed-2
> > +++ b/tools/perf/tests/shell/attr/test-stat-detailed-2
> > @@ -329,3 +329,10 @@ fd=38
> >  type=3
> >  config=65540
> >  optional=1
> > +
> > +# PERF_TYPE_RAW / INT_MISC.UOP_DROPPING
> > +[event39:base-stat]
> > +fd=39
> > +type=4
> > +config=4269
> > +optional=1
> > \ No newline at end of file
> > diff --git a/tools/perf/tests/shell/attr/test-stat-detailed-3 b/tools/perf/tests/shell/attr/test-stat-detailed-3
> > index 8400abd7e1e4..4a27bbfb9f87 100644
> > --- a/tools/perf/tests/shell/attr/test-stat-detailed-3
> > +++ b/tools/perf/tests/shell/attr/test-stat-detailed-3
> > @@ -349,3 +349,10 @@ fd=40
> >  type=3
> >  config=66048
> >  optional=1
> > +
> > +# PERF_TYPE_RAW / INT_MISC.UOP_DROPPING
> > +[event41:base-stat]
> > +fd=41
> > +type=4
> > +config=4269
> > +optional=1
> > \ No newline at end of file
> > --
> > 2.39.5 (Apple Git-154)
> >