Re: [PATCH 02/11] Add Enclustra Mercury+ SA2 module

[Sascha Hauer <s.hauer@pengutronix.de>]

On Wed, Sep 17, 2025 at 05:22:05PM +0200, David Picard wrote:
> Signed-off-by: David Picard <david.picard@clermont.in2p3.fr>
> ---
>  arch/arm/boards/Makefile                      |  1 +
>  arch/arm/boards/enclustra-sa2/Makefile        |  2 ++
>  arch/arm/boards/enclustra-sa2/board.c         | 32 +++++++++++++++++++++++++++
>  arch/arm/boards/enclustra-sa2/lowlevel.c      | 13 +++++++++++
>  arch/arm/configs/socfpga-xload_defconfig      |  1 +
>  arch/arm/configs/socfpga_defconfig            |  3 +--
>  arch/arm/dts/Makefile                         |  1 +
>  arch/arm/dts/socfpga_cyclone5_mercury_sa2.dts | 31 ++++++++++++++++++++++++++
>  arch/arm/mach-socfpga/Kconfig                 |  4 ++++
>  images/Makefile.socfpga                       |  8 +++++++
>  10 files changed, 94 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boards/Makefile b/arch/arm/boards/Makefile
> index ac1fa74d4c03de7a462746cb93a061017cd2b64d..3c3801aaae8425689f2f070321d4ec2fd38ad90a 100644
> --- a/arch/arm/boards/Makefile
> +++ b/arch/arm/boards/Makefile
> @@ -118,6 +118,7 @@ obj-$(CONFIG_MACH_SEEED_ODYSSEY)		+= seeed-odyssey/
>  obj-$(CONFIG_MACH_SOCFPGA_ALTERA_SOCDK)		+= altera-socdk/
>  obj-$(CONFIG_MACH_SOCFPGA_EBV_SOCRATES)		+= ebv-socrates/
>  obj-$(CONFIG_MACH_SOCFPGA_ENCLUSTRA_AA1)	+= enclustra-aa1/
> +obj-$(CONFIG_MACH_SOCFPGA_ENCLUSTRA_SA2)	+= enclustra-sa2/
>  obj-$(CONFIG_MACH_SOCFPGA_REFLEX_ACHILLES)	+= reflex-achilles/
>  obj-$(CONFIG_MACH_SOCFPGA_TERASIC_DE0_NANO_SOC)	+= terasic-de0-nano-soc/
>  obj-$(CONFIG_MACH_SOCFPGA_TERASIC_DE10_NANO)	+= terasic-de10-nano/
> diff --git a/arch/arm/boards/enclustra-sa2/Makefile b/arch/arm/boards/enclustra-sa2/Makefile
> new file mode 100644
> index 0000000000000000000000000000000000000000..8c927fe291a6b3eb20a32a2db96c73f231ab4697
> --- /dev/null
> +++ b/arch/arm/boards/enclustra-sa2/Makefile
> @@ -0,0 +1,2 @@
> +obj-y += lowlevel.o board.o
> +pbl-y += lowlevel.o
> diff --git a/arch/arm/boards/enclustra-sa2/board.c b/arch/arm/boards/enclustra-sa2/board.c
> new file mode 100644
> index 0000000000000000000000000000000000000000..834d0ab91871d0329af20f89a13af65e194b21c3
> --- /dev/null
> +++ b/arch/arm/boards/enclustra-sa2/board.c
> @@ -0,0 +1,32 @@
> +#include <common.h>
> +#include <types.h>
> +#include <driver.h>
> +#include <init.h>
> +#include <asm/armlinux.h>
> +#include <linux/mdio.h>
> +#include <linux/micrel_phy.h>
> +#include <linux/phy.h>
> +#include <linux/sizes.h>
> +#include <fcntl.h>
> +#include <fs.h>
> +#include <mach/socfpga/cyclone5-regs.h>
> +
> +/*
> + * Ethernet PHY: Microchip/Micrel KSZ9031RNX
> + */
> +static int phy_fixup(struct phy_device *dev)
> +{
> +	return 0;
> +}
> +
> +static int socfpga_init(void)
> +{
> +	if (!of_machine_is_compatible("altr,socfpga-cyclone5"))
> +		return 0;

This is too broad and fixed later in this series. Please start with the
correct compatible here instead of fixing it later.

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |