From: Sascha Hauer <s.hauer@pengutronix.de>
To: David Picard <david.picard@clermont.in2p3.fr>
Cc: BAREBOX <barebox@lists.infradead.org>
Subject: Re: [PATCH 06/11] boards: enclustra-sa2: read MAC address from EEPROM
Date: Thu, 18 Sep 2025 08:18:41 +0200 [thread overview]
Message-ID: <aMukQcvHZOMExEzw@pengutronix.de> (raw)
In-Reply-To: <20250917-boards-enclustra-sa2-add-support-v1-6-2de8f69107a1@clermont.in2p3.fr>
Hi David,
On Wed, Sep 17, 2025 at 05:22:09PM +0200, David Picard wrote:
> Signed-off-by: David Picard <david.picard@clermont.in2p3.fr>
> ---
> arch/arm/boards/enclustra-sa2/Makefile | 2 +-
> arch/arm/boards/enclustra-sa2/atsha204a.c | 436 ++++++++++++++++++++++++++++++
> arch/arm/boards/enclustra-sa2/atsha204a.h | 19 ++
> arch/arm/boards/enclustra-sa2/board.c | 51 +++-
> arch/arm/boards/enclustra-sa2/crc16.c | 65 +++++
> arch/arm/boards/enclustra-sa2/crc16.h | 28 ++
> arch/arm/mach-socfpga/Kconfig | 1 +
> 7 files changed, 598 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boards/enclustra-sa2/Makefile b/arch/arm/boards/enclustra-sa2/Makefile
> index 8c927fe291a6b3eb20a32a2db96c73f231ab4697..1448ea1266aa24a5b0404cb6379f8c2d76573079 100644
> --- a/arch/arm/boards/enclustra-sa2/Makefile
> +++ b/arch/arm/boards/enclustra-sa2/Makefile
> @@ -1,2 +1,2 @@
> -obj-y += lowlevel.o board.o
> +obj-y += lowlevel.o board.o atsha204a.o crc16.o
> pbl-y += lowlevel.o
> diff --git a/arch/arm/boards/enclustra-sa2/atsha204a.c b/arch/arm/boards/enclustra-sa2/atsha204a.c
> new file mode 100644
> index 0000000000000000000000000000000000000000..3f445de06e73c5bdf27d2d0fc81dc6d939d5cd17
> --- /dev/null
> +++ b/arch/arm/boards/enclustra-sa2/atsha204a.c
This looks like you should rather adopt the Linux driver from
drivers/crypto/atmel-sha204a.c.
Maybe you can even create a NVMEM cell for the MAC address and then no
board specific code would be needed for retrieving the MAC.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2025-09-18 6:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 15:22 [PATCH 00/11] ARM: boards: add support for Enclustra Mercury SA2 David Picard
2025-09-17 15:22 ` [PATCH 01/11] Add handoff files David Picard
2025-09-17 15:22 ` [PATCH 02/11] Add Enclustra Mercury+ SA2 module David Picard
2025-09-18 6:21 ` Sascha Hauer
2025-09-17 15:22 ` [PATCH 03/11] Add Enclustra devicetree files David Picard
2025-09-17 15:22 ` [PATCH 04/11] ARM: dts: socfpga: use upstream SA2 device tree David Picard
2025-09-18 6:32 ` Sascha Hauer
2025-09-18 10:09 ` David Picard
2025-09-18 10:20 ` Ahmad Fatoum
2025-09-17 15:22 ` [PATCH 05/11] ARM: dts: socfpga: adapt " David Picard
2025-09-17 15:22 ` [PATCH 06/11] boards: enclustra-sa2: read MAC address from EEPROM David Picard
2025-09-17 17:06 ` Alexander Shiyan
2025-09-18 6:18 ` Sascha Hauer [this message]
2025-09-18 14:01 ` David Picard
2025-09-18 14:12 ` Sascha Hauer
2025-09-18 15:07 ` David Picard
2025-09-22 13:15 ` Sascha Hauer
2025-09-23 9:07 ` David Picard
2025-09-23 9:40 ` Sascha Hauer
2025-09-23 11:50 ` David Picard
2025-09-23 15:31 ` David Picard
2025-09-17 15:22 ` [PATCH 07/11] gpio: dw: support numbering via aliases David Picard
2025-09-18 6:35 ` Sascha Hauer
2025-09-17 15:22 ` [PATCH 08/11] gpio: dw: make deep probe compatible David Picard
2025-09-17 15:22 ` [PATCH 09/11] boards: enclustra-sa2: enable bridges David Picard
2025-09-18 6:37 ` Sascha Hauer
2025-09-17 15:22 ` [PATCH 10/11] boards: enclustra-sa2: configure SI5338 David Picard
2025-09-18 7:09 ` Sascha Hauer
2025-09-18 13:23 ` David Picard
2025-09-17 15:22 ` [PATCH 11/11] boards: enclustra-sa2: enable SI5338 David Picard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMukQcvHZOMExEzw@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=david.picard@clermont.in2p3.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.