* [PATCH next] EDAC/versalnet: Fix error code in probe()
@ 2025-09-18 6:57 Dan Carpenter
2025-09-18 12:40 ` Borislav Petkov
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2025-09-18 6:57 UTC (permalink / raw)
To: Shubhrajyoti Datta
Cc: Borislav Petkov, Tony Luck, linux-edac, linux-kernel,
kernel-janitors
This code returns success if devm_kzalloc() fails. Return -ENOMEM
instead.
Fixes: d5fe2fec6c40 ("EDAC: Add a driver for the AMD Versal NET DDR controller")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/edac/versalnet_edac.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/edac/versalnet_edac.c b/drivers/edac/versalnet_edac.c
index 66714fffa591..7c5db8bf0595 100644
--- a/drivers/edac/versalnet_edac.c
+++ b/drivers/edac/versalnet_edac.c
@@ -888,8 +888,10 @@ static int mc_probe(struct platform_device *pdev)
}
priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
- if (!priv)
+ if (!priv) {
+ rc = -ENOMEM;
goto err_alloc;
+ }
amd_rpmsg_id_table[0].driver_data = (kernel_ulong_t)priv;
--
2.51.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH next] EDAC/versalnet: Fix error code in probe()
2025-09-18 6:57 [PATCH next] EDAC/versalnet: Fix error code in probe() Dan Carpenter
@ 2025-09-18 12:40 ` Borislav Petkov
0 siblings, 0 replies; 2+ messages in thread
From: Borislav Petkov @ 2025-09-18 12:40 UTC (permalink / raw)
To: Dan Carpenter
Cc: Shubhrajyoti Datta, Tony Luck, linux-edac, linux-kernel,
kernel-janitors
On Thu, Sep 18, 2025 at 09:57:47AM +0300, Dan Carpenter wrote:
> This code returns success if devm_kzalloc() fails. Return -ENOMEM
> instead.
>
> Fixes: d5fe2fec6c40 ("EDAC: Add a driver for the AMD Versal NET DDR controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/edac/versalnet_edac.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/edac/versalnet_edac.c b/drivers/edac/versalnet_edac.c
> index 66714fffa591..7c5db8bf0595 100644
> --- a/drivers/edac/versalnet_edac.c
> +++ b/drivers/edac/versalnet_edac.c
> @@ -888,8 +888,10 @@ static int mc_probe(struct platform_device *pdev)
> }
>
> priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
> - if (!priv)
> + if (!priv) {
> + rc = -ENOMEM;
> goto err_alloc;
> + }
>
> amd_rpmsg_id_table[0].driver_data = (kernel_ulong_t)priv;
>
> --
Applied, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-18 12:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-18 6:57 [PATCH next] EDAC/versalnet: Fix error code in probe() Dan Carpenter
2025-09-18 12:40 ` Borislav Petkov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.