All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Cc: Andi Shyti <andi.shyti@kernel.org>, Yixun Lan <dlan@gentoo.org>,
	Alex Elder <elder@riscstar.com>,
	Troy Mitchell <troymitchell988@gmail.com>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev
Subject: Re: [PATCH v2 5/6] i2c: spacemit: ensure SDA is released after bus reset
Date: Thu, 25 Sep 2025 22:43:45 +0200	[thread overview]
Message-ID: <aNWpgYjiMtZJrBOm@aurel32.net> (raw)
In-Reply-To: <20250925-k1-i2c-atomic-v2-5-46dc13311cda@linux.spacemit.com>

On 2025-09-25 10:02, Troy Mitchell wrote:
> After performing a conditional bus reset, the controller must ensure
> that the SDA line is actually released.
> 
> Previously, the reset routine only performed a single check,
> which could leave the bus in a locked state in some situations.
> 
> This patch introduces a loop that toggles the reset cycle and issues
> a reset request up to SPACEMIT_BUS_RESET_CLK_CNT_MAX times, checking
> SDA after each attempt. If SDA is released before the maximum count,
> the function returns early. Otherwise, a warning is emitted.
> 
> This change improves bus recovery reliability.
> 
> Fixes: 5ea558473fa31 ("i2c: spacemit: add support for SpacemiT K1 SoC")
> Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
> ---
>  drivers/i2c/busses/i2c-k1.c | 21 ++++++++++++++++++++-
>  1 file changed, 20 insertions(+), 1 deletion(-)

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                     http://aurel32.net

WARNING: multiple messages have this Message-ID (diff)
From: Aurelien Jarno <aurelien@aurel32.net>
To: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Cc: Andi Shyti <andi.shyti@kernel.org>, Yixun Lan <dlan@gentoo.org>,
	Alex Elder <elder@riscstar.com>,
	Troy Mitchell <troymitchell988@gmail.com>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev
Subject: Re: [PATCH v2 5/6] i2c: spacemit: ensure SDA is released after bus reset
Date: Thu, 25 Sep 2025 22:43:45 +0200	[thread overview]
Message-ID: <aNWpgYjiMtZJrBOm@aurel32.net> (raw)
In-Reply-To: <20250925-k1-i2c-atomic-v2-5-46dc13311cda@linux.spacemit.com>

On 2025-09-25 10:02, Troy Mitchell wrote:
> After performing a conditional bus reset, the controller must ensure
> that the SDA line is actually released.
> 
> Previously, the reset routine only performed a single check,
> which could leave the bus in a locked state in some situations.
> 
> This patch introduces a loop that toggles the reset cycle and issues
> a reset request up to SPACEMIT_BUS_RESET_CLK_CNT_MAX times, checking
> SDA after each attempt. If SDA is released before the maximum count,
> the function returns early. Otherwise, a warning is emitted.
> 
> This change improves bus recovery reliability.
> 
> Fixes: 5ea558473fa31 ("i2c: spacemit: add support for SpacemiT K1 SoC")
> Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
> ---
>  drivers/i2c/busses/i2c-k1.c | 21 ++++++++++++++++++++-
>  1 file changed, 20 insertions(+), 1 deletion(-)

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                     http://aurel32.net

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2025-09-25 20:43 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-25  2:02 [PATCH v2 0/6] i2c: spacemit: fix and introduce pio Troy Mitchell
2025-09-25  2:02 ` Troy Mitchell
2025-09-25  2:02 ` [PATCH v2 1/6] i2c: spacemit: ensure bus release check runs when wait_bus_idle() fails Troy Mitchell
2025-09-25  2:02   ` Troy Mitchell
2025-09-25  2:02 ` [PATCH v2 2/6] i2c: spacemit: remove stop function to avoid bus error Troy Mitchell
2025-09-25  2:02   ` Troy Mitchell
2025-09-25 20:11   ` Aurelien Jarno
2025-09-25 20:11     ` Aurelien Jarno
2025-09-25  2:02 ` [PATCH v2 3/6] i2c: spacemit: disable SDA glitch fix to avoid restart delay Troy Mitchell
2025-09-25  2:02   ` Troy Mitchell
2025-09-25  2:02 ` [PATCH v2 4/6] i2c: spacemit: check SDA instead of SCL after bus reset Troy Mitchell
2025-09-25  2:02   ` Troy Mitchell
2025-09-25  2:02 ` [PATCH v2 5/6] i2c: spacemit: ensure SDA is released " Troy Mitchell
2025-09-25  2:02   ` Troy Mitchell
2025-09-25 20:43   ` Aurelien Jarno [this message]
2025-09-25 20:43     ` Aurelien Jarno
2025-09-25  2:02 ` [PATCH v2 6/6] i2c: spacemit: introduce pio for k1 Troy Mitchell
2025-09-25  2:02   ` Troy Mitchell
2025-09-26 11:10   ` Yixun Lan
2025-09-26 11:10     ` Yixun Lan
2025-09-26 13:13     ` Troy Mitchell
2025-09-26 13:13       ` Troy Mitchell
2025-09-26 14:28       ` Wolfram Sang
2025-09-26 14:28         ` Wolfram Sang
2025-09-27  1:24         ` Yixun Lan
2025-09-27  1:24           ` Yixun Lan
2025-09-27  3:57           ` Troy Mitchell
2025-09-27  3:57             ` Troy Mitchell
2025-09-28  6:06     ` Troy Mitchell
2025-09-28  6:06       ` Troy Mitchell
2025-09-26 16:47   ` Aurelien Jarno
2025-09-26 16:47     ` Aurelien Jarno
2025-09-27  4:05     ` Troy Mitchell
2025-09-27  4:05       ` Troy Mitchell
2025-09-27  1:45   ` Yixun Lan
2025-09-27  1:45     ` Yixun Lan
2025-09-27  4:04     ` Troy Mitchell
2025-09-27  4:04       ` Troy Mitchell
2025-09-27 10:16       ` Yixun Lan
2025-09-27 10:16         ` Yixun Lan
2025-09-27 10:24         ` Troy Mitchell
2025-09-27 10:24           ` Troy Mitchell
2025-09-27 10:56   ` Yixun Lan
2025-09-27 10:56     ` Yixun Lan
2025-09-28  1:17     ` Troy Mitchell
2025-09-28  1:17       ` Troy Mitchell
2025-09-28  2:54       ` Yixun Lan
2025-09-28  2:54         ` Yixun Lan
2025-09-28  8:09         ` Troy Mitchell
2025-09-28  8:09           ` Troy Mitchell
2025-09-28 11:22           ` Yixun Lan
2025-09-28 11:22             ` Yixun Lan
2025-09-25 21:50 ` [PATCH v2 0/6] i2c: spacemit: fix and introduce pio Wolfram Sang
2025-09-25 21:50   ` Wolfram Sang
2025-09-26  1:47   ` Troy Mitchell
2025-09-26  1:47     ` Troy Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aNWpgYjiMtZJrBOm@aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=andi.shyti@kernel.org \
    --cc=dlan@gentoo.org \
    --cc=elder@riscstar.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=spacemit@lists.linux.dev \
    --cc=troy.mitchell@linux.spacemit.com \
    --cc=troymitchell988@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.