All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Shivank Garg <shivankg@amd.com>
Cc: willy@infradead.org, akpm@linux-foundation.org, david@redhat.com,
	 pbonzini@redhat.com, shuah@kernel.org, vbabka@suse.cz,
	brauner@kernel.org,  viro@zeniv.linux.org.uk, dsterba@suse.com,
	xiang@kernel.org, chao@kernel.org,  jaegeuk@kernel.org,
	clm@fb.com, josef@toxicpanda.com,  kent.overstreet@linux.dev,
	zbestahu@gmail.com, jefflexu@linux.alibaba.com,
	 dhavale@google.com, lihongbo22@huawei.com,
	lorenzo.stoakes@oracle.com,  Liam.Howlett@oracle.com,
	rppt@kernel.org, surenb@google.com, mhocko@suse.com,
	 ziy@nvidia.com, matthew.brost@intel.com,
	joshua.hahnjy@gmail.com,  rakie.kim@sk.com, byungchul@sk.com,
	gourry@gourry.net,  ying.huang@linux.alibaba.com,
	apopple@nvidia.com, tabba@google.com,  ackerleytng@google.com,
	paul@paul-moore.com, jmorris@namei.org,  serge@hallyn.com,
	pvorel@suse.cz, bfoster@redhat.com, vannapurve@google.com,
	 chao.gao@intel.com, bharata@amd.com, nikunj@amd.com,
	michael.day@amd.com,  shdhiman@amd.com, yan.y.zhao@intel.com,
	Neeraj.Upadhyay@amd.com,  thomas.lendacky@amd.com,
	michael.roth@amd.com, aik@amd.com, jgg@nvidia.com,
	 kalyazin@amazon.com, peterx@redhat.com, jack@suse.cz,
	hch@infradead.org,  cgzones@googlemail.com, ira.weiny@intel.com,
	rientjes@google.com,  roypat@amazon.co.uk, chao.p.peng@intel.com,
	amit@infradead.org,  ddutile@redhat.com,
	dan.j.williams@intel.com, ashish.kalra@amd.com,
	 gshan@redhat.com, jgowans@amazon.com, pankaj.gupta@amd.com,
	papaluri@amd.com,  yuzhao@google.com, suzuki.poulose@arm.com,
	quic_eberman@quicinc.com,  linux-bcachefs@vger.kernel.org,
	linux-btrfs@vger.kernel.org,  linux-erofs@lists.ozlabs.org,
	linux-f2fs-devel@lists.sourceforge.net,
	 linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
	 linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org,  kvm@vger.kernel.org,
	linux-kselftest@vger.kernel.org,  linux-coco@lists.linux.dev
Subject: Re: [PATCH kvm-next V11 7/7] KVM: guest_memfd: selftests: Add tests for mmap and NUMA policy support
Date: Thu, 25 Sep 2025 16:03:41 -0700	[thread overview]
Message-ID: <aNXKTUnxHQyds4sh@google.com> (raw)
In-Reply-To: <aNW1l-Wdk6wrigM8@google.com>

On Thu, Sep 25, 2025, Sean Christopherson wrote:
> On Wed, Aug 27, 2025, Shivank Garg wrote:
> > Add tests for NUMA memory policy binding and NUMA aware allocation in
> > guest_memfd. This extends the existing selftests by adding proper
> > validation for:
> > - KVM GMEM set_policy and get_policy() vm_ops functionality using
> >   mbind() and get_mempolicy()
> > - NUMA policy application before and after memory allocation
> > 
> > These tests help ensure NUMA support for guest_memfd works correctly.
> > 
> > Signed-off-by: Shivank Garg <shivankg@amd.com>
> > ---
> >  tools/testing/selftests/kvm/Makefile.kvm      |   1 +
> >  .../testing/selftests/kvm/guest_memfd_test.c  | 121 ++++++++++++++++++
> >  2 files changed, 122 insertions(+)
> > 
> > diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm
> > index 90f03f00cb04..c46cef2a7cd7 100644
> > --- a/tools/testing/selftests/kvm/Makefile.kvm
> > +++ b/tools/testing/selftests/kvm/Makefile.kvm
> > @@ -275,6 +275,7 @@ pgste-option = $(call try-run, echo 'int main(void) { return 0; }' | \
> >  	$(CC) -Werror -Wl$(comma)--s390-pgste -x c - -o "$$TMP",-Wl$(comma)--s390-pgste)
> >  
> >  LDLIBS += -ldl
> > +LDLIBS += -lnuma
> 
> Hrm, this is going to be very annoying.  I don't have libnuma-dev installed on
> any of my <too many> systems, and I doubt I'm alone.  Installing the package is
> trivial, but I'm a little wary of foisting that requirement on all KVM developers
> and build bots.
> 
> I'd be especially curious what ARM and RISC-V think, as NUMA is likely a bit less
> prevelant there.

Ugh, and it doesn't play nice with static linking.  I haven't tried running on a
NUMA system yet, so maybe it's benign?

/usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/14/../../../x86_64-linux-gnu/libnuma.a(affinity.o): in function `affinity_ip':
(.text+0x629): warning: Using 'getaddrinfo' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking

WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Shivank Garg <shivankg@amd.com>
Cc: jgowans@amazon.com, mhocko@suse.com, jack@suse.cz,
	kvm@vger.kernel.org, david@redhat.com,
	linux-btrfs@vger.kernel.org, aik@amd.com, papaluri@amd.com,
	kalyazin@amazon.com, peterx@redhat.com, linux-mm@kvack.org,
	clm@fb.com, ddutile@redhat.com, linux-kselftest@vger.kernel.org,
	shdhiman@amd.com, gshan@redhat.com, ying.huang@linux.alibaba.com,
	shuah@kernel.org, roypat@amazon.co.uk, matthew.brost@intel.com,
	linux-coco@lists.linux.dev, zbestahu@gmail.com,
	lorenzo.stoakes@oracle.com, linux-bcachefs@vger.kernel.org,
	ira.weiny@intel.com, dhavale@google.com, jmorris@namei.org,
	willy@infradead.org, hch@infradead.org, chao.gao@intel.com,
	tabba@google.com, ziy@nvidia.com, rientjes@google.com,
	yuzhao@google.com, xiang@kernel.org, nikunj@amd.com,
	gourry@gourry.net, serge@hallyn.com, amit@infradead.org,
	thomas.lendacky@amd.com, ashish.kalra@amd.com,
	chao.p.peng@intel.com, yan.y.zhao@intel.com, byungchul@sk.com,
	michael.day@amd.com, Neeraj.Upadhyay@amd.com,
	michael.roth@amd.com, bfoster@redhat.com, bharata@amd.com,
	josef@toxicpanda.com, Liam.Howlett@oracle.com,
	ackerleytng@google.com, dsterba@suse.com,
	viro@zeniv.linux.org.uk, jefflexu@linux.alibaba.com,
	jaegeuk@kernel.org, dan.j.williams@intel.com, surenb@google.com,
	vbabka@suse.cz, paul@paul-moore.com, joshua.hahnjy@gmail.com,
	apopple@nvidia.com, brauner@kernel.org, quic_eberman@quicinc.com,
	rakie.kim@sk.com, cgzones@googlemail.com, pvorel@suse.cz,
	linux-erofs@lists.ozlabs.org, kent.overstreet@linux.dev,
	linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net, pankaj.gupta@amd.com,
	linux-security-module@vger.kernel.org, lihongbo22@huawei.com,
	linux-fsdevel@vger.kernel.org, pbonzini@redhat.com,
	akpm@linux-foundation.org, vannapurve@google.com,
	suzuki.poulose@arm.com, rppt@kernel.org, jgg@nvidia.com
Subject: Re: [f2fs-dev] [PATCH kvm-next V11 7/7] KVM: guest_memfd: selftests: Add tests for mmap and NUMA policy support
Date: Thu, 25 Sep 2025 16:03:41 -0700	[thread overview]
Message-ID: <aNXKTUnxHQyds4sh@google.com> (raw)
In-Reply-To: <aNW1l-Wdk6wrigM8@google.com>

On Thu, Sep 25, 2025, Sean Christopherson wrote:
> On Wed, Aug 27, 2025, Shivank Garg wrote:
> > Add tests for NUMA memory policy binding and NUMA aware allocation in
> > guest_memfd. This extends the existing selftests by adding proper
> > validation for:
> > - KVM GMEM set_policy and get_policy() vm_ops functionality using
> >   mbind() and get_mempolicy()
> > - NUMA policy application before and after memory allocation
> > 
> > These tests help ensure NUMA support for guest_memfd works correctly.
> > 
> > Signed-off-by: Shivank Garg <shivankg@amd.com>
> > ---
> >  tools/testing/selftests/kvm/Makefile.kvm      |   1 +
> >  .../testing/selftests/kvm/guest_memfd_test.c  | 121 ++++++++++++++++++
> >  2 files changed, 122 insertions(+)
> > 
> > diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm
> > index 90f03f00cb04..c46cef2a7cd7 100644
> > --- a/tools/testing/selftests/kvm/Makefile.kvm
> > +++ b/tools/testing/selftests/kvm/Makefile.kvm
> > @@ -275,6 +275,7 @@ pgste-option = $(call try-run, echo 'int main(void) { return 0; }' | \
> >  	$(CC) -Werror -Wl$(comma)--s390-pgste -x c - -o "$$TMP",-Wl$(comma)--s390-pgste)
> >  
> >  LDLIBS += -ldl
> > +LDLIBS += -lnuma
> 
> Hrm, this is going to be very annoying.  I don't have libnuma-dev installed on
> any of my <too many> systems, and I doubt I'm alone.  Installing the package is
> trivial, but I'm a little wary of foisting that requirement on all KVM developers
> and build bots.
> 
> I'd be especially curious what ARM and RISC-V think, as NUMA is likely a bit less
> prevelant there.

Ugh, and it doesn't play nice with static linking.  I haven't tried running on a
NUMA system yet, so maybe it's benign?

/usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/14/../../../x86_64-linux-gnu/libnuma.a(affinity.o): in function `affinity_ip':
(.text+0x629): warning: Using 'getaddrinfo' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2025-09-25 23:03 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-27 17:52 [PATCH kvm-next V11 0/7] Add NUMA mempolicy support for KVM guest-memfd Shivank Garg
2025-08-27 17:52 ` [f2fs-dev] " Shivank Garg via Linux-f2fs-devel
2025-08-27 17:52 ` [PATCH kvm-next V11 1/7] mm/filemap: Add NUMA mempolicy support to filemap_alloc_folio() Shivank Garg
2025-08-27 17:52   ` [f2fs-dev] " Shivank Garg via Linux-f2fs-devel
2025-08-27 17:52 ` [PATCH kvm-next V11 2/7] mm/filemap: Extend __filemap_get_folio() to support NUMA memory policies Shivank Garg
2025-08-27 17:52   ` [f2fs-dev] " Shivank Garg via Linux-f2fs-devel
2025-08-27 17:52 ` [PATCH kvm-next V11 3/7] mm/mempolicy: Export memory policy symbols Shivank Garg
2025-08-27 17:52   ` [f2fs-dev] " Shivank Garg via Linux-f2fs-devel
2025-08-27 17:52 ` [PATCH kvm-next V11 4/7] KVM: guest_memfd: Use guest mem inodes instead of anonymous inodes Shivank Garg
2025-08-27 17:52   ` [f2fs-dev] " Shivank Garg via Linux-f2fs-devel
2025-08-27 22:43   ` Ackerley Tng
2025-08-27 22:43     ` [f2fs-dev] " Ackerley Tng via Linux-f2fs-devel
2025-08-28  5:49     ` Garg, Shivank
2025-08-28  5:49       ` [f2fs-dev] " Garg, Shivank via Linux-f2fs-devel
2025-08-28 10:06     ` David Hildenbrand
2025-08-28 10:06       ` [f2fs-dev] " David Hildenbrand via Linux-f2fs-devel
2025-09-25  2:50     ` Sean Christopherson
2025-09-25  2:50       ` [f2fs-dev] " Sean Christopherson via Linux-f2fs-devel
2025-09-25 11:44       ` Garg, Shivank
2025-09-25 11:44         ` [f2fs-dev] " Garg, Shivank via Linux-f2fs-devel
2025-09-25 11:55         ` David Hildenbrand
2025-09-25 11:55           ` [f2fs-dev] " David Hildenbrand via Linux-f2fs-devel
2025-09-25 13:41           ` Sean Christopherson
2025-09-25 13:41             ` [f2fs-dev] " Sean Christopherson via Linux-f2fs-devel
2025-09-25 13:44             ` Fuad Tabba
2025-09-25 13:44               ` [f2fs-dev] " Fuad Tabba via Linux-f2fs-devel
2025-09-25 14:26             ` David Hildenbrand
2025-09-25 14:26               ` [f2fs-dev] " David Hildenbrand via Linux-f2fs-devel
2025-09-25 15:06               ` Sean Christopherson
2025-09-25 15:06                 ` [f2fs-dev] " Sean Christopherson via Linux-f2fs-devel
2025-09-25 23:11                 ` Sean Christopherson
2025-09-26  6:20                   ` Garg, Shivank
2025-08-27 17:52 ` [PATCH kvm-next V11 5/7] KVM: guest_memfd: Add slab-allocated inode cache Shivank Garg
2025-08-27 17:52   ` [f2fs-dev] " Shivank Garg via Linux-f2fs-devel
2025-09-25 14:05   ` Sean Christopherson
2025-09-25 14:05     ` [f2fs-dev] " Sean Christopherson via Linux-f2fs-devel
2025-09-25 14:17     ` Sean Christopherson
2025-09-25 14:17       ` [f2fs-dev] " Sean Christopherson via Linux-f2fs-devel
2025-08-27 17:52 ` [PATCH kvm-next V11 6/7] KVM: guest_memfd: Enforce NUMA mempolicy using shared policy Shivank Garg
2025-08-27 17:52   ` [f2fs-dev] " Shivank Garg via Linux-f2fs-devel
2025-09-25 14:22   ` Sean Christopherson
2025-09-25 14:22     ` [f2fs-dev] " Sean Christopherson via Linux-f2fs-devel
2025-09-26 19:36     ` Sean Christopherson
2025-09-26 19:36       ` [f2fs-dev] " Sean Christopherson via Linux-f2fs-devel
2025-10-15 21:45       ` Gregory Price
2025-10-15 21:45         ` Gregory Price
2025-10-15 22:48         ` Sean Christopherson
2025-10-15 22:48           ` Sean Christopherson via Linux-f2fs-devel
2025-10-16 12:58           ` Garg, Shivank
2025-10-16 12:58             ` Garg, Shivank via Linux-f2fs-devel
2025-10-16 14:17           ` Gregory Price
2025-10-16 14:17             ` Gregory Price
2025-08-27 17:52 ` [PATCH kvm-next V11 7/7] KVM: guest_memfd: selftests: Add tests for mmap and NUMA policy support Shivank Garg
2025-08-27 17:52   ` [f2fs-dev] " Shivank Garg via Linux-f2fs-devel
2025-09-25 21:35   ` Sean Christopherson
2025-09-25 21:35     ` [f2fs-dev] " Sean Christopherson via Linux-f2fs-devel
2025-09-25 23:03     ` Sean Christopherson [this message]
2025-09-25 23:03       ` Sean Christopherson via Linux-f2fs-devel
2025-09-25 23:04     ` Jason Gunthorpe
2025-09-25 23:04       ` [f2fs-dev] " Jason Gunthorpe via Linux-f2fs-devel
2025-09-25 23:12       ` Sean Christopherson
2025-09-25 23:12         ` [f2fs-dev] " Sean Christopherson via Linux-f2fs-devel
2025-09-26  7:32       ` David Hildenbrand
2025-09-26  7:32         ` [f2fs-dev] " David Hildenbrand via Linux-f2fs-devel
2025-09-26  7:31     ` David Hildenbrand
2025-09-26  7:31       ` [f2fs-dev] " David Hildenbrand via Linux-f2fs-devel
2025-09-26  7:37       ` Garg, Shivank
2025-09-26  7:37         ` [f2fs-dev] " Garg, Shivank via Linux-f2fs-devel
2025-08-28 12:44 ` [PATCH kvm-next V11 0/7] Add NUMA mempolicy support for KVM guest-memfd David Hildenbrand
2025-08-28 12:44   ` [f2fs-dev] " David Hildenbrand via Linux-f2fs-devel
2025-09-24 18:19 ` David Hildenbrand
2025-09-24 18:19   ` [f2fs-dev] " David Hildenbrand via Linux-f2fs-devel
2025-09-24 20:35   ` Kalra, Ashish
2025-09-24 20:35     ` [f2fs-dev] " Kalra, Ashish via Linux-f2fs-devel
2025-10-15 18:02 ` Sean Christopherson
2025-10-15 18:02   ` [f2fs-dev] " Sean Christopherson via Linux-f2fs-devel
2025-10-20 15:52   ` Sean Christopherson
2025-10-20 15:52     ` [f2fs-dev] " Sean Christopherson via Linux-f2fs-devel
2025-12-09 17:18 ` patchwork-bot+f2fs
2025-12-09 17:18   ` patchwork-bot+f2fs--- via Linux-f2fs-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aNXKTUnxHQyds4sh@google.com \
    --to=seanjc@google.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=Neeraj.Upadhyay@amd.com \
    --cc=ackerleytng@google.com \
    --cc=aik@amd.com \
    --cc=akpm@linux-foundation.org \
    --cc=amit@infradead.org \
    --cc=apopple@nvidia.com \
    --cc=ashish.kalra@amd.com \
    --cc=bfoster@redhat.com \
    --cc=bharata@amd.com \
    --cc=brauner@kernel.org \
    --cc=byungchul@sk.com \
    --cc=cgzones@googlemail.com \
    --cc=chao.gao@intel.com \
    --cc=chao.p.peng@intel.com \
    --cc=chao@kernel.org \
    --cc=clm@fb.com \
    --cc=dan.j.williams@intel.com \
    --cc=david@redhat.com \
    --cc=ddutile@redhat.com \
    --cc=dhavale@google.com \
    --cc=dsterba@suse.com \
    --cc=gourry@gourry.net \
    --cc=gshan@redhat.com \
    --cc=hch@infradead.org \
    --cc=ira.weiny@intel.com \
    --cc=jack@suse.cz \
    --cc=jaegeuk@kernel.org \
    --cc=jefflexu@linux.alibaba.com \
    --cc=jgg@nvidia.com \
    --cc=jgowans@amazon.com \
    --cc=jmorris@namei.org \
    --cc=josef@toxicpanda.com \
    --cc=joshua.hahnjy@gmail.com \
    --cc=kalyazin@amazon.com \
    --cc=kent.overstreet@linux.dev \
    --cc=kvm@vger.kernel.org \
    --cc=lihongbo22@huawei.com \
    --cc=linux-bcachefs@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-coco@lists.linux.dev \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=matthew.brost@intel.com \
    --cc=mhocko@suse.com \
    --cc=michael.day@amd.com \
    --cc=michael.roth@amd.com \
    --cc=nikunj@amd.com \
    --cc=pankaj.gupta@amd.com \
    --cc=papaluri@amd.com \
    --cc=paul@paul-moore.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=pvorel@suse.cz \
    --cc=quic_eberman@quicinc.com \
    --cc=rakie.kim@sk.com \
    --cc=rientjes@google.com \
    --cc=roypat@amazon.co.uk \
    --cc=rppt@kernel.org \
    --cc=serge@hallyn.com \
    --cc=shdhiman@amd.com \
    --cc=shivankg@amd.com \
    --cc=shuah@kernel.org \
    --cc=surenb@google.com \
    --cc=suzuki.poulose@arm.com \
    --cc=tabba@google.com \
    --cc=thomas.lendacky@amd.com \
    --cc=vannapurve@google.com \
    --cc=vbabka@suse.cz \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    --cc=xiang@kernel.org \
    --cc=yan.y.zhao@intel.com \
    --cc=ying.huang@linux.alibaba.com \
    --cc=yuzhao@google.com \
    --cc=zbestahu@gmail.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.