* [PATCH 1/2] driver: reset: spacemit-p1: add driver for poweroff/reboot
@ 2025-09-27 22:07 ` Aurelien Jarno
0 siblings, 0 replies; 18+ messages in thread
From: Aurelien Jarno @ 2025-09-27 22:07 UTC (permalink / raw)
To: linux-kernel, Lee Jones, Sebastian Reichel, Yixun Lan,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti
Cc: Aurelien Jarno, open list:SYSTEM RESET/SHUTDOWN DRIVERS,
open list:RISC-V SPACEMIT SoC Support,
open list:RISC-V SPACEMIT SoC Support
This driver implements poweroff/reboot support for the SpacemiT P1 PMIC
chip, which is commonly paired with the SpacemiT K1 SoC.
The SpacemiT P1 support is implemented as a MFD driver, so the access is
done directly through the regmap interface. Reboot or poweroff is
triggered by setting a specific bit in a control register, which is
automatically cleared by the hardware afterwards.
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
drivers/power/reset/Kconfig | 9 +++
drivers/power/reset/Makefile | 1 +
drivers/power/reset/spacemit-p1-reboot.c | 88 ++++++++++++++++++++++++
3 files changed, 98 insertions(+)
create mode 100644 drivers/power/reset/spacemit-p1-reboot.c
diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
index 77ea3129c7080..5afef049760d6 100644
--- a/drivers/power/reset/Kconfig
+++ b/drivers/power/reset/Kconfig
@@ -276,6 +276,15 @@ config POWER_RESET_KEYSTONE
help
Reboot support for the KEYSTONE SoCs.
+config POWER_RESET_SPACEMIT_P1
+ bool "SpacemiT P1 poweroff and reset driver"
+ depends on ARCH_SPACEMIT || COMPILE_TEST
+ select MFD_SPACEMIT_P1
+ default ARCH_SPACEMIT
+ help
+ This driver supports power-off and reset operations for the SpacemiT
+ P1 PMIC.
+
config POWER_RESET_SYSCON
bool "Generic SYSCON regmap reset driver"
depends on OF
diff --git a/drivers/power/reset/Makefile b/drivers/power/reset/Makefile
index b7c2b5940be99..cb6fb1be865db 100644
--- a/drivers/power/reset/Makefile
+++ b/drivers/power/reset/Makefile
@@ -24,6 +24,7 @@ obj-$(CONFIG_POWER_RESET_LTC2952) += ltc2952-poweroff.o
obj-$(CONFIG_POWER_RESET_QNAP) += qnap-poweroff.o
obj-$(CONFIG_POWER_RESET_REGULATOR) += regulator-poweroff.o
obj-$(CONFIG_POWER_RESET_RESTART) += restart-poweroff.o
+obj-$(CONFIG_POWER_RESET_SPACEMIT_P1) += spacemit-p1-reboot.o
obj-$(CONFIG_POWER_RESET_ST) += st-poweroff.o
obj-$(CONFIG_POWER_RESET_TORADEX_EC) += tdx-ec-poweroff.o
obj-$(CONFIG_POWER_RESET_TPS65086) += tps65086-restart.o
diff --git a/drivers/power/reset/spacemit-p1-reboot.c b/drivers/power/reset/spacemit-p1-reboot.c
new file mode 100644
index 0000000000000..105e19701ef85
--- /dev/null
+++ b/drivers/power/reset/spacemit-p1-reboot.c
@@ -0,0 +1,88 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2025 by Aurelien Jarno
+ */
+
+#include <linux/bits.h>
+#include <linux/mod_devicetable.h>
+#include <linux/platform_device.h>
+#include <linux/regmap.h>
+#include <linux/reboot.h>
+
+/* Power Control Register 2 */
+#define PWR_CTRL2 0x7e
+#define PWR_CTRL2_SHUTDOWN BIT(2) /* Shutdown request */
+#define PWR_CTRL2_RST BIT(1) /* Reset request */
+
+static int spacemit_p1_pwroff_handler(struct sys_off_data *data)
+{
+ struct regmap *regmap = data->cb_data;
+ int ret;
+
+ /* Put the PMIC into shutdown state */
+ ret = regmap_set_bits(regmap, PWR_CTRL2, PWR_CTRL2_SHUTDOWN);
+ if (ret) {
+ dev_err(data->dev, "shutdown failed: %d\n", ret);
+ return notifier_from_errno(ret);
+ }
+
+ return NOTIFY_DONE;
+}
+
+static int spacemit_p1_restart_handler(struct sys_off_data *data)
+{
+ struct regmap *regmap = data->cb_data;
+ int ret;
+
+ /* Put the PMIC into reset state */
+ ret = regmap_set_bits(regmap, PWR_CTRL2, PWR_CTRL2_RST);
+ if (ret) {
+ dev_err(data->dev, "restart failed: %d\n", ret);
+ return notifier_from_errno(ret);
+ }
+
+ return NOTIFY_DONE;
+}
+
+static int spacemit_p1_reboot_probe(struct platform_device *pdev)
+{
+ struct device *dev = &pdev->dev;
+ struct regmap *regmap;
+ int ret;
+
+ regmap = dev_get_regmap(dev->parent, NULL);
+ if (!regmap)
+ return -ENODEV;
+
+ ret = devm_register_power_off_handler(dev, &spacemit_p1_pwroff_handler, regmap);
+ if (ret) {
+ dev_err(dev, "Failed to register power off handler: %d\n", ret);
+ return ret;
+ }
+
+ ret = devm_register_restart_handler(dev, spacemit_p1_restart_handler, regmap);
+ if (ret) {
+ dev_err(dev, "Failed to register restart handler: %d\n", ret);
+ return ret;
+ }
+
+ return 0;
+}
+
+static const struct platform_device_id spacemit_p1_reboot_id_table[] = {
+ { "spacemit-p1-reboot", },
+ { /* sentinel */ },
+};
+MODULE_DEVICE_TABLE(platform, spacemit_p1_reboot_id_table);
+
+static struct platform_driver spacemit_p1_reboot_driver = {
+ .driver = {
+ .name = "spacemit-p1-reboot",
+ },
+ .probe = spacemit_p1_reboot_probe,
+ .id_table = spacemit_p1_reboot_id_table,
+};
+module_platform_driver(spacemit_p1_reboot_driver);
+
+MODULE_DESCRIPTION("SpacemiT P1 reboot/poweroff driver");
+MODULE_LICENSE("GPL");
--
2.47.2
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH 1/2] driver: reset: spacemit-p1: add driver for poweroff/reboot
2025-09-27 22:07 ` Aurelien Jarno
@ 2025-09-28 0:02 ` Yixun Lan
-1 siblings, 0 replies; 18+ messages in thread
From: Yixun Lan @ 2025-09-28 0:02 UTC (permalink / raw)
To: Aurelien Jarno
Cc: linux-kernel, Lee Jones, Sebastian Reichel, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
open list:SYSTEM RESET/SHUTDOWN DRIVERS,
open list:RISC-V SPACEMIT SoC Support,
open list:RISC-V SPACEMIT SoC Support
Hi Aurelien,
On 00:07 Sun 28 Sep , Aurelien Jarno wrote:
> This driver implements poweroff/reboot support for the SpacemiT P1 PMIC
> chip, which is commonly paired with the SpacemiT K1 SoC.
>
> The SpacemiT P1 support is implemented as a MFD driver, so the access is
> done directly through the regmap interface. Reboot or poweroff is
> triggered by setting a specific bit in a control register, which is
> automatically cleared by the hardware afterwards.
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> drivers/power/reset/Kconfig | 9 +++
> drivers/power/reset/Makefile | 1 +
> drivers/power/reset/spacemit-p1-reboot.c | 88 ++++++++++++++++++++++++
> 3 files changed, 98 insertions(+)
> create mode 100644 drivers/power/reset/spacemit-p1-reboot.c
>
> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> index 77ea3129c7080..5afef049760d6 100644
> --- a/drivers/power/reset/Kconfig
> +++ b/drivers/power/reset/Kconfig
[snip]..
> +
> +static int spacemit_p1_reboot_probe(struct platform_device *pdev)
> +{
> + struct device *dev = &pdev->dev;
> + struct regmap *regmap;
> + int ret;
> +
> + regmap = dev_get_regmap(dev->parent, NULL);
> + if (!regmap)
> + return -ENODEV;
> +
> + ret = devm_register_power_off_handler(dev, &spacemit_p1_pwroff_handler, regmap);
> + if (ret) {
> + dev_err(dev, "Failed to register power off handler: %d\n", ret);
> + return ret;
suggest to simplify with dev_err_probe(), which will save few lines
> + }
> +
> + ret = devm_register_restart_handler(dev, spacemit_p1_restart_handler, regmap);
> + if (ret) {
> + dev_err(dev, "Failed to register restart handler: %d\n", ret);
> + return ret;
ditto
> + }
> +
> + return 0;
> +}
> +
> +static const struct platform_device_id spacemit_p1_reboot_id_table[] = {
> + { "spacemit-p1-reboot", },
> + { /* sentinel */ },
> +};
> +MODULE_DEVICE_TABLE(platform, spacemit_p1_reboot_id_table);
> +
> +static struct platform_driver spacemit_p1_reboot_driver = {
> + .driver = {
> + .name = "spacemit-p1-reboot",
> + },
> + .probe = spacemit_p1_reboot_probe,
> + .id_table = spacemit_p1_reboot_id_table,
> +};
> +module_platform_driver(spacemit_p1_reboot_driver);
> +
> +MODULE_DESCRIPTION("SpacemiT P1 reboot/poweroff driver");
> +MODULE_LICENSE("GPL");
> --
> 2.47.2
>
--
Yixun Lan (dlan)
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 1/2] driver: reset: spacemit-p1: add driver for poweroff/reboot
@ 2025-09-28 0:02 ` Yixun Lan
0 siblings, 0 replies; 18+ messages in thread
From: Yixun Lan @ 2025-09-28 0:02 UTC (permalink / raw)
To: Aurelien Jarno
Cc: linux-kernel, Lee Jones, Sebastian Reichel, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
open list:SYSTEM RESET/SHUTDOWN DRIVERS,
open list:RISC-V SPACEMIT SoC Support,
open list:RISC-V SPACEMIT SoC Support
Hi Aurelien,
On 00:07 Sun 28 Sep , Aurelien Jarno wrote:
> This driver implements poweroff/reboot support for the SpacemiT P1 PMIC
> chip, which is commonly paired with the SpacemiT K1 SoC.
>
> The SpacemiT P1 support is implemented as a MFD driver, so the access is
> done directly through the regmap interface. Reboot or poweroff is
> triggered by setting a specific bit in a control register, which is
> automatically cleared by the hardware afterwards.
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> drivers/power/reset/Kconfig | 9 +++
> drivers/power/reset/Makefile | 1 +
> drivers/power/reset/spacemit-p1-reboot.c | 88 ++++++++++++++++++++++++
> 3 files changed, 98 insertions(+)
> create mode 100644 drivers/power/reset/spacemit-p1-reboot.c
>
> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> index 77ea3129c7080..5afef049760d6 100644
> --- a/drivers/power/reset/Kconfig
> +++ b/drivers/power/reset/Kconfig
[snip]..
> +
> +static int spacemit_p1_reboot_probe(struct platform_device *pdev)
> +{
> + struct device *dev = &pdev->dev;
> + struct regmap *regmap;
> + int ret;
> +
> + regmap = dev_get_regmap(dev->parent, NULL);
> + if (!regmap)
> + return -ENODEV;
> +
> + ret = devm_register_power_off_handler(dev, &spacemit_p1_pwroff_handler, regmap);
> + if (ret) {
> + dev_err(dev, "Failed to register power off handler: %d\n", ret);
> + return ret;
suggest to simplify with dev_err_probe(), which will save few lines
> + }
> +
> + ret = devm_register_restart_handler(dev, spacemit_p1_restart_handler, regmap);
> + if (ret) {
> + dev_err(dev, "Failed to register restart handler: %d\n", ret);
> + return ret;
ditto
> + }
> +
> + return 0;
> +}
> +
> +static const struct platform_device_id spacemit_p1_reboot_id_table[] = {
> + { "spacemit-p1-reboot", },
> + { /* sentinel */ },
> +};
> +MODULE_DEVICE_TABLE(platform, spacemit_p1_reboot_id_table);
> +
> +static struct platform_driver spacemit_p1_reboot_driver = {
> + .driver = {
> + .name = "spacemit-p1-reboot",
> + },
> + .probe = spacemit_p1_reboot_probe,
> + .id_table = spacemit_p1_reboot_id_table,
> +};
> +module_platform_driver(spacemit_p1_reboot_driver);
> +
> +MODULE_DESCRIPTION("SpacemiT P1 reboot/poweroff driver");
> +MODULE_LICENSE("GPL");
> --
> 2.47.2
>
--
Yixun Lan (dlan)
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 1/2] driver: reset: spacemit-p1: add driver for poweroff/reboot
2025-09-28 0:02 ` Yixun Lan
@ 2025-09-28 18:01 ` Aurelien Jarno
-1 siblings, 0 replies; 18+ messages in thread
From: Aurelien Jarno @ 2025-09-28 18:01 UTC (permalink / raw)
To: Yixun Lan
Cc: linux-kernel, Lee Jones, Sebastian Reichel, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
open list:SYSTEM RESET/SHUTDOWN DRIVERS,
open list:RISC-V SPACEMIT SoC Support,
open list:RISC-V SPACEMIT SoC Support
Hi Yixun,
On 2025-09-28 08:02, Yixun Lan wrote:
> Hi Aurelien,
>
> On 00:07 Sun 28 Sep , Aurelien Jarno wrote:
> > This driver implements poweroff/reboot support for the SpacemiT P1 PMIC
> > chip, which is commonly paired with the SpacemiT K1 SoC.
> >
> > The SpacemiT P1 support is implemented as a MFD driver, so the access is
> > done directly through the regmap interface. Reboot or poweroff is
> > triggered by setting a specific bit in a control register, which is
> > automatically cleared by the hardware afterwards.
> >
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> > ---
> > drivers/power/reset/Kconfig | 9 +++
> > drivers/power/reset/Makefile | 1 +
> > drivers/power/reset/spacemit-p1-reboot.c | 88 ++++++++++++++++++++++++
> > 3 files changed, 98 insertions(+)
> > create mode 100644 drivers/power/reset/spacemit-p1-reboot.c
> >
> > diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> > index 77ea3129c7080..5afef049760d6 100644
> > --- a/drivers/power/reset/Kconfig
> > +++ b/drivers/power/reset/Kconfig
> [snip]..
> > +
> > +static int spacemit_p1_reboot_probe(struct platform_device *pdev)
> > +{
> > + struct device *dev = &pdev->dev;
> > + struct regmap *regmap;
> > + int ret;
> > +
> > + regmap = dev_get_regmap(dev->parent, NULL);
> > + if (!regmap)
> > + return -ENODEV;
> > +
> > + ret = devm_register_power_off_handler(dev, &spacemit_p1_pwroff_handler, regmap);
> > + if (ret) {
> > + dev_err(dev, "Failed to register power off handler: %d\n", ret);
> > + return ret;
> suggest to simplify with dev_err_probe(), which will save few lines
> > + }
> > +
> > + ret = devm_register_restart_handler(dev, spacemit_p1_restart_handler, regmap);
> > + if (ret) {
> > + dev_err(dev, "Failed to register restart handler: %d\n", ret);
> > + return ret;
> ditto
Thanks for the hint, that'll be in the next version.
Regards
Aurelien
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://aurel32.net
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 1/2] driver: reset: spacemit-p1: add driver for poweroff/reboot
@ 2025-09-28 18:01 ` Aurelien Jarno
0 siblings, 0 replies; 18+ messages in thread
From: Aurelien Jarno @ 2025-09-28 18:01 UTC (permalink / raw)
To: Yixun Lan
Cc: linux-kernel, Lee Jones, Sebastian Reichel, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
open list:SYSTEM RESET/SHUTDOWN DRIVERS,
open list:RISC-V SPACEMIT SoC Support,
open list:RISC-V SPACEMIT SoC Support
Hi Yixun,
On 2025-09-28 08:02, Yixun Lan wrote:
> Hi Aurelien,
>
> On 00:07 Sun 28 Sep , Aurelien Jarno wrote:
> > This driver implements poweroff/reboot support for the SpacemiT P1 PMIC
> > chip, which is commonly paired with the SpacemiT K1 SoC.
> >
> > The SpacemiT P1 support is implemented as a MFD driver, so the access is
> > done directly through the regmap interface. Reboot or poweroff is
> > triggered by setting a specific bit in a control register, which is
> > automatically cleared by the hardware afterwards.
> >
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> > ---
> > drivers/power/reset/Kconfig | 9 +++
> > drivers/power/reset/Makefile | 1 +
> > drivers/power/reset/spacemit-p1-reboot.c | 88 ++++++++++++++++++++++++
> > 3 files changed, 98 insertions(+)
> > create mode 100644 drivers/power/reset/spacemit-p1-reboot.c
> >
> > diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> > index 77ea3129c7080..5afef049760d6 100644
> > --- a/drivers/power/reset/Kconfig
> > +++ b/drivers/power/reset/Kconfig
> [snip]..
> > +
> > +static int spacemit_p1_reboot_probe(struct platform_device *pdev)
> > +{
> > + struct device *dev = &pdev->dev;
> > + struct regmap *regmap;
> > + int ret;
> > +
> > + regmap = dev_get_regmap(dev->parent, NULL);
> > + if (!regmap)
> > + return -ENODEV;
> > +
> > + ret = devm_register_power_off_handler(dev, &spacemit_p1_pwroff_handler, regmap);
> > + if (ret) {
> > + dev_err(dev, "Failed to register power off handler: %d\n", ret);
> > + return ret;
> suggest to simplify with dev_err_probe(), which will save few lines
> > + }
> > +
> > + ret = devm_register_restart_handler(dev, spacemit_p1_restart_handler, regmap);
> > + if (ret) {
> > + dev_err(dev, "Failed to register restart handler: %d\n", ret);
> > + return ret;
> ditto
Thanks for the hint, that'll be in the next version.
Regards
Aurelien
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://aurel32.net
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] driver: reset: spacemit-p1: add driver for poweroff/reboot
2025-09-27 22:07 ` Aurelien Jarno
@ 2025-09-28 2:10 ` Troy Mitchell
-1 siblings, 0 replies; 18+ messages in thread
From: Troy Mitchell @ 2025-09-28 2:10 UTC (permalink / raw)
To: Aurelien Jarno, linux-kernel, Lee Jones, Sebastian Reichel,
Yixun Lan, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Alexandre Ghiti
Cc: open list:SYSTEM RESET/SHUTDOWN DRIVERS,
open list:RISC-V SPACEMIT SoC Support,
open list:RISC-V SPACEMIT SoC Support, Troy Mitchell
On Sun, Sep 28, 2025 at 12:07:40AM +0200, Aurelien Jarno wrote:
> This driver implements poweroff/reboot support for the SpacemiT P1 PMIC
> chip, which is commonly paired with the SpacemiT K1 SoC.
>
> The SpacemiT P1 support is implemented as a MFD driver, so the access is
> done directly through the regmap interface. Reboot or poweroff is
> triggered by setting a specific bit in a control register, which is
> automatically cleared by the hardware afterwards.
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> drivers/power/reset/Kconfig | 9 +++
> drivers/power/reset/Makefile | 1 +
> drivers/power/reset/spacemit-p1-reboot.c | 88 ++++++++++++++++++++++++
> 3 files changed, 98 insertions(+)
> create mode 100644 drivers/power/reset/spacemit-p1-reboot.c
>
[...]
> +static int spacemit_p1_reboot_probe(struct platform_device *pdev)
> +{
> + struct device *dev = &pdev->dev;
> + struct regmap *regmap;
> + int ret;
> +
> + regmap = dev_get_regmap(dev->parent, NULL);
> + if (!regmap)
> + return -ENODEV;
> +
> + ret = devm_register_power_off_handler(dev, &spacemit_p1_pwroff_handler, regmap);
> + if (ret) {
> + dev_err(dev, "Failed to register power off handler: %d\n", ret);
> + return ret;
> + }
With fixing what Yixun said, LGTM.
Acked-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
> +
> + ret = devm_register_restart_handler(dev, spacemit_p1_restart_handler, regmap);
> + if (ret) {
> + dev_err(dev, "Failed to register restart handler: %d\n", ret);
> + return ret;
> + }
> +
> + return 0;
> +}
> +
> +static const struct platform_device_id spacemit_p1_reboot_id_table[] = {
> + { "spacemit-p1-reboot", },
> + { /* sentinel */ },
> +};
> +MODULE_DEVICE_TABLE(platform, spacemit_p1_reboot_id_table);
> +
> +static struct platform_driver spacemit_p1_reboot_driver = {
> + .driver = {
> + .name = "spacemit-p1-reboot",
> + },
> + .probe = spacemit_p1_reboot_probe,
> + .id_table = spacemit_p1_reboot_id_table,
> +};
> +module_platform_driver(spacemit_p1_reboot_driver);
> +
> +MODULE_DESCRIPTION("SpacemiT P1 reboot/poweroff driver");
> +MODULE_LICENSE("GPL");
> --
> 2.47.2
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 1/2] driver: reset: spacemit-p1: add driver for poweroff/reboot
@ 2025-09-28 2:10 ` Troy Mitchell
0 siblings, 0 replies; 18+ messages in thread
From: Troy Mitchell @ 2025-09-28 2:10 UTC (permalink / raw)
To: Aurelien Jarno, linux-kernel, Lee Jones, Sebastian Reichel,
Yixun Lan, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Alexandre Ghiti
Cc: open list:SYSTEM RESET/SHUTDOWN DRIVERS,
open list:RISC-V SPACEMIT SoC Support,
open list:RISC-V SPACEMIT SoC Support, Troy Mitchell
On Sun, Sep 28, 2025 at 12:07:40AM +0200, Aurelien Jarno wrote:
> This driver implements poweroff/reboot support for the SpacemiT P1 PMIC
> chip, which is commonly paired with the SpacemiT K1 SoC.
>
> The SpacemiT P1 support is implemented as a MFD driver, so the access is
> done directly through the regmap interface. Reboot or poweroff is
> triggered by setting a specific bit in a control register, which is
> automatically cleared by the hardware afterwards.
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> drivers/power/reset/Kconfig | 9 +++
> drivers/power/reset/Makefile | 1 +
> drivers/power/reset/spacemit-p1-reboot.c | 88 ++++++++++++++++++++++++
> 3 files changed, 98 insertions(+)
> create mode 100644 drivers/power/reset/spacemit-p1-reboot.c
>
[...]
> +static int spacemit_p1_reboot_probe(struct platform_device *pdev)
> +{
> + struct device *dev = &pdev->dev;
> + struct regmap *regmap;
> + int ret;
> +
> + regmap = dev_get_regmap(dev->parent, NULL);
> + if (!regmap)
> + return -ENODEV;
> +
> + ret = devm_register_power_off_handler(dev, &spacemit_p1_pwroff_handler, regmap);
> + if (ret) {
> + dev_err(dev, "Failed to register power off handler: %d\n", ret);
> + return ret;
> + }
With fixing what Yixun said, LGTM.
Acked-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
> +
> + ret = devm_register_restart_handler(dev, spacemit_p1_restart_handler, regmap);
> + if (ret) {
> + dev_err(dev, "Failed to register restart handler: %d\n", ret);
> + return ret;
> + }
> +
> + return 0;
> +}
> +
> +static const struct platform_device_id spacemit_p1_reboot_id_table[] = {
> + { "spacemit-p1-reboot", },
> + { /* sentinel */ },
> +};
> +MODULE_DEVICE_TABLE(platform, spacemit_p1_reboot_id_table);
> +
> +static struct platform_driver spacemit_p1_reboot_driver = {
> + .driver = {
> + .name = "spacemit-p1-reboot",
> + },
> + .probe = spacemit_p1_reboot_probe,
> + .id_table = spacemit_p1_reboot_id_table,
> +};
> +module_platform_driver(spacemit_p1_reboot_driver);
> +
> +MODULE_DESCRIPTION("SpacemiT P1 reboot/poweroff driver");
> +MODULE_LICENSE("GPL");
> --
> 2.47.2
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] driver: reset: spacemit-p1: add driver for poweroff/reboot
2025-09-27 22:07 ` Aurelien Jarno
@ 2025-09-29 6:35 ` Troy Mitchell
-1 siblings, 0 replies; 18+ messages in thread
From: Troy Mitchell @ 2025-09-29 6:35 UTC (permalink / raw)
To: Aurelien Jarno, linux-kernel, Lee Jones, Sebastian Reichel,
Yixun Lan, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Alexandre Ghiti
Cc: open list:SYSTEM RESET/SHUTDOWN DRIVERS,
open list:RISC-V SPACEMIT SoC Support,
open list:RISC-V SPACEMIT SoC Support, Troy Mitchell
On Sun, Sep 28, 2025 at 12:07:40AM +0200, Aurelien Jarno wrote:
> This driver implements poweroff/reboot support for the SpacemiT P1 PMIC
> chip, which is commonly paired with the SpacemiT K1 SoC.
>
> The SpacemiT P1 support is implemented as a MFD driver, so the access is
> done directly through the regmap interface. Reboot or poweroff is
> triggered by setting a specific bit in a control register, which is
> automatically cleared by the hardware afterwards.
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Thanks.
Tested-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] driver: reset: spacemit-p1: add driver for poweroff/reboot
@ 2025-09-29 6:35 ` Troy Mitchell
0 siblings, 0 replies; 18+ messages in thread
From: Troy Mitchell @ 2025-09-29 6:35 UTC (permalink / raw)
To: Aurelien Jarno, linux-kernel, Lee Jones, Sebastian Reichel,
Yixun Lan, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Alexandre Ghiti
Cc: open list:SYSTEM RESET/SHUTDOWN DRIVERS,
open list:RISC-V SPACEMIT SoC Support,
open list:RISC-V SPACEMIT SoC Support, Troy Mitchell
On Sun, Sep 28, 2025 at 12:07:40AM +0200, Aurelien Jarno wrote:
> This driver implements poweroff/reboot support for the SpacemiT P1 PMIC
> chip, which is commonly paired with the SpacemiT K1 SoC.
>
> The SpacemiT P1 support is implemented as a MFD driver, so the access is
> done directly through the regmap interface. Reboot or poweroff is
> triggered by setting a specific bit in a control register, which is
> automatically cleared by the hardware afterwards.
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Thanks.
Tested-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 18+ messages in thread